Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20211221031638.3499920-1-peng.fan@oss.nxp.com>
References: <20211221031638.3499920-1-peng.fan@oss.nxp.com>
Subject: Re: [PATCH] clk: bulk: export of_clk_bulk_get_all
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-kernel@vger.kernel.org, van.freenix@gmail.com,
        Peng Fan <peng.fan@nxp.com>
To:     Peng Fan (OSS) <peng.fan@oss.nxp.com>, aisheng.dong@nxp.com,
        bjorn.andersson@linaro.org, jbrunet@baylibre.com,
        linux-clk@vger.kernel.org, s.nawrocki@samsung.com,
        shawn.lin@rock-chips.com, ulf.hansson@linaro.org
Date:   Wed, 05 Jan 2022 17:17:16 -0800
User-Agent: alot/0.9.1
Message-Id: <20220106011718.28688C36AE3@smtp.kernel.org>
Precedence: bulk

Quoting Peng Fan (OSS) (2021-12-20 19:16:38)
> From: Peng Fan <peng.fan@nxp.com>
>=20
> There are cases that need to get the bulk clks of a device_node which not
> has device created, so export of_clk_bulk_get_all to let consumers could
> use it.
>=20
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>=20
> V1:
>      An example here, mediamix node has clocks property, but it will not

Sorry I don't get the example. What does a DT snippet have to do with
modular kernel code? What specific kernel module is calling this API?

>      have device of it, so we need of_X api to get the clks.
>      src: src@0x30390000 {
>           compatible =3D "fsl,imx[X]-src";
>           reg =3D <0x30390000 0x10000>;
>=20
>           slice {

Is this upstream?

>                 #address-cells =3D <1>;
>                 #size-cells =3D <0>;
>=20
>                 mediamix: slice@2400 {
>                    reg =3D <IMX93_POWER_DOMAIN_MEDIAMIX>;
>                    #power-domain-cells =3D <0>;