Date:   Thu, 6 Jan 2022 06:31:06 +0200
From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     Ido Schimmel <idosch@idosch.org>
Cc:     netdev@vger.kernel.org, stephen@networkplumber.org, andrew@lunn.ch,
        Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 6/6] net: marvell: prestera: Implement
 initial inetaddr notifiers
Message-ID: <YdZwigIn6IG3a4h4@yorlov.ow.s>
References: <20211227215233.31220-1-yevhen.orlov@plvision.eu>
 <20211227215233.31220-7-yevhen.orlov@plvision.eu>
 <Yc3EmyltW1BVQv2n@shredder>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yc3EmyltW1BVQv2n@shredder>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i9UB3VsewQDgltzDRwOIG+FYUZ5KSFfWor3gmPrk+HnAe9iQt1Bc+VKiKFaG?=
 =?us-ascii?Q?eutzQt2jKYbnyTNHj39GrpeSo55f21rv0hgA/s0MAX/TKI/eNv0lXqls8kMC?=
 =?us-ascii?Q?bTN1Ym9/IlMYlF+lAeK0LYCJ+hh1SBNuiNXme6ODzpYNjYPLkA9owv8DffRF?=
 =?us-ascii?Q?HL0xTdS+9EZpbv9OJjf4WFHo5+9ydAnxDI810xPX8OroOuWnKs9lhrnIxdJU?=
 =?us-ascii?Q?fNee9lh1Cmg4XE3cwyR+mJqIudMpwZYrtG8Tgpa01yQ9J0Ro2acu/kRdEl5y?=
 =?us-ascii?Q?fx5HlR+C3KP/XZIe31HAc6wD5svbIIVSMwr2NCWw2y4G6RoSzu3VlKkb6yGm?=
 =?us-ascii?Q?AzdF5hAbdqsRT4ABx1DATnJn0CDLLTTXa7kHSj2qI0u/5W9fbkxazbHBhG++?=
 =?us-ascii?Q?xEybx4kcMIN5ghMLhHzEKMye+DbcRFt4E7gka7XeaHBM+wY/cxEK9R+8Qpk5?=
 =?us-ascii?Q?ZpIkU8kZ7j/pbH2QiRfMqXZE6wreUW/Dqpn0vJ6vh9MzuLdb9PyiITsHQ+If?=
 =?us-ascii?Q?1tdGCHdSl2k2l9Kgf2gcilyKNPPUWhkhBgtt6/rHQQhOT44CtXJ1yILY+xJK?=
 =?us-ascii?Q?NRM6ewR4EP3M2kcNwK3cM4WqqOQ64hV1umXZunjRRFImZ7jUHdT5BKFAM8DE?=
 =?us-ascii?Q?jUHA+1gOdmc+SkWgpvaYpdae7FWOYcjir8d4yqXLxziSBTiReAxZEtkKWhI0?=
 =?us-ascii?Q?gH0QWARC7Pje+G68xG3/cOrGm3I6nQLzgK6zSLTKE+JyQgED9+Wz5lOzj4QY?=
 =?us-ascii?Q?az7u8yF0Kis3jD//CSGO/EhlaBdL8sF2LCWNh5Z6AjeflPzWyiIPJO8+9H9+?=
 =?us-ascii?Q?eqaKdto10uVHPml42FHVo180Izf2JsuvUT4LGh9PP2u6PQmTFbM4Bu7tC+0O?=
 =?us-ascii?Q?ZCK5zbzeC/sneHjdoGwml0hC91goyXSg61ePzkhoVwu83Z/4454V4/amlAat?=
 =?us-ascii?Q?GFhy4J2hbVW3SmXGvT+/EB3SD/u+Lqk7MfwoqL+JtyQaXzLqm0OCD+Ho0LJB?=
 =?us-ascii?Q?XflwBjrZqHOCIw9bECu1vqRs/Xn6TgXwFd/nUvKmaonWh/ORs1C2csoRkUhR?=
 =?us-ascii?Q?ZQcQirne9kuGOAYUaXV5eqymNlAiCXOwLozx0IwqLzUSsDVKlCeqazq+mf2K?=
 =?us-ascii?Q?AVs99sUacE4CIfKaILvCOY9MqIWTj3upoFQbwQaWz77zjbQdGEdfQQ5vBvXH?=
 =?us-ascii?Q?NflOZjVegGeexsF4ItDzr8nMZ53Gl8iRgNnmCdoX+VgTk73RweuRohtnxag+?=
 =?us-ascii?Q?H8gmunrFv/H+NGTYu8AaflkAwTTAbUtuAzCkDp5/bNMHaqCpGpzsOKMFJz6S?=
 =?us-ascii?Q?kdQnM9iOqdftr4Ayw+XLr2DqWEUupFeN+a0sOrGGnCBp8Q32DIZitL/JGaBn?=
 =?us-ascii?Q?3yuTM/dpNlMxh4bunHUzWwNho2YYQVvQy7mhg/wj3O+iBE1u9uY2wHWrNFKv?=
 =?us-ascii?Q?0iD/bPcp853UQiDtlvkULcgwfew5JRo6aMSJsJsRxCeTC0Hj7ZT06DKg9DqQ?=
 =?us-ascii?Q?2yEa1VwtK59yvncuzU/GPtRUwSr8lSY4lwHN7Ifw+QHi0Tg8REn2lEnn0Frf?=
 =?us-ascii?Q?Jg8QJRcc0LKpusaOWNiCfzpudiLNROimDwOiAYdPRzGIN6Z0l5wsq9Q3vlF/?=
 =?us-ascii?Q?FI0Gy6y05Elan0Si8lgIFyMnZrdtUtuPBuBoHpOZrxEFMnUzkIq1qOU0c6A4?=
 =?us-ascii?Q?l34VoZ6KjvMSTfvs0n5r5iTWGOc=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 4463bc7e-df11-4e92-46ed-08d9d0cd5cbb
X-MS-Exchange-CrossTenant-AuthSource: AM9P190MB1122.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2022 04:31:09.3535
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vWdiK+tgz1Nh+V6iZtgPukH28mxvsVp5RsbYIOZlypJQZJsBF8patsqm8pV965kaa7TzB8YzbPqYZ0Z68BhefJ9a6DBMefniL8Ij7EjguoI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9P190MB1427
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 30, 2021 at 04:39:23PM +0200, Ido Schimmel wrote:
> > +			return -EEXIST;
> > +		}
> > +		re = prestera_rif_entry_create(port->sw, &re_key,
> > +					       prestera_fix_tb_id(kern_tb_id),
> > +					       port_dev->dev_addr);
> > +		if (!re) {
> > +			NL_SET_ERR_MSG_MOD(extack, "Can't create rif_entry");
> > +			return -EINVAL;
> > +		}
> > +		dev_hold(port_dev);
>
> What is the purpose of this dev_hold()?
>

To make sure the port_dev is not freed before rif destroyed.