IronPort-SDR: ylYgWM+lGyikAi93oAIAg68+wbOIWmxy7CbsR5KYxZ6+p5aHzMSHOM237kskxRvKxAv7UOyWXM
 KTr7Ip+ksiV1D+/oGh2zE+547DkHXUXd83JB4YmEyIlkF5cPQR+XRZSlZX+jzwJ8XeCtNF+XxD
 Mddwczvij9dHAowhz/+WEbAxvTTC9nxnDEHsU05/KOq5a6z23+YWOQ8txjHv4itTluQJEknqJf
 UXk7/FRi13UTmzNgiFXc7Bxnsy8lgb6/0i9R6yLzjfKPWVh4vImUyoavn4TzLqAxlgCPtk1y+P
 EUd6pXHd9TV/FE4T19KwyOCw
IronPort-SDR: wRThyWVq0SEn/tmTttv55W1p9BbDzf/4V/XozMyCvvzZuUzPO4h2SHe6Rm5F+nQkw3ZENGHgoZ
 cLuKcLMI/GbK3vw2bX7nWUk+faVeBPugNFc/RzTnFhNscB01H5kDhw58kdLYs8kBha04FomQWe
 hEr5YKbPemHfH82iUim6R/UdcLACNGb+mmxJDX9l/d0eXmtxgO6rq43ZApP6z3iApXXZGUaF2R
 1EvYVCbZ58wyE0hwgUpxUaeRatD5lBIcZyIqrGXpG4HzUH9Gc7VgskXJefhmH9L9ZVzkDQByDc
 uU0=
WDCIronportException: Internal
Message-ID: <3cb24d6e-d52c-827f-7905-8e17411b23e1@opensource.wdc.com>
Date:   Thu, 6 Jan 2022 14:21:24 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v3 3/3] scsi: Set allocation length to 255 for ATA
 Information VPD page
Content-Language: en-US
To:     "Martin K. Petersen" <martin.petersen@oracle.com>,
        "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc:     Douglas Gilbert <dgilbert@interlog.com>,
        Khalid Aziz <khalid@gonehiking.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Christoph Hellwig <hch@lst.de>, Nix <nix@esperi.org.uk>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <alpine.DEB.2.21.2201020010540.56863@angie.orcam.me.uk>
 <alpine.DEB.2.21.2201020030130.56863@angie.orcam.me.uk>
 <d9eaa1f8-7abb-645b-d624-5069205c6983@interlog.com>
 <alpine.DEB.2.21.2201032017290.56863@angie.orcam.me.uk>
 <yq1tuek347m.fsf@ca-mkp.ca.oracle.com>
 <alpine.DEB.2.21.2201032324230.56863@angie.orcam.me.uk>
 <yq1tuej1j22.fsf@ca-mkp.ca.oracle.com> <yq1lezty169.fsf@ca-mkp.ca.oracle.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <yq1lezty169.fsf@ca-mkp.ca.oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/6/22 13:13, Martin K. Petersen wrote:
> 
> Maciej,
> 
>> Oh, you'll also need a follow-on patch that uses the cached ATA
>> Information VPD page. I'll try to get my full series out today.
> 
> I would really appreciate it if you would be willing give this a whirl:
> 
> 	https://git.kernel.org/mkp/h/5.18/discovery

Martin,

Indeed, my bad.

That said, it is weird that scsi_get_vpd_page() does not call
scsi_device_supports_vpd(). We could simplify everything like this:

diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index f6af1562cba4..c27eabedf9e3 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -341,7 +341,7 @@ int scsi_get_vpd_page(struct scsi_device *sdev, u8
page, unsigned char *buf,
 {
        int i, result;

-       if (sdev->skip_vpd_pages)
+       if (!scsi_device_supports_vpd(sdev))
                goto fail;

        /* Ask for all the pages supported by this device */
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 65875a598d62..2ef7953512ed 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -3316,12 +3316,10 @@ static int sd_revalidate_disk(struct gendisk *disk)
                blk_queue_flag_clear(QUEUE_FLAG_NONROT, q);
                blk_queue_flag_set(QUEUE_FLAG_ADD_RANDOM, q);

-               if (scsi_device_supports_vpd(sdp)) {
-                       sd_read_block_provisioning(sdkp);
-                       sd_read_block_limits(sdkp);
-                       sd_read_block_characteristics(sdkp);
-                       sd_zbc_read_zones(sdkp, buffer);
-               }
+               sd_read_block_provisioning(sdkp);
+               sd_read_block_limits(sdkp);
+               sd_read_block_characteristics(sdkp);
+               sd_zbc_read_zones(sdkp, buffer);

                sd_print_capacity(sdkp, old_capacity);

Since all the sd_read_xxx() functions do nothing if the vpd page needed
is not supported.


-- 
Damien Le Moal
Western Digital Research