Date:   Thu, 6 Jan 2022 14:19:32 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     "rafael@kernel.org" <rafael@kernel.org>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] cpufreq: amd-pstate: Fix struct amd_cpudata
 kernel-doc comment
Message-ID: <YdaJ9GFoz4AlIgQv@amd.com>
References: <20220106021605.93341-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220106021605.93341-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HEETacEEAG0W3kYHBWheXLrMGfCy9LzgHlpk+pICokHZg/5H8+JbDHR3jWT0?=
 =?us-ascii?Q?l15EeEzvu4hDKU7gRoRtFNlq7VcI7Lm1CP/xHKe5+pGQZaLV6fnlNRlwMs+h?=
 =?us-ascii?Q?IY6rcYmMlmBkMLIqkpF1TeiVycPrgDeH4yFim+gK7DR1hv5O+atj6HbNRVxl?=
 =?us-ascii?Q?jHbEBqEvWndQowZMUSYRnr28iEU9GZq3sKHfgg5Pl4iLZIxoKZm5PbutFdFy?=
 =?us-ascii?Q?rpohBZm+H0Cjcye8Fy4tDrXkzHn0vxEvKjD3QZHgOEEugxZJQ8v57UiHLbcA?=
 =?us-ascii?Q?go6iDHGLUiVizQfSsc1YHC698woLICO3DZxANPlXPeRxmY767XM933XYzFDf?=
 =?us-ascii?Q?Hlp+k6jXKHolpq9REVZCmVD0cRCK2f0DBgjRlAgBSH6k05HJCi701uu3+lZL?=
 =?us-ascii?Q?onmYF3cnzI3iqfY8VNeoIlU9HgtDhZ1dpk9IcULeW/zuPJY62gdmTnbq5Fo4?=
 =?us-ascii?Q?b8Fhf+yksYrksBiJTdhved/wHB6mokCt0LmnJrsRJeYcB9FsdxgdZQckn0eC?=
 =?us-ascii?Q?vD/oh9wP4FeF5DSh7+jF/+LQXM8uR/XT0VbflJTIIF9qyZViLyQu+ZWPBIha?=
 =?us-ascii?Q?epgQXSm2GEf4H7d0Ht98I80RO8TwB5igDE0fRreN2TAdoRwK3xNTdj9Ybaoy?=
 =?us-ascii?Q?KSGODcX0DAlB9LTnz7fULe9LVCyD094OrKsQRqFx9DAqb+tDdXtz8Gz6UfOg?=
 =?us-ascii?Q?/oIIK52Dmd2Rj+BIZoh0BA3ZIh2rEIwP8GOU3E50n1zhobLx4bcgwn7imtJm?=
 =?us-ascii?Q?PPYXqXj2vER3du8+5V5rj2mCruMF1+HDwatHrFyV8jfbpzmkEDP3VfUhdiZs?=
 =?us-ascii?Q?CfwgOdLoV1Tuf127QruJ8UPYdZdJQr8N1k7TwyCIT6AoT3+mg51UQZcYQZFy?=
 =?us-ascii?Q?xsPN8ksSYTecne5xLqZt2q3puDxr/8S+mvdbSbNSp5mKfAPamqWxMVJJiwsI?=
 =?us-ascii?Q?ua2CCWDNzsRvwbK2AuwDoACPeWSoJoaxWzQ5XKFp7/GnGjUqQHMHrA+V+wRZ?=
 =?us-ascii?Q?nFFnZGzigFEtJ8I5CwXlrYiFvoxw6Q8CucZORRNTA1Y4Xi51oPdfE/WVFZIA?=
 =?us-ascii?Q?Ly7sQMvXeIl0DXrZQcS9qBVzo6miDMXB/a47kFjRaCuazGKy24dVENmh2t7V?=
 =?us-ascii?Q?ndz1dKAlVsCpsSmZsdY5TILCIl1VhTDqmYgDAEWZ2eWUQ442ggEF72/T1Ase?=
 =?us-ascii?Q?3R5W/V8kqo+Ji47sIii5LmoAMvRgNncOsrfHqc8aUCw4f7OlqfhxciiM1Ig5?=
 =?us-ascii?Q?QjHtrG8KsHe2HE1OKKljoWsHJ5hFv1mtk6PG3sQTGce6eOcoO79rVg691Ptb?=
 =?us-ascii?Q?zrUYO10fsKaNo4eH0Dys+OzUEmi95qr4YD4oHpcpEyYSNCGcfCZSne4L651z?=
 =?us-ascii?Q?n+Eb4fY5hrQNteVEl50dAWU6ryFIvmIZOCnDgAea5gvUyE0qLA+Js8HPPLJV?=
 =?us-ascii?Q?rRH0TC92zF3uDDXQMvpeknEsE5gr6EtCq+rEMzivUshSQmxm0QrLt1uCKQSa?=
 =?us-ascii?Q?obLCVA6OzSYJreSn5wgct61/nhpxRKq7KdfnZ+Nj2rTbobIliHGOgQBn3WKL?=
 =?us-ascii?Q?4MBiJANZwWcmlegw3L3UC1rXoyAzCs6MhIGg2rRQrSFPxOFbJbXGWckVxleX?=
 =?us-ascii?Q?SIcDPWReL55bbqKLq6AxEUo=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94d9dfc6-7326-4bee-4ffa-08d9d0dc8f3e
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2022 06:19:57.0649
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ki/vP4uo3BKhnJin3AayfTpsrr4NmilgRs3PWZVdJk7ETtRMgnFVhGqsaJciGS+A4SwwDUe6fw0tAPktj/9vAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1644
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 06, 2022 at 10:16:05AM +0800, Yang Li wrote:
> Add the description of @req and @boost_supported in struct amd_cpudata
> kernel-doc comment to remove warnings found by running scripts/kernel-doc,
> which is caused by using 'make W=1'.
> 
> drivers/cpufreq/amd-pstate.c:104: warning: Function parameter or member
> 'req' not described in 'amd_cpudata'
> drivers/cpufreq/amd-pstate.c:104: warning: Function parameter or member
> 'boost_supported' not described in 'amd_cpudata'
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/cpufreq/amd-pstate.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 40ceb031abf5..9ce75ed11f8e 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -68,6 +68,7 @@ static struct cpufreq_driver amd_pstate_driver;
>  /**
>   * struct amd_cpudata - private CPU data for AMD P-State
>   * @cpu: CPU number
> + * @req: constraint request to apply
>   * @cppc_req_cached: cached performance request hints
>   * @highest_perf: the maximum performance an individual processor may reach,
>   *		  assuming ideal conditions
> @@ -80,6 +81,7 @@ static struct cpufreq_driver amd_pstate_driver;
>   * @min_freq: the frequency that mapped to lowest_perf
>   * @nominal_freq: the frequency that mapped to nominal_perf
>   * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf
> + * @boost_supported: check whether the Processor or SBIOS supports boost mode
>   *
>   * The amd_cpudata is key private data for each CPU thread in AMD P-State, and
>   * represents all the attributes and goals that AMD P-State requests at runtime.
> -- 
> 2.20.1.7.g153144c
>