Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A83E3C433EF for ; Thu, 6 Jan 2022 06:57:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235266AbiAFG5V (ORCPT ); Thu, 6 Jan 2022 01:57:21 -0500 Received: from smtp21.cstnet.cn ([159.226.251.21]:35392 "EHLO cstnet.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234429AbiAFG5U (ORCPT ); Thu, 6 Jan 2022 01:57:20 -0500 Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-01 (Coremail) with SMTP id qwCowACnrZ26ktZhISPhBQ--.63675S2; Thu, 06 Jan 2022 14:56:58 +0800 (CST) From: Jiasheng Jiang To: eric.piel@tremplin-utc.net, arnd@arndb.de, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] drivers/misc/lis3lv02d/lis3lv02d_i2c.c: Check for error return from regulator_bulk_enable in lis3_i2c_init Date: Thu, 6 Jan 2022 14:56:57 +0800 Message-Id: <20220106065657.2667748-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: qwCowACnrZ26ktZhISPhBQ--.63675S2 X-Coremail-Antispam: 1UD129KBjvdXoWrKF48WF18tr18tr4xJw1DZFb_yoWDurc_GF 9xZry7Zr98Z397X3ZxGa40vFyIkr4DWa4SgrWxKF43ta47GF1xGrykAry3X3y8JFWUWr1j qr4vv34Iqw42qjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc2xSY4AK67AK6r47 MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr 0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0E wIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJV W8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI 42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfU8xR6UUUUU X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Because of the possible failure of the consumer, the regulator_bulk_enable() may return error. Therefore, it should be better to check the return value of the lis3_reg_ctrl(). There are two callers, and I submit two patches to fix separately. This patch is about lis3_i2c_init(). Fixes: ec400c9fab99 ("lis3lv02d: make regulator API usage unconditional") Signed-off-by: Jiasheng Jiang --- drivers/misc/lis3lv02d/lis3lv02d_i2c.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c index 52555d2e824b..4001e3c0a167 100644 --- a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c +++ b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c @@ -69,7 +69,9 @@ static int lis3_i2c_init(struct lis3lv02d *lis3) u8 reg; int ret; - lis3_reg_ctrl(lis3, LIS3_REG_ON); + ret = lis3_reg_ctrl(lis3, LIS3_REG_ON); + if (ret) + return ret; lis3->read(lis3, WHO_AM_I, ®); if (reg != lis3->whoami) -- 2.25.1