Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6ABEC433EF for ; Thu, 6 Jan 2022 12:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238201AbiAFMJy (ORCPT ); Thu, 6 Jan 2022 07:09:54 -0500 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:42273 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232358AbiAFMJx (ORCPT ); Thu, 6 Jan 2022 07:09:53 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=cruzzhao@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0V15yiET_1641470987; Received: from 30.21.164.187(mailfrom:cruzzhao@linux.alibaba.com fp:SMTPD_---0V15yiET_1641470987) by smtp.aliyun-inc.com(127.0.0.1); Thu, 06 Jan 2022 20:09:50 +0800 Message-ID: Date: Thu, 6 Jan 2022 20:09:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 1/2] sched/core: Cookied forceidle accounting per cpu Content-Language: en-US To: Josh Don Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Mel Gorman , Daniel Bristot de Oliveira , Alexey Dobriyan , Eric Dumazet , linux-kernel , linux-fsdevel References: <1640262603-19339-1-git-send-email-CruzZhao@linux.alibaba.com> <1640262603-19339-2-git-send-email-CruzZhao@linux.alibaba.com> From: cruzzhao In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/1/6 上午4:47, Josh Don 写道: > On Wed, Jan 5, 2022 at 3:33 AM cruzzhao wrote: > > I don't see how this is very helpful for steal_cookie_task(), since it > isn't a targeted metric for that specific case. If you were interested > in that specifically, I'd think you'd want to look at more direct > metrics, such as task migration counts, or adding some > accounting/histogram for the time between steal and load balance away. > I've already read the patch "sched: CGroup tagging interface for core scheduling", but it hasn't been merged into linux-next. IMO it's better to do this at the cgroup level after the cgroup tagging interface is introduced. Best, Cruz Zhao > > That motivation makes more sense to me. Have you considered > accumulating this at the cgroup level (ie. attributing it as another > type of usage)?