Date:   Thu, 6 Jan 2022 14:18:56 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Ye Xiang <xiang.ye@intel.com>
cc:     jic23@kernel.org, srinivas.pandruvada@linux.intel.com,
        linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: intel-ish-hid: ipc: Specify no cache snooping on
 TGL and ADL
In-Reply-To: <20211217074541.4705-1-xiang.ye@intel.com>
Message-ID: <nycvar.YFH.7.76.2201061418460.16505@cbobk.fhfr.pm>
References: <20211217074541.4705-1-xiang.ye@intel.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 17 Dec 2021, Ye Xiang wrote:

> Specify that both TGL and ADL don't support DMA cache snooping.
> 
> Signed-off-by: Ye Xiang <xiang.ye@intel.com>
> ---
>  drivers/hid/intel-ish-hid/ipc/ipc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
> index 45e0c7b1c9ec..8ccb246b0114 100644
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -909,7 +909,11 @@ static uint32_t ish_ipc_get_header(struct ishtp_device *dev, int length,
>   */
>  static bool _dma_no_cache_snooping(struct ishtp_device *dev)
>  {
> -	return dev->pdev->device == EHL_Ax_DEVICE_ID;
> +	return (dev->pdev->device == EHL_Ax_DEVICE_ID ||
> +		dev->pdev->device == TGL_LP_DEVICE_ID ||
> +		dev->pdev->device == TGL_H_DEVICE_ID ||
> +		dev->pdev->device == ADL_S_DEVICE_ID ||
> +		dev->pdev->device == ADL_P_DEVICE_ID);
>  }

Applied, thank you.

-- 
Jiri Kosina
SUSE Labs