Subject: Re: [PATCH v5 7/8] KVM: VMX: Update PID-pointer table entry when APIC
 ID is changed
To:     Zeng Guang <guang.zeng@intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        Jethro Beekman <jethro@fortanix.com>,
        "Huang, Kai" <kai.huang@intel.com>
Cc:     "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Hu, Robert" <robert.hu@intel.com>,
        "Gao, Chao" <chao.gao@intel.com>
References: <20211231142849.611-1-guang.zeng@intel.com>
 <20211231142849.611-8-guang.zeng@intel.com>
 <640e82f3-489d-60af-1d31-25096bef1a46@amd.com>
 <4eee5de5-ab76-7094-17aa-adc552032ba0@intel.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <aa86022c-2816-4155-8d77-f4faf6018255@amd.com>
Date:   Thu, 6 Jan 2022 08:06:15 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <4eee5de5-ab76-7094-17aa-adc552032ba0@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTNIVGlqZ3ZzNzVXQ0NoK05YOVliS0FoZGRWenBlZ1hmb2ZkeFFtQjgwc3BF?=
 =?utf-8?B?WkhGckk1Z2xUUithRGJwR0xmdk8yTFNQeWVMVnVRYzhSR0VGNlZxWTJJUkNl?=
 =?utf-8?B?T1h3YTExQTgzOTNHdXNKM0pCMkp1RlBQTnRMWEZsK24vSFZRa1AveG9ScENo?=
 =?utf-8?B?cUJKNHBiMjJ4d2pXTzQrZyt5S1cyeTRBaE9CMnFtNVVBZi9reExmWXByTGxU?=
 =?utf-8?B?djFDR0Jtb095WGV1YXZNdWQxSWRkL2JVM3pUVjdtejAxU2hpV2t1ODVMQlZj?=
 =?utf-8?B?WlJmNjVOQUNxbmtMNG9TZitjNXljSjQ2ZHZjQmxDM3FEUUJmMkNrOW1KeW9y?=
 =?utf-8?B?ZHV3ZEQvWGJJQ0wwSlE4Zi9YaTVtbXhocDlremZnTWlSd2luakZ3Ym9Kc0tP?=
 =?utf-8?B?V0JRSnRGVnU1bWlaTVEzR1dpZmdXWkFzUmI1M0ZpV0FWVzk5a2dJSHNaZEh1?=
 =?utf-8?B?c3Roa0hoZ0RSdXJSRmppUVJ6N2U5TFZVVmJZdklLWU1IblJCWXhDNjRETzRv?=
 =?utf-8?B?QjBLU0JoRXdVRVRzNmFIdHl0V2txK3JvdnNGYmpna1hKNHNIVmQ2b1drRFd5?=
 =?utf-8?B?WGhMQ0JSSmZVQnIrYlk4NUZoK29MN3BpbmhEYmNzbklGSVFYcEdOMlU3eERm?=
 =?utf-8?B?THBXcjN1dER6ODM5QzVsRGU3dDVBSHp4TVY2ZkhKb0ljdEJnZlIvYXlvQXZK?=
 =?utf-8?B?K2VEVU5XKzJSSmlRL3BwUUN1Nml3T2FqSnUwVFZGbEZ1TnplOEtGb25Vbm5k?=
 =?utf-8?B?b3FHUnNsNmF3UUZ0c1ZRWVQ5aUcvckh3RFFqd25UanFBcVVIL01TYmpUWDFo?=
 =?utf-8?B?T1BoSWZXT0RPK2VtOTRFUEtlUTY5a0FXTUlEVDFrSGJWMkduUytETVVSZjAr?=
 =?utf-8?B?QVBuWFBYRWRzanZiMDd2OGxkZUNZcVV5cW5lb2pXRWJVV3B0ME1RQTc5MUlu?=
 =?utf-8?B?MmV4RkhuRkV0QmhvdXVuMEZ2bVgzZEd1WDIvN1h2MEVKSUF1YldXdWJMemE4?=
 =?utf-8?B?WC90cTE4blBNZkxhOTJkN1o0bEZTdmlKb0NCSVYvbm40SGVINzlEVnVnTmdv?=
 =?utf-8?B?d0w0SElZNVh3aUlXbDRZL0NGZ1NxRGdLYkFKbHcycXpWRXB3dk9Sdk5YMkNt?=
 =?utf-8?B?MzBiVnAwU1ZxR3pqTFF0cDJjZzNua0tmNG1UWlZzb2Fvb2FYZnZrZWl2R1pm?=
 =?utf-8?B?b29zRXdaeUZjdVQvUHB2NnJlWFdkazcyd05TTGxyM0tVYnMzZWowRGx0UHNs?=
 =?utf-8?B?Q3IxZ0V6cTgvZXZ5bXc4TDBvZlpGQ25tSHNNWkk2WVd1M0NYTDNOajlpT016?=
 =?utf-8?B?NVdQaDVXSmUycThEa2llVCsvS2E1d3hzZkUzYzMvMjlmK1pHdzFyL2FyaDNz?=
 =?utf-8?B?T1lUdEp6SWszRzMwL29rYXptUXNGVHl3WFU0OEk4T2RuVzRvUk1oUUNuSFd3?=
 =?utf-8?B?YVRkQXRXNzRZU1gwWW5nc250NEVsS3Jkd0dKeW5Xbm5ud1Q0b0w4ek85aU42?=
 =?utf-8?B?ZkxJcWUxSUlseFo0RENLUytKMmljNzNQWXpycEUyL2tTTHhQM3U3TEZqQlFF?=
 =?utf-8?B?aFhFbTdFWWFmcXdUdE1CajlsWFZ0ZmJRU3ZTUm5WTmFsdzY5K1grSElaZTV0?=
 =?utf-8?B?TXg1SFlBcXpWaFp2VTdycGt1ZGl6S2UxdzkzUWkzUHphaTN2c0JWaUdudHBa?=
 =?utf-8?B?REtmZ3dxaW1yT0Fybk9XcDdlcWtqb0RBeGF0a2tiU0kxeHhOcDNYdW9vTks2?=
 =?utf-8?B?RkxDZEd6a2xxbGlJaWNnNmRleVZhbDA5T0VndnhHMU0zakNwWEJoQUVPeUY5?=
 =?utf-8?B?RGVFRElTaVgzTC9uTDNXQ3hlSXR6WUJaUnJZcTFTVzA2REtEOW5pSi9sbmJY?=
 =?utf-8?B?Qnd6d2YzZzBkWUhybkRFZXlxSnFSNnkveHpNTHViU0FSVjBiUW1aclc3dEJF?=
 =?utf-8?B?NldqbkRraFVyZ2lKLzU1V0dKNWQ0d25nR0V4a0xFYkdtWC9TVVUvRXVGVVBB?=
 =?utf-8?B?VDNWc0gzUEdDTTBhM2p2NkdkQkcweVVkZHN1NytzRGtKd1B3ZDArSHdHNGRw?=
 =?utf-8?B?VjZwN01WQ0JsS1BoOTRRVXZBc0pqYVF0dDIwRUI3UmRpeFpXQWtUL1ZYZUJa?=
 =?utf-8?B?d2Vvd1pTZ2ZLQ2o1MFRNRXVMQXA5cEQwVXJEeWJiN0pTTEE1K2R5ZHhBdlhE?=
 =?utf-8?Q?ix4m0Ni/yX2p4d1h4mN9E5Q=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c06575e8-e67e-4a7d-5b02-08d9d11db605
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2022 14:06:19.2852
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OUZ/t43mHeaTI8Dneeb5MFZrZVDdOTsTYv+D2zUj7z1btbH0/3SFUx9m4kidTfTJkpNmdm2J0JVMg31GBKW1tA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5152
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/5/22 7:44 PM, Zeng Guang wrote:
> On 1/6/2022 3:13 AM, Tom Lendacky wrote:
>> On 12/31/21 8:28 AM, Zeng Guang wrote:

>> Won't this blow up on AMD since there is no corresponding SVM op?
>>
>> Thanks,
>> Tom
> Right, need check ops validness to avoid ruining AMD system. Same 
> consideration on ops "update_ipiv_pid_table" in patch8.

Not necessarily for patch8. That is "protected" by the 
kvm_check_request(KVM_REQ_PID_TABLE_UPDATE, vcpu) test, but it couldn't hurt.

Thanks,
Tom

> I will revise in next version. Thanks.
>>> +        } else
>>>                ret = 1;
>>>            break;
>>>