MIME-Version: 1.0
References: <20211223173015.22251-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20211223173015.22251-7-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <CAHp75VeCwR-eP930s3miv-ux8=_P+vmdkhN+K=weTL1nwNA1ig@mail.gmail.com>
 <CA+V-a8snJU6YYtfcN_mWCJGxYnbNGrLdU+Y5g06mjV4dhsABMw@mail.gmail.com>
 <CAHp75Vck43wj650k70MsUNvmb+_-PUCd5mSy=dvmuX7MaAwr2w@mail.gmail.com>
 <CA+V-a8uRqfs2h82_y6yk7MZnt8K5iKii5DZZpFgDDy0Hw2ieXA@mail.gmail.com> <CAHp75VdiTw7R=MSM=4nzn8m863tomSza+yxx7pXLU-Xj8aouOg@mail.gmail.com>
In-Reply-To: <CAHp75VdiTw7R=MSM=4nzn8m863tomSza+yxx7pXLU-Xj8aouOg@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 6 Jan 2022 16:14:27 +0200
Message-ID: <CAHp75VexoYCBBJ1BFgnsb38Q79jG6NB2xBBHmAafTK2FHkTsbQ@mail.gmail.com>
Subject: Re: [PATCH 06/13] media: davinci: vpif: Use platform_get_irq_optional()
 to get the interrupt
To:     "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Rob Herring <robh+dt@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 6, 2022 at 3:43 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Jan 5, 2022 at 7:41 PM Lad, Prabhakar
> <prabhakar.csengg@gmail.com> wrote:
> > On Wed, Jan 5, 2022 at 9:43 AM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Tue, Jan 4, 2022 at 7:23 PM Lad, Prabhakar
> > > <prabhakar.csengg@gmail.com> wrote:
> > > > On Sat, Dec 25, 2021 at 5:32 PM Andy Shevchenko
> > > > <andy.shevchenko@gmail.com> wrote:
> > > > > On Sat, Dec 25, 2021 at 3:04 AM Lad Prabhakar
> > > > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:

...

> > > > > > +       res_irq->flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
> > > > > > +       res_irq->start = irq;
> > > > > > +       res_irq->end = irq;
> > > > > > +       res_irq->name = dev_of_node(&pdev->dev) ? of_node_full_name(pdev->dev.of_node) : NULL;
> > > > >
> > > > > If you convert DEFINE_RES_NAMED() to return a compound literal, then
> > > > > you may use it here like
> > > > >
> > > > > res_irq = DEFINE_RES_NAMED(...);
> > > > >
> > > > > or even do like this
> > > > >
> > > > > if (dev_of_node(...))
> > > > >   res_irq = DEFINE_RES_IRQ_NAMED(...)
> > > > > else
> > > > >   res_irq = DEFINE_RES_IRQ(...);
> > > > > res_irq->flags |= irq_get_trigger_type(irq);
> > > > >
> > > > There are quite a few users of DEFINE_RES_IRQ_NAMED()/DEFINE_RES_IRQ()
> > > > changing this macos just for this single user tree wide doesn't make
> > > > sense. Let me know if you think otherwise.
> > >
> > > Converting them to produce compound literal is straightforward and
> > > does not require changes in the users. But on the other hand it allows
> > > you to use it and convert existing users to use that form directly.
> > > You may conduct research on how macros in the property.h were morphing
> > > towards that.
> > >
> > Thank you for the pointer. I did the below change for this.
> >
> > diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> > index 8359c50f9988..da1208e8f164 100644
> > --- a/include/linux/ioport.h
> > +++ b/include/linux/ioport.h
> > @@ -153,7 +153,7 @@ enum {
> >
> >  /* helpers to define resources */
> >  #define DEFINE_RES_NAMED(_start, _size, _name, _flags)                 \
> > -       {                                                               \
> > +       (struct resource) {                                     \
>
> Yep, that's it.
>
> >                 .start = (_start),                                      \
> >                 .end = (_start) + (_size) - 1,                          \
> >                 .name = (_name),                                        \
> >
> > But there are some instances which need to be touched, for example
> > vexpress-sysreg.c [1]. Are you OK with files to be changed?
>
> Nice! That's exactly my point and you can sell it to the community
> because there are already users of it like this.
>
> Yes, I'm fine, but it seems it needs to be done treewide in one patch.
> Btw, how many of those already in use?

Actually you don't need to change that. It's an array of resources and
everything should be kept as is there.

> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mfd/vexpress-sysreg.c?h=v5.16-rc8#n65


-- 
With Best Regards,
Andy Shevchenko