Date:   Thu, 6 Jan 2022 11:40:44 -0600
From:   Venu Busireddy <venu.busireddy@oracle.com>
To:     Brijesh Singh <brijesh.singh@amd.com>
Cc:     Dave Hansen <dave.hansen@intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 13/40] x86/kernel: Make the bss.decrypted section
 shared in RMP table
Message-ID: <YdcpnHrRoJJFWWel@dt>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-14-brijesh.singh@amd.com>
 <YdSKQKSTS83cRzGZ@dt>
 <18eadf9d-8e31-0945-ccf4-2cb72b8e0dd4@amd.com>
 <acba0832-9b11-c93d-7903-fff33f740605@intel.com>
 <444b6c78-c4d3-f49c-6579-bd28ae32ca3c@amd.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <444b6c78-c4d3-f49c-6579-bd28ae32ca3c@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?Bhl+NK8Z5WL+gD6oHaKc3GjNGtNMmsflIKnJdM5autv3SWo8LyqxhRlHrV?=
 =?iso-8859-1?Q?CQg29W/mJOJsOVLNRcX4Vyu28K0XLytg+EBIgNEno3QOdBnoepi8RVLK+O?=
 =?iso-8859-1?Q?0jkvhklp4fr2NWH5rpAExvzoVFJu2N+a1L2Q+xr3iapxyHsz3pZi2nsACA?=
 =?iso-8859-1?Q?hRY13Q6OoJUCkVHcdqtz3UavGDGKh6LzLVKIRcEOaunTwpsW5xZNjBab5e?=
 =?iso-8859-1?Q?1rs+wPVwya8TlWNELd6pSiv7emDOtVq9oA2OM3Ht3V+0XwNxtBFPELwAFt?=
 =?iso-8859-1?Q?i6bUJF2fzHHg4+ilfKo+sF5Bn9pmICMM1Pp3O6/ZznHrWqoOBizUclt0zC?=
 =?iso-8859-1?Q?qNg9WUhY5zkKKi41owIrcDDej2KeZTBQPJYiyzEjTIjOQRJVUGVLh6loN2?=
 =?iso-8859-1?Q?9AuYTU+UvYIKOjVmXvwM+MfPtkq0nyOZU415GKqdNJIoeEGKXwTnKIznXD?=
 =?iso-8859-1?Q?l8lo6dTrblE3u1u91fA+HtsFy2MMGviaFrrtDi8stHw88xYcjtztuOhY0M?=
 =?iso-8859-1?Q?ZVpxtA597oUjSKR5pTJ7l5X3ckBopcPK4SKiofDVcsBLG0Nmv3Rsw5ztQt?=
 =?iso-8859-1?Q?JJ+UfzlYa3AilSglojA/rEnod293ShfwqvQa0R444hqm6rBAZDmZNrXj8d?=
 =?iso-8859-1?Q?opiOTuooHro0yWDDc3bNOS7DLuQW1Qgzp2861zFKUUNLmGIiuR+NON0p0E?=
 =?iso-8859-1?Q?MEw6awcC7ZXg2xWLUCNjMk8iyUdeEhX0PU9xnNukAeNL4dF1XQI1WXbSdC?=
 =?iso-8859-1?Q?1pYJ9txX4ncH6M3Yfu8vW+dBCfXHFIoZlsUJ5AbXvKz7LDmeZ0RIFem7Lo?=
 =?iso-8859-1?Q?hM1nrCV9CjKt/3xRIqIYHy/b0DFdcNiqRKOY4wfGrOAjxtxV/6UP79mRC9?=
 =?iso-8859-1?Q?HrS0rJwNk/sWwoTXYFMKpCvSErNd6OBpRZFfzTxX/Kb8thxoTDCjjZE3Ft?=
 =?iso-8859-1?Q?v5DRosmoEtf9fB9fPi6aLiFa1xcXP8+X7QvSsdiH6UG4TxlXoj4zA1EQGq?=
 =?iso-8859-1?Q?wnX6lkfX4tr9jXqIb4ebEK61lyIx/4xjCZ0h4F0d7UvGyQ64DsP5hkC5Lh?=
 =?iso-8859-1?Q?o8O6aUHtKdFshFjpDUmXss6WUDbMTKmWwsJi4yDULVpmyeoOpl0temeD1/?=
 =?iso-8859-1?Q?oC7Vii5x+OpctFdjHaIcdvNowQHktYdOU3xbxFF43aR8m9Ig6af2V9qp1E?=
 =?iso-8859-1?Q?iBl5deAbg2qC6nMA/aPsmKvt2sFOTbJYfKXFplCtaqkHTcO4BNvuNha8Vy?=
 =?iso-8859-1?Q?NXen065/N2N/yGVkDlf1Y0J89M4I5uispsrsXlc0WNKDDIfdSvnbf6lSEQ?=
 =?iso-8859-1?Q?MvVKnED9T/16z0/W4laidGB+pel533IxMUE71q+Oqp2bIn7oRHXZkCjbq1?=
 =?iso-8859-1?Q?cslTgrDKJXMlIMgFYSlfglzaNwYTQMz6uQeef1fnhlMSpNovqhS8IQIdFI?=
 =?iso-8859-1?Q?hJrqJ+rSDTHlnGKg5626xlLYbougspkf2Fdrg9vSRwV7vLTP4BvlgCB5Z5?=
 =?iso-8859-1?Q?XsGSvFRLmEaHbN5nJrRxgRM5AEhrHp9Z/AvdNEavtlmSU38R/JhtPCvYEi?=
 =?iso-8859-1?Q?5XK1Hl+83jWCIK7FCMb+UJ6P1w8WF66WOi8J2yOnGUzzG7x252fuf7Nejv?=
 =?iso-8859-1?Q?PxXlYnvRiNNqJ2GAZh36e8v/5YZ7+bOVSlG3joIHF4jR9eoAU6jDSFfw8c?=
 =?iso-8859-1?Q?vNVezwOwl+LkV8oK6X/fxU4YPGUp7ilY5gBQU/b3u03l05cZFN/BhZM5eb?=
 =?iso-8859-1?Q?iQBQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55dab605-a150-48f2-6ee2-08d9d13bb1aa
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2576.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2022 17:40:56.6156
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cgXfmUHM/I9zqUx0vh3lrGWneCDEAkxkRMnouZgDYej5toEpL7mZ1yW/U3V6hMknzjpWvMXDJloZG/9wzrKs3Kyn20mJwnPf95fdtIEk4Kg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2511
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10219 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 mlxlogscore=999 adultscore=0 suspectscore=0 mlxscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201060118
X-Proofpoint-GUID: 2vHIz2MWJLiQLVuiFYopCTFUHc2gAcp8
X-Proofpoint-ORIG-GUID: 2vHIz2MWJLiQLVuiFYopCTFUHc2gAcp8
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-01-05 15:39:22 -0600, Brijesh Singh wrote:
> 
> 
> On 1/5/22 2:27 PM, Dave Hansen wrote:
> > On 1/5/22 11:52, Brijesh Singh wrote:
> > > > > ????????? for (; vaddr < vaddr_end; vaddr += PMD_SIZE) {
> > > > > +??????????? /*
> > > > > +???????????? * When SEV-SNP is active then transition the
> > > > > page to shared in the RMP
> > > > > +???????????? * table so that it is consistent with the page
> > > > > table attribute change.
> > > > > +???????????? */
> > > > > +??????????? early_snp_set_memory_shared(__pa(vaddr),
> > > > > __pa(vaddr), PTRS_PER_PMD);
> > > > 
> > > > Shouldn't the first argument be vaddr as below?
> > > 
> > > Nope, sme_postprocess_startup() is called while we are fixing the
> > > initial page table and running with identity mapping (so va == pa).
> > 
> > I'm not sure I've ever seen a line of code that wanted a comment so badly.
> 
> The early_snp_set_memory_shared() call the PVALIDATE instruction to clear
> the validated bit from the BSS region. The PVALIDATE instruction needs a
> virtual address, so we need to use the identity mapped virtual address so
> that PVALIDATE can clear the validated bit. I will add more comments to
> clarify it.

Looking forward to see your final comments explaining this. I can't
still follow why, when PVALIDATE needs the virtual address, we are doing
a __pa() on the vaddr.

Venu