Message-ID: <cf654da2-00b3-0c3c-57ad-bb669e60de92@intel.com>
Date:   Thu, 6 Jan 2022 09:46:35 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.4.0
Subject: Re: [PATCH 07/25] x86/sgx: Move PTE zap code to separate function
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     <dave.hansen@linux.intel.com>, <tglx@linutronix.de>,
        <bp@alien8.de>, <luto@kernel.org>, <mingo@redhat.com>,
        <linux-sgx@vger.kernel.org>, <x86@kernel.org>, <seanjc@google.com>,
        <kai.huang@intel.com>, <cathy.zhang@intel.com>,
        <cedric.xing@intel.com>, <haitao.huang@intel.com>,
        <mark.shanahan@intel.com>, <hpa@zytor.com>,
        <linux-kernel@vger.kernel.org>
References: <cover.1638381245.git.reinette.chatre@intel.com>
 <bd228c90c139437bb4fcc4b7b99063bfd3eb1439.1638381245.git.reinette.chatre@intel.com>
 <Yavy5JTYAkdZjnK2@iki.fi> <66151f3a-0e32-fc57-cb54-5b714588389b@intel.com>
 <917c53ff755d9a20e1f4bcb48c70add8364d1065.camel@kernel.org>
 <192e252a-653f-2221-73dd-99894c134a37@intel.com> <YcsleU6ExUbpN51r@iki.fi>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <YcsleU6ExUbpN51r@iki.fi>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHk1YldCWUNmREdMbFFLTHlPZFZzMkFEUmk1bEczYVhHdTNiR21zV2xiZ1JN?=
 =?utf-8?B?cHY3K1p3S0FiZ0V3dmFDb2xYVEo0blVFODl1SEl5bnhNM3BpcGd4WldUNjlG?=
 =?utf-8?B?RkwxbmhDZmcya2ZDaU5RTC84ZGUxTWVZenBJZGVDbUx0U2hQenY4ZlFlZXRv?=
 =?utf-8?B?U3d0UkpqMUEzNVE0UE95SDJ0djBrR0xQUTdLV1hpUXRVQkQ4T09CUjcxZjBP?=
 =?utf-8?B?dGM2SGxkRThMQmh3a3NUQmk2S1ZmU010YWNkZkRsS2x5UDdWVTdudlZNaFNF?=
 =?utf-8?B?ZllGa21lbW1YQjVIVHBmWkNZZTMvdXZ6Ym1qS2NDQURzS0ZqSlBveWkwOW1F?=
 =?utf-8?B?ZExDQURYV3NPOUUwL2Zzd3FKSlNsU2o5Y2FDc3VMaUM4bGhQVzg0NjVSRE9p?=
 =?utf-8?B?WHB6aEhjSnBUK203Uyt3aHhIQ0drS3RaMVV2eG5KbVViUE9kcTMveUZzQ2RD?=
 =?utf-8?B?WWwxMWk2MjdmeE41NnNrVi90Wkkvei91OHVDQTZhOWh0WjlNbDZVMlFva0x2?=
 =?utf-8?B?cGlkOTJLQVJyNW1sb2FETUJGS08vclFKU2N1c3AwZGYzYUt0WkNHZXEzTWVL?=
 =?utf-8?B?SHFtSjUvNkgwQ1lHLy9LdG5EM2FCb2pjMk82NXRWMHNrYUlIUkQ5ajZpUEtN?=
 =?utf-8?B?RVVuSWZSZktrRnh2UngzYTlFeVQzSW10bzQvSkwwM292S0srSDZjWHhudWZw?=
 =?utf-8?B?NUpRdkpSN08zdDJ4NndYU1RSMUdGSGNkQWZIOU12VUZBTnRYVkp5SFQxL2Fy?=
 =?utf-8?B?ekFaenRYaExYQVB1VEp6eGJrcjlDZWhBZWQ3RnhFUjFabHJ0cGZvZ3FuV1Fq?=
 =?utf-8?B?bTlMVWxaa2FyNHZockxhbFVta2JJUmFxaUJlM2YyQ2pCMEg2dTFiaG0rd0N6?=
 =?utf-8?B?RWJrRTlGRHM3WGJINDZIeUtMWW5FekRrVDRrV3E2NURGNFhjdUJic1M2Sk85?=
 =?utf-8?B?dUlkVFhwZDE5TnFPNmlRZlVIeWoraDEwWERVeDRXOVNieFF3NkkrNG1RSEVm?=
 =?utf-8?B?RUs0cTFveW03SG5SeGFuOHB0anVsY243YVN3MTVVUm9CcXR3QUNPYkVKcFc4?=
 =?utf-8?B?MzR5cWlOejViY2J4MEV0NVVtdjBWRlhlZEtNcjZSYXNnZldzcHM4ZFBqMS8v?=
 =?utf-8?B?SkNrSTRMWW5NWVBZMlA1dHU0MnRYb1BLS2hMVlpBZlViZm9NMmJacEpOMFZ5?=
 =?utf-8?B?YWoyOXZ0cEdSSEpQQ3FpT0w0WU4wQ1lraXNDSkgvU3VQbng5dGdkaEtaeGFJ?=
 =?utf-8?B?c2c0ODBlYkIzVTJRdzRMSGZhWm4weWJ0aFZlQ0hZdHJaczBZKzRTa1h3b0E3?=
 =?utf-8?B?QmVsbU5wZHk0OStaMXJkbHlxZHI2MFNxWHd2WGpac1M5dTd1QjgwTWF3Z2JP?=
 =?utf-8?B?SGJzVXZaTWxDb3pBWlNWblV6ZS9uNFRuUGlYbjZYZG1hMDYrTFNyUnlXeVM4?=
 =?utf-8?B?S1pkVmF4Yjd3VGI3UHlLU0plU3RzTW1TSDI1OVBleVU1M3NDU2xFK0NIS0E3?=
 =?utf-8?B?cmErc2k3SFZBZGZHRk4zVmI5VS9tNHBjeUpGbmZrazljeHJpSkJGQWdqeXZi?=
 =?utf-8?B?YTNBZVBBdFpBbTNIcXcyZUtsOU9NMUI3dkRxTnFEZEc2clNsVUs5QXV5WTEy?=
 =?utf-8?B?M0RYMDUxWmUrZkphTEl4bXNwNzF2ejRxVFl3QUVPc1dzT1FNV1c5L2JSSDZX?=
 =?utf-8?B?MzgydVJrSU9OOVVYVHhBc0tHdkRnMlExRU9PK2tvNENieGtNc3l3TlZtdXRs?=
 =?utf-8?B?bE8zdWpUTXgvc1pXTHNnZVBqdW85TFJaajNFSW9XYko0eVBlY1ZVNHJyTUx6?=
 =?utf-8?B?cFBrN0RzUHR1aXhNY3FLMzM3R25YQXdYR2ppNnNEbVBzeUx1cUxpZ3lyRTNm?=
 =?utf-8?B?NEhVTCswT1V3SG8yNzhWSzZUekEyM1hkY1hXc2FINkoxMDVyd3RITXcwK2J0?=
 =?utf-8?B?ZU5Ed3ZiK1cxQ3Y1TUdLYWpucWc2U25RMkFudDRTSEpCUGdqRUgzT0IrdTll?=
 =?utf-8?B?bEZpY3d2RnBZeGZ2aEowWjlJWlhwMTFHTWJOSlM2MGhzNHhoUTF4clhjR2tq?=
 =?utf-8?B?aTZZQUpHZHoxa08zZ0daeEVaOHdLM3FyL1d4YnVNWE5KejVvVXZOUnFDTG0r?=
 =?utf-8?B?QlZQV0hwWkNmVlhqN1VDN3V0UURDK3ArNnVWT2U3ZGxwVFE1VmxIL3JNOFBO?=
 =?utf-8?B?NzZWL2RzaFE0QlRHK3ZXWlpBM3hlaS9UZWd0TmFvZkxBUUxjSTNpVXNNelRS?=
 =?utf-8?B?ZDNlYlJSUzZoRS8xbDV2blo3MFZBPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 109e0499-658f-4e1c-dff5-08d9d13c7e39
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2022 17:46:39.8742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8GI90sjdxglNDwfbZQ63Uq7N3lhvGqEdA7SEjK3fv6JeyfHHwqLK+GjctuyUQAYtf2mgWAPvPU04lfi/pNyUWz7JKoGUl206kEp1PGdX5Uo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2178
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 12/28/2021 6:55 AM, Jarkko Sakkinen wrote:
> On Mon, Dec 13, 2021 at 02:11:26PM -0800, Reinette Chatre wrote:
>> Hi Jarkko,
>>
>> On 12/10/2021 11:52 PM, Jarkko Sakkinen wrote:
>>> On Mon, 2021-12-06 at 13:30 -0800, Reinette Chatre wrote:
>>>> Hi Jarkko,
>>>>
>>>> On 12/4/2021 2:59 PM, Jarkko Sakkinen wrote:
>>>>> On Wed, Dec 01, 2021 at 11:23:05AM -0800, Reinette Chatre wrote:
>>>>>> The SGX reclaimer removes page table entries pointing to pages that are
>>>>>> moved to swap. SGX2 enables changes to pages belonging to an initialized
>>>>>> enclave, for example changing page permissions. Supporting SGX2 requires
>>>>>> this ability to remove page table entries that is available in the
>>>>>> SGX reclaimer code.
>>>>>
>>>>> Missing: why SGX2 requirest this?
>>>>
>>>> The above paragraph states that SGX2 needs to remove page table entries
>>>> because it modifies page permissions. Could you please elaborate what is
>>>> missing?
>>>
>>> It does not say why SGX2 requires an ability to remove page table entries.
>>
>> Are you saying that modification of EPCM page permissions is not a reason to
>> remove page table entries pointing to those pages?
> 
> So you have:
> 
> "Supporting SGX2 requires this ability to remove page table entries that is
> available in the SGX reclaimer code"
> 
> Just write down where you need this ability (briefly).

Will do. I will expand the current permission changing text and also add the need
for this ability when regular pages are changed to TCS pages. TCS pages may not
be accessed by enclave code so when a regular page becomes a TCS page any page
table entries pointing to it should be removed.

Reinette