MIME-Version: 1.0
References: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> <20211231161930.256733-4-krzysztof.kozlowski@canonical.com>
In-Reply-To: <20211231161930.256733-4-krzysztof.kozlowski@canonical.com>
From:   Alim Akhtar <alim.akhtar@gmail.com>
Date:   Thu, 6 Jan 2022 23:50:56 +0530
Message-ID: <CAGOxZ51OdwYFpzz1JaqHRUi3ruwqgEkLiQCCz+Yg9ROCHSQBeQ@mail.gmail.com>
Subject: Re: [PATCH 03/24] ARM: dts: exynos: drop unused pinctrl defines in Exynos3250
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Tomasz Figa <tomasz.figa@gmail.com>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Sylwester Nawrocki <snawrocki@kernel.org>,
        Sam Protsenko <semen.protsenko@linaro.org>,
        Chanho Park <chanho61.park@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello Krzysztof

On Sat, Jan 1, 2022 at 10:42 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The PIN_OUT/PIN_OUT_SET/PIN_CFG defines for pin controller pin
> configuration are not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
Thanks!
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 25 -----------------------
>  1 file changed, 25 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250-pinctrl.dtsi b/arch/arm/boot/dts/exynos3250-pinctrl.dtsi
> index dff3c6e3aa1f..a616cb1aca29 100644
> --- a/arch/arm/boot/dts/exynos3250-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos3250-pinctrl.dtsi
> @@ -19,31 +19,6 @@ _pin {                                                               \
>                 samsung,pin-drv = <EXYNOS4_PIN_DRV_ ##_drv>;            \
>         }
>
> -#define PIN_OUT(_pin, _drv)                                            \
> -       _pin {                                                          \
> -               samsung,pins = #_pin;                                   \
> -               samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;        \
> -               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;               \
> -               samsung,pin-drv = <EXYNOS4_PIN_DRV_ ##_drv>;            \
> -       }
> -
> -#define PIN_OUT_SET(_pin, _val, _drv)                                  \
> -       _pin {                                                          \
> -               samsung,pins = #_pin;                                   \
> -               samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;        \
> -               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;               \
> -               samsung,pin-drv = <EXYNOS4_PIN_DRV_ ##_drv>;            \
> -               samsung,pin-val = <_val>;                               \
> -       }
> -
> -#define PIN_CFG(_pin, _sel, _pull, _drv)                               \
> -       _pin {                                                          \
> -               samsung,pins = #_pin;                                   \
> -               samsung,pin-function = <_sel>;                          \
> -               samsung,pin-pud = <EXYNOS_PIN_PULL_ ##_pull>;           \
> -               samsung,pin-drv = <EXYNOS4_PIN_DRV_ ##_drv>;            \
> -       }
> -
>  #define PIN_SLP(_pin, _mode, _pull)                                    \
>         _pin {                                                          \
>                 samsung,pins = #_pin;                                   \
> --
> 2.32.0
>


-- 
Regards,
Alim