MIME-Version: 1.0
References: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> <20211231161930.256733-6-krzysztof.kozlowski@canonical.com>
In-Reply-To: <20211231161930.256733-6-krzysztof.kozlowski@canonical.com>
From:   Alim Akhtar <alim.akhtar@gmail.com>
Date:   Fri, 7 Jan 2022 00:12:22 +0530
Message-ID: <CAGOxZ52LR5vA-taBHhwBXaXYciKoOVN3MaWcB3_RsNcFcnO+6w@mail.gmail.com>
Subject: Re: [PATCH 05/24] ARM: dts: exynos: override pins by label in Peach Pit
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Tomasz Figa <tomasz.figa@gmail.com>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Sylwester Nawrocki <snawrocki@kernel.org>,
        Sam Protsenko <semen.protsenko@linaro.org>,
        Chanho Park <chanho61.park@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Krzysztof

On Sat, Jan 1, 2022 at 11:15 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Using node paths to extend or override a device tree node is error
> prone.  If there was a typo error, a new node will be created instead of
> extending the existing node.  This will lead to run-time errors that
> could be hard to detect.
>
> A mistyped label on the other hand, will cause a dtc compile error
> (during build time).
>
While it makes sense to do this, was wondering if you faced any issue
with the current implementation?

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
Feel free to add
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/exynos5420-peach-pit.dts | 44 +++++++++++-----------
>  1 file changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index e76fb104db19..1ae5528e9ebf 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -868,27 +868,26 @@ pmic_dvs_1: pmic-dvs-1 {
>         };
>  };
>
> -&pinctrl_1 {
> -       /* Adjust WiFi drive strengths lower for EMI */
> -       sd1_clk: sd1-clk {
> -               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> -       };
> +/* pinctrl_1 */
> +/* Adjust WiFi drive strengths lower for EMI */
> +&sd1_bus1 {
> +       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> +};
>
> -       sd1_cmd: sd1-cmd {
> -               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> -       };
> +&sd1_bus4 {
> +       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> +};
>
> -       sd1_bus1: sd1-bus-width1 {
> -               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> -       };
> +&sd1_bus8 {
> +       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> +};
>
> -       sd1_bus4: sd1-bus-width4 {
> -               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> -       };
> +&sd1_clk {
> +       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> +};
>
> -       sd1_bus8: sd1-bus-width8 {
> -               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> -       };
> +&sd1_cmd {
> +       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
>  };
>
>  &pinctrl_2 {
> @@ -907,12 +906,13 @@ pmic_dvs_3: pmic-dvs-3 {
>         };
>  };
>
> -&pinctrl_3 {
> -       /* Drive SPI lines at x2 for better integrity */
> -       spi2-bus {
> -               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> -       };
> +/* pinctrl_3*/
> +/* Drive SPI lines at x2 for better integrity */
> +&spi2_bus {
> +       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> +};
>
> +&pinctrl_3 {
>         /* Drive SPI chip select at x2 for better integrity */
>         ec_spi_cs: ec-spi-cs {
>                 samsung,pins = "gpb1-2";
> --
> 2.32.0
>


-- 
Regards,
Alim