Date:   Thu, 6 Jan 2022 20:05:15 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Fabio Estevam <festevam@gmail.com>
Cc:     Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] regmap: debugfs: Free debugfs_name buffer after usage
Message-ID: <YddLe8cCvj5fVBTQ@sirena.org.uk>
References: <20220106175019.3116389-1-festevam@gmail.com>
 <Ydc2EHf5f12w4YcW@sirena.org.uk>
 <CAOMZO5Czbr=vuvZdqc6+odAQv0M-LJEQVz6uke8OXnoG6wLqwA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="RVSDFDYmBYl7Sb1s"
Content-Disposition: inline
In-Reply-To: <CAOMZO5Czbr=vuvZdqc6+odAQv0M-LJEQVz6uke8OXnoG6wLqwA@mail.gmail.com>
Precedence: bulk


--RVSDFDYmBYl7Sb1s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 06, 2022 at 04:27:32PM -0300, Fabio Estevam wrote:
> On Thu, Jan 6, 2022 at 3:33 PM Mark Brown <broonie@kernel.org> wrote:

> > OK, but what's the logic here?  The name is getting thrown away here but

> I did more debugging and this is what I found:
> The 'debugfs: Directory 'dummy-iomuxc-gpr@20e0000' with parent
> 'regmap' already present!' message
> happens since commit cffa4b2122f5 ("regmap: debugfs: Fix a memory leak
> when calling regmap_attach_dev").

Sure, but that just means that the bug with not cleaning up the
directory predates that. =20

> # mount -t debugfs none /sys/kernel/debug/
> # cat /sys/kernel/debug/regmap/dummy-iomuxc-gpr@20e0000/registers
> 00: 00000000
> 04: 48611005

What happens if the underlying regmap gets freed for some reason?  It
now only remembers the new name, not this old one, so it'll only know to
clean up the old name.

> As shown above, I don't see the '
> /sys/kernel/debug/regmap/20e0000.pinctrl-gpr' directory being created,
> so there is nothing to clean.

Creating that file is the behaviour you are demanding...

> Where exactly would you like me to call regmap_debugfs_exit()?

Before we try to reinitialise debugfs for the new name seems like the
obvious place.

--RVSDFDYmBYl7Sb1s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmHXS3oACgkQJNaLcl1U
h9ATYwf8Db5lDzaIwmKNmkTn+zVQcLSBvpx1f2AJ42sMfHLnFshQ2kx+faUvMERf
NxQOFW00YOzpwh38myBV9ljQKTyzHQGuO4c5d5EuUIJePwZmMlXuMUofsbvRCU6+
9LsmtEVpAfXt0PR1UYLe72DucQz+k0iA6Amo856z0qCiFJOELosNZN5oqEFnQ6q0
7IBEKleQNka/Ke8orAA224i5RCuE5NHJ/WuWSzyo9fJu+Nsp+wLFuKnCQAGo802Z
i94dnkNj0FgUCtJWHgS0Mtk7JTy38rbGwgGTelwGdX74XDi81QwUUHTfs2oYvWbY
k1DbV0ECg4D+K2cwEu69D6mHqYswxw==
=FmYQ
-----END PGP SIGNATURE-----

--RVSDFDYmBYl7Sb1s--