Message-ID: <4cda2676-eee2-bc41-5030-14d05c6e8224@intel.com>
Date:   Thu, 6 Jan 2022 16:18:06 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: linux-next: manual merge of the dmaengine tree with the
 dmaengine-fixes tree
Content-Language: en-US
To:     Vinod Koul <vkoul@kernel.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>
References: <20211214172437.1552740-1-broonie@kernel.org>
 <CAMuHMdUQjKOp6B7_-pG8t8OzrH=H+dYjn65YMHHy7CLaw6OU1g@mail.gmail.com>
 <36975790-c9f8-a6f6-cbc2-493da4bdd8c1@intel.com>
 <20220105100407.69b16fe2@canb.auug.org.au> <YdVGmkzgUmvPDmlE@matsya>
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <YdVGmkzgUmvPDmlE@matsya>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/5/2022 12:19 AM, Vinod Koul wrote:
> On 05-01-22, 10:04, Stephen Rothwell wrote:
>> Hi Dave,
>>
>> On Tue, 4 Jan 2022 14:41:00 -0700 Dave Jiang <dave.jiang@intel.com> wrote:
>>>>>    +       */
>>>>>    +      list_for_each_entry_safe(d, t, &flist, list) {
>>>>>    +              list_del_init(&d->list);
>>>>> -               complete_desc(d, IDXD_COMPLETE_NORMAL);
>>>>> ++              idxd_dma_complete_txd(d, IDXD_COMPLETE_NORMAL, false);
>>>> Is "false" correct here?
>>> Hi Geert, took a closer look today. I believe it should be 'true'
>>> here since this is a normal completion that needs to release the
>>> descriptors. Sorry about the previous incorrect response.
>> I have updated my resolution from today.  Thanks for the feedback.
> I have merged fixes into next as well, so this should not be required
> tomorrow.
>
> Dave pls test..
Tested. Looks good. Thanks.