Message-ID: <b46ca792-d83d-9d07-3a31-876be74c76c4@intel.com>
Date:   Thu, 6 Jan 2022 15:54:17 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.4.0
Subject: Re: [PATCH v2 5/5] selftests/resctrl: Return KSFT_SKIP(4) if
 resctrlfile system is not supported or resctrl is not run as root
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20211213100154.180599-1-tan.shaopeng@jp.fujitsu.com>
 <20211213100154.180599-6-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20211213100154.180599-6-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zm5mdEhadGNVcldtQkJ3VWpXSSs5dlJRRC9DSnV4UFNpUHIyNFFZWGVzUlNw?=
 =?utf-8?B?SnJFaTgyMmozNDdtd1VFUWI5Rnd6VGsyOUlmM2RkQ3dpaGdnZ2pFMExlK05C?=
 =?utf-8?B?Y3dQclpTNmY4VEFSYS9qK1M2VFpnNUlpSTFEVlhSZzR1SXN0dnYxSU8yVG92?=
 =?utf-8?B?akxxMWlsTVorM0poWVExTThrTStwU0RwZmV3ZXdYVUNINnE5TlRPSTkxZmtI?=
 =?utf-8?B?VmxyWGVJK3FhZmM0YzF0dFloUkJQSnY3SUNROGhEZTVDdDFIbTRHbkxjaXZI?=
 =?utf-8?B?RnduU29Rb0ZMOU1Hb0w0RnBUZmkxYWpZSjg1ZWFha0RGQ3B4NUdhN3Q3Zzlo?=
 =?utf-8?B?eEgzYnJmMnU1eDFWZmVGNXRldzdDYko1VENSMlN4QklEVmh4WTJpb1VLTEdi?=
 =?utf-8?B?TWxwNms5SUY0SlpoVkZPbVlmVHIxWFVHcjdOcUFrZiszcHBjUXNIYUtGNjVk?=
 =?utf-8?B?TEh4citzM0doU1gwNmw4bHBVSTdpczVWQW1OWUU5UjY2SE5aMURDaXBDTmZX?=
 =?utf-8?B?WE8wV0xBUlVGckNvRWdUUUdLS3JYS0xFeXNpc2tGYWJVRm5TclhOSzhlSWRT?=
 =?utf-8?B?YWE1Y3FQa0djdVVMdjQ0Q2VWSGc2enIrQ3JoWXY0RmFCUUlmKzY5M3Evaitu?=
 =?utf-8?B?WDM1OStyekhpWmJNK1gzdHREckJWbTNRUkF1V2xGNGcvMWoyQW05ODNvWnZJ?=
 =?utf-8?B?RThmZk95OG1SYXhINGovUEZCemRlWTdPVlZkNXhuMjJ5V0pxSTlSZ2dIOFVa?=
 =?utf-8?B?eUZEVnlnYkl6K1FxVGlhSkpuL285LzZVVStJQUg3S2JUVDlXaEhEOHM0UGlM?=
 =?utf-8?B?alpiVkdqejFPTll5UDI2dlNBVzhLWFpCb0VieExxWEYvdDlDemgrbUpCcmN0?=
 =?utf-8?B?N1dDWk16RXpwazhXN1RhR2FWckFqdFVoV3EyTkZENXNsVlpZSWFxMndjZ3JL?=
 =?utf-8?B?blRhZ2cyaG5rcks1dEpHTXNzNWNrbHJDeVpRUnYwdENlYVRBTVRaNi9weTg3?=
 =?utf-8?B?VVRTeU1xR2Nka0NKUlNaV2RhQ1B1aE14RkV1UFVBRWxLN3dBUnp0MFB5TTdK?=
 =?utf-8?B?ZFFmUXMyWWQvcXBuZTJVZWpRM1NMYU15TkY5S0tDY1QyMHdEckJQNEJCdGNL?=
 =?utf-8?B?Ykl5M3ZBNFZNb0NmUU5uZHJtc1FBY3dTTHBncFhqb3g1Q0c5TG5nbVE5Q3JC?=
 =?utf-8?B?UzhIUXBWSGFnZzJ3eTZqK2hlM3JsS1ZSRUxQeUhjd1BJcU1kcWtqTmJ5RXk5?=
 =?utf-8?B?MXNDS2xsck9lL2U0NmVGb005d1ZZOGZuOTBDa2RNZlRnbEozaklzczJRTjdi?=
 =?utf-8?B?L0EzbTdtamFsbXJnYXBXZDIzTG91ZDFQTW5FNmxKa0J5bzMrcTVseTFpV0Q2?=
 =?utf-8?B?bC9wYUFsZmN4NjNLYURBa1NKTU14TzJrQ2MxREkvM0xseERMeDJFYTRUWjNk?=
 =?utf-8?B?a2g3UlBSckE1akRBUW1idEtRTVE1M3VOZnBQbnRiK0ZnVmZuZU5TNXdWaWt1?=
 =?utf-8?B?b0Yra0hjYUNFRThta3lIeUZmNUFOUGtJalVtN0xLWlpsZ0dqcVY1WjdVUDNG?=
 =?utf-8?B?NDVqclBmZ2gzVFlTelN0TEJhTjlZb2E3dmdmd0FSaThKRFdCdzdDNmtZQXc1?=
 =?utf-8?B?V1BSaW5QSCsvN29CMHlRRHVFUU5WbSthOUZEREE4bnFIdlRoNGlnWTVqZk5I?=
 =?utf-8?B?ejN2QjRSY0ZnMWo5Z2xZajk5MjY0WStHOUNkN3RBTEVYeVJUK0dMaEVkdGVG?=
 =?utf-8?B?c2pEZ2pndEY0QVZnZW1Nd2ltZ1RJMklqY3NCMHlaNHZYTmJqYnBKSzdCY3RB?=
 =?utf-8?B?UlVKRWFuMWFSN044M3BzYzdIYnJQb3JxbmMrWFdINnZwbmNQa2k0THVDZW1v?=
 =?utf-8?B?QjhwNUR1V0VjK0JJTXZIdjR4TFdtbCtWUXpJMm5Ubkp4ZjZ2RGZJNmtlMTRp?=
 =?utf-8?B?OFo4ei80cHRBMDczazhneGpwcTFWVEs3YW5wQjZjMEI1ZktGempmSG1YNHdj?=
 =?utf-8?B?TGgyWHZCYytLa0plNWpsTlBoQlhjc2JPd3d3SlNpRDA5Y1RjUEN5TDl6b25D?=
 =?utf-8?B?L2pGSStoQnl5M2tsak13WkdDV0xPcktOQmhSY1QrVlVNV0F4NVdQbDU0d0Zj?=
 =?utf-8?B?WHN3b2lJaGp6MTZ0VWZjaUUxWTZpNEwxZVBacUlxTDF3OVFZdFVBVFMwVmpi?=
 =?utf-8?B?Ni9wd1BIeWN1S01ocG1WVEJxSkdndy8xQ2c2L2VEMUVlaVprUEI3QjRQd1lU?=
 =?utf-8?Q?BYg14tgb9kY6kk/NbLy+A8Y5ibc/iBp5/gZAcjff7w=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9053b334-b835-482d-e3f5-08d9d16fdbf5
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2022 23:54:21.4816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /1kRANZttq92T3dIBbduy4wjQ9bja0zf/+5JVU1ZSODU38+oovyb/Bk+yIjviLETGc8UCKaKMFc6ihupdt01FE+XsTgZkJxIqOScYOzkumU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2675
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan,

Subject line still with typo. Also, what does "resctrl is not run as root"
mean? Do you mean "resctrl_tests"? The subject line can be made more succinct
while the details are moved to the commit message.

On 12/13/2021 2:01 AM, Shaopeng Tan wrote:
> To unify the return code of resctrl_tests with the return code of
> selftest set, return KSFT_SKIP (4) if resctrl file system is not
> supported or resctrl is not run as root.

Please review the feedback I provided to your first version. I do not
see the explanation of how changing ksft_exit_fail_msg() to 
ksft_exit_skip() accomplishes the goal of unifying the return code.
It surely is not a good use of my time to review patches and have the
feedback ignored.

> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index 973f09a66e1e..3be0895c492b 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -205,7 +205,7 @@ int main(int argc, char **argv)
>  	 * 2. We execute perf commands
>  	 */
>  	if (geteuid() != 0)
> -		return ksft_exit_fail_msg("Not running as root, abort testing.\n");
> +		return ksft_exit_skip("Not running as root, abort testing.\n");
>  
>  	/* Detect AMD vendor */
>  	detect_amd();
> @@ -235,7 +235,7 @@ int main(int argc, char **argv)
>  	sprintf(bm_type, "fill_buf");
>  
>  	if (!check_resctrlfs_support())
> -		return ksft_exit_fail_msg("resctrl FS does not exist\n");
> +		return ksft_exit_skip("resctrl FS does not exist\n");
>  
>  	filter_dmesg();
>  

Reinette