Date:   Fri, 7 Jan 2022 04:15:45 +0200
From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     Ido Schimmel <idosch@idosch.org>
Cc:     netdev@vger.kernel.org, stephen@networkplumber.org, andrew@lunn.ch,
        Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/6] net: marvell: prestera: Add router
 interface ABI
Message-ID: <YdeiUcL476kdanpP@yorlov.ow.s>
References: <20211227215233.31220-1-yevhen.orlov@plvision.eu>
 <20211227215233.31220-3-yevhen.orlov@plvision.eu>
 <Yc230kOuj+tHOkjQ@shredder>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yc230kOuj+tHOkjQ@shredder>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WGjltiKtfs6PHLFYo7oaxRLLQXGz9zWQSdeUJE2wUAB1bR4wPhgKgnwzrZpI?=
 =?us-ascii?Q?zZBqksrAyG0BnLOnlpIjn6IvfAXz5d8KW1FUIn9dMCmzPBLgrksCbDBikbHY?=
 =?us-ascii?Q?rceuHaQv2Uf1My+zVmm9rvQbFC2DVaQ1vn16J1lHeXCMAAOpxStLbQ50CBDT?=
 =?us-ascii?Q?+qZKb9Q66l3/m07ZNSB1C1D2ow4zhlm7DCxFg6jyXjdfhdulx4o57O0D2uoM?=
 =?us-ascii?Q?n+2Ceu+bZ3tpDO6lNmunAT+MBBN/5dOrozDpg9k+8J8Es8/rzt/muYBghQBR?=
 =?us-ascii?Q?zd8wvCfGOSNQlgWO0vypb+qAR1IqDIvToYbUOCLvnyTL7OH280NpNyV81FNa?=
 =?us-ascii?Q?UrCgeFGPpbqST76O792h/bNoLe/0F75tUnxGNnlVUFCRlRXqBDoSyQKfW7VA?=
 =?us-ascii?Q?8o/9exI5EP5ky79hAS81Iu6eTvQjWae1SwtVo3tq1j9PGLaoRZ1zjT03yris?=
 =?us-ascii?Q?lKwalTIRmRVy6Izpl0UaJbdhGNtZFbQRvy3P1pewrAuvBI2F1jx+//AwR/jt?=
 =?us-ascii?Q?Pgvc5jktqXH+VHAMx+Q8x8u6bFoqrvzuEkY2VfUn4hNzmCp/eJNjeTxdDct8?=
 =?us-ascii?Q?bPn5a+pRwF2ys+qgTKkM6Hp8A+hFfgDwJgf2xsOTcpTfqBT2rveJIvb7ZRUi?=
 =?us-ascii?Q?w3njBwHIegLXJHxBrYuY/y6ivClyXTGf0hy/xKv8zWrjtHiHMvnwClnAXbWx?=
 =?us-ascii?Q?83OkuwLo6Tctnn8s6Qxoe0VPHXDYCbjRQ6WKo+HMS/+SGTgsWqHNewhubcQE?=
 =?us-ascii?Q?CJscuZ8W1DX0ZVBdtFG4zkKXIPWyDq/awkGACz0KBlBZdoeBJZhEH35mEEH3?=
 =?us-ascii?Q?ZEFV+gAPuao4TvyPJwKk7Ah+bYNdJo1P8M+IxBt3OKTXJXS1YX8RJuzoBZWz?=
 =?us-ascii?Q?sypGMdpN/yF1Nb/578xFUim6ZINko064Gr0qySaWGD3RuDEvrOYP7zrJqTlm?=
 =?us-ascii?Q?HXA+ZoNyxtnSXJtbVUqvXCuy/7OeSAeiWxmL01xI/01cYsFATgzwI/v+Vhvr?=
 =?us-ascii?Q?T+Y35lGx6+v9Tk0Nyzizc2G0MK7zgL85gVO0gjS960SGeLVzJNpY5WRQ1+Cx?=
 =?us-ascii?Q?LzVFIOBm1VmfXP+96F4B6CMR0uxbI8GDZKVpgqHZrn0ComuPG4vqOglNYPPY?=
 =?us-ascii?Q?ajc4wPRIdzjX9KEgIatE9As/JXJaHy1DrHTwbbMasvGAbDnuCiCcl+vSukl+?=
 =?us-ascii?Q?+85516lmEiR6HP7ocfbkESNlvJagX4jgLkP36EfHGdvF0Wj2dMQ0D5migdcF?=
 =?us-ascii?Q?p3b/C4uo05T8vn6vBw08zxBO2uZabArugfMqnr6sK/8cgxTUaqEMW6gS09CZ?=
 =?us-ascii?Q?opkU2uqCZikCSxhwdJTDJdmncahIX+ol0UfZIIbF5i0pqwyaLwZRMSakRJug?=
 =?us-ascii?Q?x7nqgvsZd122ibMqza6jpY1rlJaMIicWqOxrBEQ8K95lY4/jNIvEVdyv5m04?=
 =?us-ascii?Q?XYX+MLSqLNOXWU9AKcOviLGfOVxNdHWX26JEfHC6uqq0WnnVB2OU9XDcHjvg?=
 =?us-ascii?Q?ahaQYjdi+g5Qh0PLOL7PD7AuWTPNPtRgRVS1ehbYQgEtHrIICgeXGxKNjWZh?=
 =?us-ascii?Q?AkQdbVn6aZITbgMIl6Ha9tTLwRU7IGsCofVN1C01KQjQyXHj+M77Vp1rME6b?=
 =?us-ascii?Q?TW9fTsZNsH2hNBtrh0Cl0aWqF5Z0rimv4n/llVBoxPu4rMampeVBeApPIClZ?=
 =?us-ascii?Q?I2QMRA=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 373fcd3d-efbd-49af-ab68-08d9d1839f39
X-MS-Exchange-CrossTenant-AuthSource: PA4P190MB1136.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2022 02:15:49.6444
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xMTfW6at9PbKYSqQ+xYL+iMUXSTIaE99oiOu/Q67x8XiT/eHDNY1sGkKOIqaqJVsreuLAhi3sZtWHxECRWj4q78t58+SiTfEWMIC05M1dE4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4P190MB1117
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 30, 2021 at 03:44:50PM +0200, Ido Schimmel wrote:
> On Mon, Dec 27, 2021 at 11:52:27PM +0200, Yevhen Orlov wrote:
> > Add functions to enable routing on port, which is not in vlan.
> > Also we can enable routing on vlan.
>
> I don't understand these two lines. Can you explain for which netdev
> types you can create a router interface?
>

Sure.
For now we support only regular port (has no upper or lower dev).

But ABI potentially support RIF on bridge/vlan (see prestera_if_type).
This feature will be implemented soon.