From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     netdev@vger.kernel.org, stephen@networkplumber.org, andrew@lunn.ch,
        idosch@idosch.org
Cc:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Yevhen Orlov <yevhen.orlov@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH net-next v3 6/6] net: marvell: prestera: Implement initial inetaddr notifiers
Date:   Fri,  7 Jan 2022 05:01:36 +0200
Message-Id: <20220107030139.8486-7-yevhen.orlov@plvision.eu>
In-Reply-To: <20220107030139.8486-1-yevhen.orlov@plvision.eu>
References: <20220107030139.8486-1-yevhen.orlov@plvision.eu>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HPAA6j786I2GFmhBR9khQ9jWl0oZh3/FrH0fpPxzIk9ocXhLVZ64qJTfVBgL?=
 =?us-ascii?Q?gnEE2w6ZHGvjkF9+0PWvaHh6ycOhDCVTbEhR/ThhoZrwF/NhAtG3hNl7a5Ri?=
 =?us-ascii?Q?oCyeVw9ZrmU83yBhnLatM0d1sW0OSm+dySseMMnoyY0iQBWXSRLyZ6mMbNRl?=
 =?us-ascii?Q?j2QF69WYiLn7ZXBJ+AEAudTRgwm6qVw/n4y1QOE0wvjUfbxVZiOV/3K0xV7d?=
 =?us-ascii?Q?UprYJuQDOc22SwbAyhb9JhssfQlMhAnmeuEVBXe0EVUqM4YyWJMBrs4h4cp9?=
 =?us-ascii?Q?EeV2EeP3XvBTBi9qj7vACY2+Awb5qvTLuGdOkvtzdOny2chCpMCYFyXOxrkB?=
 =?us-ascii?Q?8sxtY5DADa3Pa04d3NrcqFRKP4Jzbd0UBi52FEmufV2bKQB2SQuRZGGesG5h?=
 =?us-ascii?Q?Oeq1Vm3/jUZoY3sobnzja/sHdapjb7X2ocwfESZb5E2q4sw5qF4/ErMIvJXQ?=
 =?us-ascii?Q?8k13HVjLAWi+h9Mjfw0Y1EVOhzUYaSEJjnlBwWjfULqpOSNWB7vkxkGfFkRu?=
 =?us-ascii?Q?R+nW3x6CnUw7zSpRUPejC1xTPOLKWT+8STsO/qwC3P3ClxG7i0nIhexq3Nbq?=
 =?us-ascii?Q?J9eB8HRebxRbIWp+eGnRHxx01II1pFFeM8E6MbSdJ1JsvoW7J5ag4bHLKKHx?=
 =?us-ascii?Q?N8tQzpW5paSvxFVgGgppksy8MfmKR5g2kUGF4DvktU/fDS7q/X0VrHSJvDXX?=
 =?us-ascii?Q?cpZJkoqrI92ascj11tXFxShxOZY6OFdM5nt1zO6LxGxNYW6BRR+knN+MmqI2?=
 =?us-ascii?Q?D2aEb+ZzwYV14Mku9pufL6yJaT6pFAHEapL47+5qM+Woi8HfvdjKcVeDdp/S?=
 =?us-ascii?Q?wRrsl8Mxu/zyfYxQjVV2pkjncp5/UvLg83/qhw/BJrPxI0zK3Ol9c6uojLXo?=
 =?us-ascii?Q?B4DrvzGOH6QrXIi3prag++E3Cbin0orN9VsuPsKQHTNCaqYHgGB4+TOkezxJ?=
 =?us-ascii?Q?rQCv77AGdbqeFmQHkL0xm2yC1Hm/88LqxZ/MBsrOoBRKq8d1LjiG2e1umQE0?=
 =?us-ascii?Q?ijxFxhNrwanhoMIo5qFysuIrBRA04zTdaKZbL5Lb0duq5apRAhhlZdrh7FQF?=
 =?us-ascii?Q?/wYNL4pcIRdow7U0ctyth8tSxZwVEkLFxlGqX6PlW13vBfWxCBQXylb7r2I9?=
 =?us-ascii?Q?jSip26LpAKRqfDxsN5xNd0zajfY60p3b1eb+YJ5Fa1wrexp46Y1BeyRiPSPM?=
 =?us-ascii?Q?TJQ6cHGfodQeU2Bm9UEH9MfEL0gO5uRyHodVQXKvD/NvvMeFqW20a7SeD6SN?=
 =?us-ascii?Q?rxKje74AQ1ZsnIDUeUv971Jtcuj/5bs1sB+ue8B2HcQf9m0vJm1cYSRXKA3g?=
 =?us-ascii?Q?31kXZwx3eM0cczxsjSMJbqANHk0aemHsd0YtX7Ih6YuvDdP5siFu972lBdlO?=
 =?us-ascii?Q?iNrXBtRU+XwQFe2XBlK+hIGaygE5WwiAfxq10AEx138Ys/XEbE4iSOu8jeuO?=
 =?us-ascii?Q?I0fixu01mQwMcnGIdZRZLHtki+0FvrRGSKU+hvdUEyM/5JuGXAig6ZDVHZ6x?=
 =?us-ascii?Q?E+fHjqyS7ah40bytpT4yNqQwTXuNuvt76B5is4UvVrAw0W0nzflcNjXZwTE2?=
 =?us-ascii?Q?uUEcLh+BZPY0Cf8TcuElup/05fBRIoV6EiEe5dKLRf02q/+V/ELRt8kbS/ml?=
 =?us-ascii?Q?lrdY8LfTo8/Vb4npJKC3MeTwWam1cOUNxMW74MM5tVpVMwSeIDnSY++YlBKK?=
 =?us-ascii?Q?eufJXA=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: e0ae8033-495d-4e85-1a82-08d9d18a2a51
X-MS-Exchange-CrossTenant-AuthSource: AM9P190MB1122.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2022 03:02:39.6535
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S/gqH7kssIIU1a+4CLfgpffaJZL2oIrXQUkgYTo8zBwbNhrd/MoiN98NqfHBxPoGKnnyQ2sUU1nJnwOE0c9eMCEKo9E7GfYqHx3+9H9yuhs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P190MB0834
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add inetaddr notifiers to support add/del IPv4 address on switchdev
port. We create TRAP on first address, added on port and delete TRAP,
when last address removed.
Currently, driver supports only regular port to became routed.
Other port type support will be added later

Co-developed-by: Taras Chornyi <tchornyi@marvell.com>
Signed-off-by: Taras Chornyi <tchornyi@marvell.com>
Co-developed-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>

Change-Id: I1fc7f2b62187589011f35e79c5f56e5e42389fe5
---
 .../marvell/prestera/prestera_router.c        | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router.c b/drivers/net/ethernet/marvell/prestera/prestera_router.c
index b25a26522b18..c0c6e1f23803 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_router.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_router.c
@@ -4,15 +4,30 @@
 #include <linux/kernel.h>
 #include <linux/types.h>
 #include <linux/inetdevice.h>
+#include <net/switchdev.h>
 
 #include "prestera.h"
 #include "prestera_router_hw.h"
 
+/* This util to be used, to convert kernel rules for default vr in hw_vr */
+static u32 prestera_fix_tb_id(u32 tb_id)
+{
+	if (tb_id == RT_TABLE_UNSPEC ||
+	    tb_id == RT_TABLE_LOCAL ||
+	    tb_id == RT_TABLE_DEFAULT)
+		tb_id = RT_TABLE_MAIN;
+
+	return tb_id;
+}
+
 static int __prestera_inetaddr_port_event(struct net_device *port_dev,
 					  unsigned long event,
 					  struct netlink_ext_ack *extack)
 {
 	struct prestera_port *port = netdev_priv(port_dev);
+	struct prestera_rif_entry_key re_key = {};
+	struct prestera_rif_entry *re;
+	u32 kern_tb_id;
 	int err;
 
 	err = prestera_is_valid_mac_addr(port, port_dev->dev_addr);
@@ -21,9 +36,34 @@ static int __prestera_inetaddr_port_event(struct net_device *port_dev,
 		return err;
 	}
 
+	kern_tb_id = l3mdev_fib_table(port_dev);
+	re_key.iface.type = PRESTERA_IF_PORT_E;
+	re_key.iface.dev_port.hw_dev_num  = port->dev_id;
+	re_key.iface.dev_port.port_num  = port->hw_id;
+	re = prestera_rif_entry_find(port->sw, &re_key);
+
 	switch (event) {
 	case NETDEV_UP:
+		if (re) {
+			NL_SET_ERR_MSG_MOD(extack, "RIF already exist");
+			return -EEXIST;
+		}
+		re = prestera_rif_entry_create(port->sw, &re_key,
+					       prestera_fix_tb_id(kern_tb_id),
+					       port_dev->dev_addr);
+		if (!re) {
+			NL_SET_ERR_MSG_MOD(extack, "Can't create RIF");
+			return -EINVAL;
+		}
+		dev_hold(port_dev);
+		break;
 	case NETDEV_DOWN:
+		if (!re) {
+			NL_SET_ERR_MSG_MOD(extack, "Can't find RIF");
+			return -EEXIST;
+		}
+		prestera_rif_entry_destroy(port->sw, re);
+		dev_put(port_dev);
 		break;
 	}
 
-- 
2.17.1