Date:   Fri, 7 Jan 2022 14:34:11 +1100
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     ebiggers@kernel.org, davem@davemloft.net,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] crypto: af_alg - check possible NULL pointer
Message-ID: <Yde0s8CAr30qrCoj@gondor.apana.org.au>
References: <20211231014036.1870631-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211231014036.1870631-1-jiasheng@iscas.ac.cn>
Precedence: bulk

On Fri, Dec 31, 2021 at 09:40:36AM +0800, Jiasheng Jiang wrote:
> Because of the possible alloc failure of the alloc_page(), it could
> return NULL pointer.
> And there is a check below the sg_assign_page().
> But it will be more logical to move the NULL check before the
> sg_assign_page().
> 
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
> 
> v1 -> v2
> 
> * Change 1. Move the previous check in front of sg_assign_page().
> ---
>  crypto/af_alg.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Patch applied with modified Subject line.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt