IronPort-SDR: 7xGKKR8Ff3mrezAyJLtNsZCI/5IxlkksHDPUs57O9M+3q/dEKNnD09YkaxtgFh0Q9wtVfiifna
 SKdSdC3yX8cp3fC7MUFWHXrlsH7FOeKzHijdvJY2yLEpC2qobpmOF37HuxndtwoaQDOLjzYCwW
 f5zutsC2VqdNLNB1pUAgRJ5hvMRN6Kpt8zIUrr+fxIhz20DbguBkel5Rmm1F60xnXcQh7Bovtq
 fGzUbmRjCM9Qb4PKxLCZo9HOxv7FwNt9DhgJkC3NLYjf/yI4RJs50KQvZ8xOfKoJ+Y4E74wsbs
 33Ej8QaV6x5x9sHLIadoZFy5
IronPort-SDR: IyZx+dYR7jpEUUEXyHlrmMKGHF8ybDUl/njVMLO7ArQsBf7nZ22U69T4wSMb6u6o/msjfj14p/
 +cvgeRiQDIUN3/0hBo1P+IUFOY87IbHPLUkP05UGfm/2wYzfJZxAe+bPqzfPcmCmp+/4pG3zKb
 00GY2xoG2qNQ7S5eYyHxXxkbe/RgSYxzFrIbXR8lcJV4FSCWqSlNsQZlWysyN4IMHm8elnOGJo
 40J5yzP58ckXBUy+jAv4FkWB+oSZcbd8QIphzqR7NB/5LrYJyFcHx5hMPQxFv8dWMd4t94sP8I
 N+A=
WDCIronportException: Internal
Message-ID: <087ac312-1d73-4721-f17f-af48b6ea65a2@opensource.wdc.com>
Date:   Fri, 7 Jan 2022 14:30:35 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [PATCH] ide: Check for null pointer after calling devm_ioremap
Content-Language: en-US
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, davem@davemloft.net
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220107031733.3588290-1-jiasheng@iscas.ac.cn>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital
In-Reply-To: <20220107031733.3588290-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/01/07 12:17, Jiasheng Jiang wrote:
> As the possible failure of the devres_alloc(), the devm_ioremap() and
> devm_ioport_map() may return NULL pointer.
> And then, the 'base' and 'alt_base' is used in plat_ide_setup_ports().
> Therefore, it should be better to add the check in order to avoid the
> dereference of the NULL pointer.
> 
> Fixes: 2bfba3c444fe ("ide: remove useless subdirs from drivers/ide/")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/ide/ide_platform.c | 4 ++++

There is no such file... What kernel is this patch against ?

>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/ide/ide_platform.c b/drivers/ide/ide_platform.c
> index 91639fd6c276..8c6e1af7b6eb 100644
> --- a/drivers/ide/ide_platform.c
> +++ b/drivers/ide/ide_platform.c
> @@ -85,6 +85,10 @@ static int plat_ide_probe(struct platform_device *pdev)
>  		alt_base = devm_ioport_map(&pdev->dev,
>  			res_alt->start, resource_size(res_alt));
>  	}
> +	if (!base || !alt_base) {
> +		ret = -ENOMEM;
> +		goto out;
> +	}
>  
>  	memset(&hw, 0, sizeof(hw));
>  	plat_ide_setup_ports(&hw, base, alt_base, pdata, res_irq->start);


-- 
Damien Le Moal
Western Digital Research