Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id AF39DC433EF
	for <linux-kernel@archiver.kernel.org>; Fri,  7 Jan 2022 07:26:31 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1344383AbiAGH02 (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 7 Jan 2022 02:26:28 -0500
Received: from smtp-out1.suse.de ([195.135.220.28]:52784 "EHLO
        smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234943AbiAGH0Z (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Jan 2022 02:26:25 -0500
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out1.suse.de (Postfix) with ESMTP id 0543E21126;
        Fri,  7 Jan 2022 07:26:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1641540384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=gP/R3vMO2gp0b3LNd+dpYhBbxkWbsvnCrPmSuJG3mDI=;
        b=yr6HlLcNs4+jsUCYXEezyxO+/3Nw2c9rqFnZ2lkNjNoRZIBAOCdWqZGOuadunQ3p1k/xIW
        kAHoSw6+Yxy8vlBTyJXSR0V67YSgMb2DTGwEqWzqbEKnZ8VQznVGJFhtKwq+/tu/jtzCFd
        AxkqLS7eAPKpyjx41MNG4LF5JIJVoEw=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1641540384;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=gP/R3vMO2gp0b3LNd+dpYhBbxkWbsvnCrPmSuJG3mDI=;
        b=BKGF3tW162f+2Gl1VHVLlk4fPvvwcr1x8VHxpd9yo91eQcyOotNbwGUiRqNQAbB+/gLsh4
        oAJgXRsWt9AJznBg==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 9FB11A3B83;
        Fri,  7 Jan 2022 07:26:23 +0000 (UTC)
Date:   Fri, 07 Jan 2022 08:26:23 +0100
Message-ID: <s5hh7aggg68.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     perex@perex.cz, tiwai@suse.com, leon@kernel.org,
        broonie@kernel.org, joe@perches.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ALSA: intel_hdmi: Check for error num after setting mask
In-Reply-To: <20220107020851.3095591-1-jiasheng@iscas.ac.cn>
References: <20220107020851.3095591-1-jiasheng@iscas.ac.cn>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 07 Jan 2022 03:08:51 +0100,
Jiasheng Jiang wrote:
> 
> To maintain the consistency of the code, it should be better to add the
> sanity check after calling dma_set_mask_and_coherent(), like
> tegra_pcm_dma_allocate() in `sound/soc/tegra/tegra_pcm.c`.
> 
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Thanks, applied now.


Takashi