Date:   Fri, 7 Jan 2022 10:33:40 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Alessandro Zummo <a.zummo@towertech.it>,
        Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Cc:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: [PATCH] rtc: gamecube: Fix an IS_ERR() vs NULL check
Message-ID: <20220107073340.GF22086@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ygxPAWM2cEWl9yrEMKB2I7zPQgBk8eAaMnra/9Bklg5finB3nZwEKElVRQUC?=
 =?us-ascii?Q?YvUu2XkSa0elgp1CZ96YbIS/xtn3nNAvarEDZXpndK6h7eIbPa9/B6a9VU9i?=
 =?us-ascii?Q?Haqj4RRlB6Ag2G0VeR265xMWzRk0Otxx7SM5DWxUBsf1XNobCi+SxjauPeXe?=
 =?us-ascii?Q?ontuFfU93ZU/wEIyL54yYjctIYGIVZHEp3KAdoG/fJlxfZQUN95JMlxpGJ2y?=
 =?us-ascii?Q?86onG4uoxKs9QClF6LozgDouh4TtJ+AriMfc9X+RB+2o95KEx2vW6X7NODwS?=
 =?us-ascii?Q?YhVZoSxHqs9SUilitBHdrK6HCNu/QMtxpuGKp9EkB4kaAc6RjAZNDJBYdJvI?=
 =?us-ascii?Q?0tRDyiQ6UJtnTWKbsNJjNA0gIswiQ6vUXicXvLfxo8JYmpfrQvDeVlvPpSHI?=
 =?us-ascii?Q?U/S5qVjEiIvnN8GPYJyMuiO8AqAPXvdKF+tZu0YCVAhNGCD2YEdjGkk3CMRb?=
 =?us-ascii?Q?C1Q8tuA3SFx3LC+30qkjOxSnRuG06uqH5Dv13vIJzyOzpVMdh3A6XoZVZGev?=
 =?us-ascii?Q?jRN/lbKKcAYza8rHVT/7C7ohJ0If1AGz1LQ53BNfthR9/dt76+hKosoj3nEK?=
 =?us-ascii?Q?KBsUEicLU8Fj4Zv29Ax0aIhBnEn1XoLGe3eKS/Q7lXcGve01mWn7jJ1BUT9R?=
 =?us-ascii?Q?dEi6cHyt9exyd7vTRT2bER8YjmwSJ+03BM28U7k0ZVnNmsGrHcgDMasPbmG1?=
 =?us-ascii?Q?bqXhtis7l5vMXR113fE1adKZd8z17Duzm4M1LMNr3TGg9PS2HgiZp4kSmnVb?=
 =?us-ascii?Q?gYIV/hZu+PrPoP4W1qFzw0pLVUPoCM34Zmx/GC32KddKIoH86EV2UleDwkCf?=
 =?us-ascii?Q?12u+m4U+On6bkTCjJqB1/Om26NHZYDaU7MFkJ53BZUsrb9iUqxPSe9WdAdlR?=
 =?us-ascii?Q?m/8dlcc7KIe55j2+PwsMezudivAV32oNctRSd34iqT49Yokn4CxEA73Kzk7S?=
 =?us-ascii?Q?VyBOEJjhgJRREtIzwFUSbOy9gJX77XbL1IXPPsBhkVmh2c3I9RlKiG3Af0Sj?=
 =?us-ascii?Q?vUgAQhfyAGWmsOiWMuZIlLqhS2m5FLC9Tx4M9J+UP6D5aMUH5+CQNyN1kYrv?=
 =?us-ascii?Q?PklZSlI7vzuE8I8XB1LhjY2YORH1q1zVowpxzi5qR39UH9Koh1idGwRl4eRs?=
 =?us-ascii?Q?cOVTamFNvPHtnlA4PMVbujFZC6j/SKb5xNzW5CxM4fTCOuzPr+/Qaatt57is?=
 =?us-ascii?Q?+gtdPk3x7UzHDafZz0E6NzeaB1vuKQSvNBq6RUEKsLg2ssSNARMACpd1DT6s?=
 =?us-ascii?Q?10W23NicOVQTx/sKltxHSlHWZs2qE/RFa0lLxdGHou2n3yJXMzj9VihqvPuT?=
 =?us-ascii?Q?cr2MVJgV3T368HDK9ffegImV23bB8tRNFmfx9b9Zq7Y52M7pPW8ffUFEwfP2?=
 =?us-ascii?Q?FYa5Bvmw+QBum08p9mr5TO4KgntZ34pS8blYvZC0OqDEkwaGurHPJz9s3Fqf?=
 =?us-ascii?Q?Rt2LWOkHn9Cj8bILyLMzgZ5EKGfNcueqRrZwYl1PtWFu/8lk/G2oNdPEzgvl?=
 =?us-ascii?Q?i2nrokJ+pW1Adod5LF36C3K+/rtVzP1fbBIaXin+SP12KAU0hHEHKpTV/lw5?=
 =?us-ascii?Q?SxX18lECEbebISZU6ltcuOMRyFKRrkTTl+mtE14fYTlWzB6HPlG79qp+EUfU?=
 =?us-ascii?Q?h9v2nkbFgBFKoUBg5o7NVM2vJ1m5br96S8PKfTu7BpLNksuD49RdI9O9coNm?=
 =?us-ascii?Q?xOReVUJFpSgyrZoRNoSE4fiPqw4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 250f2331-080d-40bc-41b9-08d9d1b00cc7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2022 07:33:50.9407
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: as/vvqtnoPyPeKtHgqKBPyY5VEAmB9DT0qmdDCZS8RfABXfEm1SIVpvwDdhdv+yAMMJzM1PE07xFEhuveRsei2i6glzuCMGR60VZoF+gwFc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5752
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10219 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 mlxlogscore=999 adultscore=0 suspectscore=0 mlxscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201070053
X-Proofpoint-ORIG-GUID: MTTifFrnJf1oi4tStdUD2tdF0iK9rel5
X-Proofpoint-GUID: MTTifFrnJf1oi4tStdUD2tdF0iK9rel5
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The devm_kzalloc() function returns NULL on error, it doesn't return
error pointers.

Fixes: 86559400b3ef ("rtc: gamecube: Add a RTC driver for the GameCube, Wii and Wii U")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/rtc/rtc-gamecube.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-gamecube.c b/drivers/rtc/rtc-gamecube.c
index 98128746171e..f717b36f4738 100644
--- a/drivers/rtc/rtc-gamecube.c
+++ b/drivers/rtc/rtc-gamecube.c
@@ -319,8 +319,8 @@ static int gamecube_rtc_probe(struct platform_device *pdev)
 	int ret;
 
 	d = devm_kzalloc(dev, sizeof(struct priv), GFP_KERNEL);
-	if (IS_ERR(d))
-		return PTR_ERR(d);
+	if (!d)
+		return -ENOMEM;
 
 	d->iob = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(d->iob))
-- 
2.20.1