Message-ID: <e13e70ff-1416-e0b8-93ae-991cf58a5f1d@canonical.com>
Date:   Fri, 7 Jan 2022 08:34:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH 08/24] ARM: dts: exynos: simplify PMIC DVS pin
 configuration in Peach Pi
Content-Language: en-US
To:     Alim Akhtar <alim.akhtar@gmail.com>
Cc:     Tomasz Figa <tomasz.figa@gmail.com>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Sylwester Nawrocki <snawrocki@kernel.org>,
        Sam Protsenko <semen.protsenko@linaro.org>,
        Chanho Park <chanho61.park@samsung.com>
References: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com>
 <20211231162207.257478-2-krzysztof.kozlowski@canonical.com>
 <CAGOxZ52PjcMD0hFQa95NHO2M5Z+Gpx4HNO14+KCsYnCffLc3JQ@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
In-Reply-To: <CAGOxZ52PjcMD0hFQa95NHO2M5Z+Gpx4HNO14+KCsYnCffLc3JQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06/01/2022 19:47, Alim Akhtar wrote:
> Hi Krzysztof,
> 
> On Sat, Jan 1, 2022 at 1:15 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> The pin configuration for PMIC DVS (pmic-dvs-2 and pmic-dvs-3) are
>> exactly the same, so merge them.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
>>  arch/arm/boot/dts/exynos5800-peach-pi.dts | 20 +++++++-------------
>>  1 file changed, 7 insertions(+), 13 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> index 6bf3fd37fb2b..eca805b83816 100644
>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> @@ -221,7 +221,7 @@ max77802: pmic@9 {
>>                 interrupts = <1 IRQ_TYPE_NONE>;
>>                 pinctrl-names = "default";
>>                 pinctrl-0 = <&max77802_irq>, <&pmic_selb>,
>> -                           <&pmic_dvs_1>, <&pmic_dvs_2>, <&pmic_dvs_3>;
>> +                           <&pmic_dvs_1>, <&pmic_dvs_2>;
>>                 wakeup-source;
>>                 reg = <0x9>;
>>                 #clock-cells = <1>;
>> @@ -874,26 +874,20 @@ &sd1_cmd {
>>
>>  &pinctrl_2 {
>>         pmic_dvs_2: pmic-dvs-2 {
>> -               samsung,pins = "gpj4-2";
>> +               samsung,pins = "gpj4-2", "gpj4-3";
>>                 samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
>>                 samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
>>                 samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>;
>>         };
>> +};
>>
>> -       pmic_dvs_3: pmic-dvs-3 {
>> -               samsung,pins = "gpj4-3";
>> -               samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
>> -               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
>> -               samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>;
>> -       };
>> +/* pinctrl_3*/
>> +/* Drive SPI lines at x2 for better integrity */
>> +&spi2_bus {
>> +       samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
>>  };
>>
> Maybe move this spi2_bus part to patch #07 as the commit does not
> mention this change.
> 

Right, it should be part of #7.


Best regards,
Krzysztof