Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 341C0C433FE for ; Fri, 7 Jan 2022 08:05:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345388AbiAGIF6 (ORCPT ); Fri, 7 Jan 2022 03:05:58 -0500 Received: from mga01.intel.com ([192.55.52.88]:37599 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235551AbiAGIF5 (ORCPT ); Fri, 7 Jan 2022 03:05:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641542757; x=1673078757; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=OL4Ca5sxaqttlyUaMRczDGcqztUS045ixqCnOLN6DU4=; b=hhoDRjbrjjIRcB1SW5Na+T2gU0XymxY/EQ0rvnPen+qbeAtkAeutyFTw 4Ur6Lbp5U2fsCY2vm3RHqd7wHKqqPaxY6Pp1EPj7Qal0mAfseuqIWFRh9 RzU41rHzJloFyCBNC88fyJtYDtfMNq45Mb5LJuglUiG48eOvN9dTVtjRa gc/+RnljCHPsmy5PDLxyX2jg4Wk7LchQdNvmVoXTzo1YxztxglO330Duo rbM3WF020WoouzBQGt88rWdILqzA7BPgJDeTAAftrZtIhYWzxOFBpY1iD fvWZvERrfj9jFXbROETsfjfIz7fu9nBuUMzoZrYhCm9AIHex9ULdAQqJu Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10219"; a="267123695" X-IronPort-AV: E=Sophos;i="5.88,269,1635231600"; d="scan'208";a="267123695" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2022 00:05:44 -0800 X-IronPort-AV: E=Sophos;i="5.88,269,1635231600"; d="scan'208";a="763777486" Received: from zengguan-mobl.ccr.corp.intel.com (HELO [10.254.209.114]) ([10.254.209.114]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2022 00:05:36 -0800 Message-ID: Date: Fri, 7 Jan 2022 16:05:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.4.1 Subject: Re: [PATCH v5 7/8] KVM: VMX: Update PID-pointer table entry when APIC ID is changed Content-Language: en-US To: Tom Lendacky , Paolo Bonzini , "Christopherson,, Sean" , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , "kvm@vger.kernel.org" , Dave Hansen , "Luck, Tony" , Kan Liang , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Kim Phillips , Jarkko Sakkinen , Jethro Beekman , "Huang, Kai" Cc: "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "Hu, Robert" , "Gao, Chao" References: <20211231142849.611-1-guang.zeng@intel.com> <20211231142849.611-8-guang.zeng@intel.com> <640e82f3-489d-60af-1d31-25096bef1a46@amd.com> <4eee5de5-ab76-7094-17aa-adc552032ba0@intel.com> From: Zeng Guang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/6/2022 10:06 PM, Tom Lendacky wrote: > On 1/5/22 7:44 PM, Zeng Guang wrote: >> On 1/6/2022 3:13 AM, Tom Lendacky wrote: >>> On 12/31/21 8:28 AM, Zeng Guang wrote: >>> Won't this blow up on AMD since there is no corresponding SVM op? >>> >>> Thanks, >>> Tom >> Right, need check ops validness to avoid ruining AMD system. Same >> consideration on ops "update_ipiv_pid_table" in patch8. > Not necessarily for patch8. That is "protected" by the > kvm_check_request(KVM_REQ_PID_TABLE_UPDATE, vcpu) test, but it couldn't hurt. OK, make sense. Thanks. > Thanks, > Tom > >> I will revise in next version. Thanks. >>>> +        } else >>>>                ret = 1; >>>>            break; >>>>