From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'SEO HOYOUNG'" <hy50.seo@samsung.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kwmad.kim@samsung.com>, <avri.altman@wdc.com>,
        <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <beanhuo@micron.com>, <asutoshd@codeaurora.org>,
        <cang@codeaurora.org>, <bvanassche@acm.org>,
        <grant.jung@samsung.com>, <junwoo80.lee@samsung.com>,
        <bhoon95.kim@samsung.com>
In-Reply-To: <20220106194804.23892-1-hy50.seo@samsung.com>
Subject: RE: [PATCH v1] scsi: ufs: modify Tactive time setting conditions
Date:   Fri, 7 Jan 2022 13:56:07 +0530
Message-ID: <02b301d803a0$39a31770$ace94650$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQLBB52XwS5PS16occ+sFAPt+NoGoQEXvjyLqnxylZA=
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20220107080332epcas2p216d8123df110623b4287ebf6879f745f@epcas2p2.samsung.com>
        <20220106194804.23892-1-hy50.seo@samsung.com>
Precedence: bulk


>-----Original Message-----
>From: SEO HOYOUNG =5Bmailto:hy50.seo=40samsung.com=5D
>Sent: Friday, January 7, 2022 1:18 AM
>To: linux-scsi=40vger.kernel.org; linux-kernel=40vger.kernel.org;
>kwmad.kim=40samsung.com; alim.akhtar=40samsung.com;
>avri.altman=40wdc.com; jejb=40linux.ibm.com; martin.petersen=40oracle.com;
>beanhuo=40micron.com; asutoshd=40codeaurora.org; cang=40codeaurora.org;
>bvanassche=40acm.org; grant.jung=40samsung.com;
>junwoo80.lee=40samsung.com; bhoon95.kim=40samsung.com
>Cc: SEO HOYOUNG <hy50.seo=40samsung.com>
>Subject: =5BPATCH v1=5D scsi: ufs: modify Tactive time setting conditions
>
>The Tactive time determine the waiting time before burst at hibern8 exit a=
nd
>is determined by H/W at linkup state However, in the case of samsung
>devices, guided host's Tactive time +100us for stability.
>If the HCI's Tactive time is equal or greater than the device, +100us shou=
ld be
>set.
>
>Change-Id: Ie9b502c69264d3e5931ee8b515388094441fa065

Please remove this and advisable to run checkpatch before posting.

>Signed-off-by: SEO HOYOUNG <hy50.seo=40samsung.com>
>---
> drivers/scsi/ufs/ufshcd.c =7C 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
>1049e41abd5b..460d2b440d2e 100644
>--- a/drivers/scsi/ufs/ufshcd.c
>+++ b/drivers/scsi/ufs/ufshcd.c
>=40=40 -7815,7 +7815,7 =40=40 static int
>ufshcd_quirk_tune_host_pa_tactivate(struct ufs_hba *hba)
> 	peer_pa_tactivate_us =3D peer_pa_tactivate *
> 			     gran_to_us_table=5Bpeer_granularity - 1=5D;
>
>-	if (pa_tactivate_us > peer_pa_tactivate_us) =7B
>+	if (pa_tactivate_us >=3D peer_pa_tactivate_us) =7B
> 		u32 new_peer_pa_tactivate;
>
> 		new_peer_pa_tactivate =3D pa_tactivate_us /
>--
>2.26.0