Date:   Fri, 7 Jan 2022 11:32:58 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
Cc:     gregkh@linuxfoundation.org, realwakka@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: move get version func to where all other
 functions are
Message-ID: <20220107083258.GO7674@kadam>
References: <20220106093110.GA20011@mail.google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220106093110.GA20011@mail.google.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p5QF/lT7bSG+ETneh3UqDTNdopx8VXqnrcCxFpI20WwE3o1qzt3A1rappjyQ?=
 =?us-ascii?Q?nDe8iXlX+annmdGz18C3UhIm/iFBxJwbOFP/utcQH7ssE5yrop4tlf3eTT/E?=
 =?us-ascii?Q?3KQ3d/r1tZpaS7Z8OdrbUw9ptgyV5Kpf/6IMGmEMG0NQi8L5GgR5DoxzCMR+?=
 =?us-ascii?Q?4XOh8dXidcRLadUE3dxPVrCxIZjpEYnb5H8KgMMSSsXNfGtGM9Fu2jfo9DT1?=
 =?us-ascii?Q?KOabom8Fe5uDcEBFutV19onJasHAcnmZAfBq7OpQ5UVS0YObdyjapv7VKPJ3?=
 =?us-ascii?Q?/oN1So4CiFEPDLzY/Yuc28sU86XOI8yu168w0GaYrNG5DGW5Ajp9jrjQVclS?=
 =?us-ascii?Q?gaMqkejG718k9DAhV+o75IvIlp3df0NgVVxaP/nTRet/p2EAq1noP9eMzbUR?=
 =?us-ascii?Q?i9ydxybf0ShAi2ph10YgsaGnvqF3t774k0xBU9kbKhnz8WGunF2XfTuZS5eH?=
 =?us-ascii?Q?LayPKdw0JtJ66iYrK+508TDrNWhlTjVmga6a84ZKCRiAumx2fCNCBhCds/vK?=
 =?us-ascii?Q?AzMk4vtQK0KSr27hAHkIfa+5byWx+iLl7/GxoUfRMJjgOy7b3YUdhX9Z9lZ4?=
 =?us-ascii?Q?wYQIpiMAuQ/4vcjTmoyvcd0hF/uXe0OWpX1uDRF5jmeBuloAJ3gglzxywEtZ?=
 =?us-ascii?Q?LwRCZ5HN8EOHdP8lKZjktvzje4SEtGnfHJSmnceinqYbzXqHmJ9ssAu+Txm0?=
 =?us-ascii?Q?ibuznuGY127ZRQLs6mDwcoYZDBSniP6vZXWdr7II7Fz7x25+Z04Q+3xxAudH?=
 =?us-ascii?Q?OAoFUOrVYlamLf+YTeBfvr90znk0E/RbNER+jqTBcrfedeKYi+E2gXLDyIHH?=
 =?us-ascii?Q?cr9CBG5u3fkjosyp57pJOX+U1TmbZJ8uIx3cY13z0NECwAnt5XGXaNPa/LW2?=
 =?us-ascii?Q?QJFQjHnn2G13avNcvgTP6zrmZd9z4OsDqHXkSIMxD3zUW7rkMXqmS41ZkuqQ?=
 =?us-ascii?Q?oMwc7hCtJhydHEvGEsdFzuGCqJdsUwLpHwLYqcuBl7DJfiwbn1xwWq11gPqU?=
 =?us-ascii?Q?ODJyDBym5Qh3rcH1oz6dTRWlLirJjTgr0Lua7iAdvSCcXpxeyyOBfs/Xz89q?=
 =?us-ascii?Q?EYVYVfqxtcZTL6zNEkAjeSnRN8DYeELpx+iYD2Fe4hn9CBDzquljPWVtQhvs?=
 =?us-ascii?Q?MJLac38f/toEs5IcWWN1m501mACY1ja2X/QBqVUiTL6OAw8h5aEjexWcb5/m?=
 =?us-ascii?Q?gfRsYJSrujw0p8K+j8EBwjSKhTGYqvpFQyuEsfH+1tx3/Kp30lxDXEdROjkM?=
 =?us-ascii?Q?LN6GcF1/xkuNQCn4XQZ6SYAtHojEKVSmHTkGq6ogG6lnFhQZ2YtvzUqlpCwC?=
 =?us-ascii?Q?3cRW+v7Nro2qbYPJd1t92ksSibHOXZPnFW9whLYHEcMyaqZoobo9iQdjOjpP?=
 =?us-ascii?Q?WPasNiqIAexFEEZhjAo/mqV+g51jpRllpjwduMtTdEymvF0tzucN7WvdIdR3?=
 =?us-ascii?Q?Xn61yi3L4WBnxl4ySw/U3FgVTmdj9tCPf5g+rZ/4HFugZZt6LQLOVPP01XSQ?=
 =?us-ascii?Q?HQpDZU2rWvyxWRK52pgiUy4o7rgH+Wly2gTi06UqLxe95iK0YnaOj8W0xwb1?=
 =?us-ascii?Q?hHROjLLYg8QniabMV3MV+iGmiaqkH0v5S9+F0dP0rGsJKpL+7kSMdoh/Z5tQ?=
 =?us-ascii?Q?oIeB9w3DxNVLGpzgZ3TiKTqqnLnELQP/l8R1JdXQQwqmRMhxCk7XQF392StQ?=
 =?us-ascii?Q?vDU4jtH2/mKRTH7XilT7j+laNY8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fb64b4c-ad8d-4560-520a-08d9d1b85b86
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2022 08:33:19.1227
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jAEl6ABy24xl/q95e+vPAvxepL3vnxEu7bmKr9IJoRQa0YeW2gEsV3mfQvfeaev8rwTbdQthHhH0RDrQ09yxmMU6teaPFiO9VLSQ6p79qy4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4691
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10219 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 spamscore=0 mlxscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201070060
X-Proofpoint-ORIG-GUID: grzIKllSRv3wk4dCJjhALuP0fcYZPouJ
X-Proofpoint-GUID: grzIKllSRv3wk4dCJjhALuP0fcYZPouJ
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 06, 2022 at 10:31:10PM +1300, Paulo Miguel Almeida wrote:
> As a convention for the pi433 driver, all routines that deals with the
> rf69 chip are defined in the rf69.c file. There was an exception in
> which the uC version verification was being done directly elsewhere.
> While at it, the Version Register hardcoded value was replaced with a
> pre-existing constant in the driver.
> 
> This patch adds rf69_get_chip_version function to rf69.c
> 
> Additionally, the patch below must be applied first as it was sent
> before and touches the same file.
> https://lore.kernel.org/lkml/20220103222334.GA6814@mail.google.com/

Put these sorts of meta commentary underneath the --- cut off

> 
> Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
> ---
  ^^^

here.  We don't need to preserve that information in the git log for all
of history.

Other people have basically said all the other stuff that I was going
to say...

regards,
dan carpenter