Date:   Fri, 7 Jan 2022 11:58:52 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Abdun Nihaal <abdun.nihaal@gmail.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] staging: r8188eu: change functions to return void
Message-ID: <20220107085852.GQ7674@kadam>
References: <cover.1641490034.git.abdun.nihaal@gmail.com>
 <9db6b08837bd6354c8e07a4b1c4bca662091f945.1641490034.git.abdun.nihaal@gmail.com>
 <Ydct2sBt6aB+MChS@kroah.com>
 <20220107065210.7utcwjenvcspydyk@nlap2>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220107065210.7utcwjenvcspydyk@nlap2>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dCJ7RprRfYQel0KY4n7NP6ineqzjMlZ3HsV3dt19AcdDiEH8JoRp1uqmg+Z1?=
 =?us-ascii?Q?I6ICxainAkVfhIdgkC1A/00ctmvs4pKvqP7+di9iDdJZJrWBvSc2MynPbo/g?=
 =?us-ascii?Q?QN+wKMWHv9v37QU1V93LjjAFterayTwj43rosDhKpQ7ioE0qFAYRDOhI7pul?=
 =?us-ascii?Q?/e8yIEZAPbvtIhEsGUZn3uKATWf/4FkAUzIUI6Q8XlS8fYGnB1ir56BRUjcr?=
 =?us-ascii?Q?Y4xK1COQKfwFz0BFIMvPK6Sa+gaFfQi/Ku3seZ3JnieKAuVnuy9Y+z4ENVdP?=
 =?us-ascii?Q?ZdZuCT503jB6eK+vCyrJDZNWycAdbPqXA7a4X6Y0fOnxoIfryS6a/YqjvSgz?=
 =?us-ascii?Q?YyVRjRmT2KOYKqB/xzOFHBzipQ0ntrQTe3YXNrXC3NXmXDGAtLyb0IcD8sbR?=
 =?us-ascii?Q?tBvoYZuW1MAzMEHrLwgPGfAmdNhsOk6ZLs3RZ3aRAWIgXPyCbtzYR7LyohQm?=
 =?us-ascii?Q?C+CCy46vuiuf+8jzsSZNrGeia279JJGiSr/y/Ii0B6o4dUyNRfoIMsWvGHMQ?=
 =?us-ascii?Q?8dYezhK9BJHY+iC51FSaqFZEmtKBTlEVuWr2m+63o0v1gWpB8CoKkdaw14vV?=
 =?us-ascii?Q?Qj9zGjydMf93QSrU4tbireqslnnRlcpY4RvSe1fXb0D3T15jqMnVFK4KmgMU?=
 =?us-ascii?Q?UU9JLO2COpE5W+gUqUYXdJLjq31nOUnlvGYqpS/YV7dhmumN8oOEQjDNFaVk?=
 =?us-ascii?Q?uBgO6jfuS8XTrT0UrVgyqCGuY/0Vz1y5RUMTXAPHsftT14/p0i3e76bqPclH?=
 =?us-ascii?Q?RNHW43QTgfQwGQat+lpM/WKP8WBy715e/oPNWzvfRg5B8ROkR6iVbTPFBGnV?=
 =?us-ascii?Q?Wa+tbpCkmk8WbPrdfuLZNUutOpy4AN8TasBiPyKP66mAWOJ+a0k7cRVhee7A?=
 =?us-ascii?Q?ectePRVo1RcFdADdrQL3kStVLT0s6D4Sxz5k73dEmwin9HUanG/6QfdjAsem?=
 =?us-ascii?Q?JeYLghemFyKPDTyPVLGte7oct7TLNkL9KHG45KQ03c/Ss71MzPi/6R3WqZac?=
 =?us-ascii?Q?njBuIMi/BdBdQk4uQ8dPjH6Zfr6UwyC9AYAok25uPWEaaIFnJ+h53yMrypXS?=
 =?us-ascii?Q?WcYdrRnKttuf1m0h56mTTOHiTTESGLzPiXJVWXyUCTQTo3oQju7AfLagFHAm?=
 =?us-ascii?Q?NBU5W5i9mbXZFCAD4Ehxzp0VYv6cD/jqdOtW3OZjg4z9c7Wm2+yt6waCMUO1?=
 =?us-ascii?Q?bOIqB/5zar6b46meBvB/0hy/Ep41G0eVbsVb4s5YEpBR2/y/sQJAf14SgxV7?=
 =?us-ascii?Q?5isOXNIivv63K6dVZwkZ8WCRDJ5tmZNYBpQtKa9T/225HGf05m5PlmiIHma6?=
 =?us-ascii?Q?1ONrd8T35zjPKzA7S3rOjrOfVHhorStQf54P6BlZRjnH+RefNAaiBxOWqrQA?=
 =?us-ascii?Q?LrrYnLkg1ys0N46Kae9WW73DWUq6yI20ngV7we+F8O2Q6nYBOlpLfdsVRUBq?=
 =?us-ascii?Q?uQNmxRmIBoLHklc409gRlhgaIQ5WuxREMhFrsFU22AnygdBID5oZxkNtldQ2?=
 =?us-ascii?Q?iinScscUCFsykf1SaLpQwjeLellPlnFPyRgYnBkngD2PV/cAI6Hcg/HCTqVD?=
 =?us-ascii?Q?z4zdEg6R+kkSp9rTFVtWQuO1mhIO58m6rWkU1h3uk0WbLjF2wHYenw9iNDjk?=
 =?us-ascii?Q?y6N12CFZjSEL5jujsXLlw0HEMQoG0ilUWe/TLIylPrDsHjnOBbv/Wz9nnm1l?=
 =?us-ascii?Q?iQtcX28/AgsQEZ05gCB635mLZ7k=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b08617ce-390f-45c3-2d3a-08d9d1bbf909
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2022 08:59:12.2009
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZowflKVK3B8WHVzn+U//OWnkCQOabJ+3rNAE7APDuS1SMApXDc3ImqPieIhCJ4vKVsXpIcZ0tTpfd+jVxirjKPJnZe7j/7b7hmUPuFPi2sw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5677
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10219 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 mlxlogscore=872 adultscore=0 suspectscore=0 mlxscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201070064
X-Proofpoint-ORIG-GUID: yKJFybVw2mxn7hzGBebub4W1LnpZT5Q4
X-Proofpoint-GUID: yKJFybVw2mxn7hzGBebub4W1LnpZT5Q4
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 07, 2022 at 12:22:10PM +0530, Abdun Nihaal wrote:
> Hello Greg,
> 
> On Thu, Jan 06, 2022 at 06:58:50PM +0100, Greg KH wrote:
> > On Thu, Jan 06, 2022 at 11:11:52PM +0530, Abdun Nihaal wrote:
> > > Some functions in ioctl_linux.c always returns 0 and their return values
> > > are never used. Change return type of such functions to void.
> > > 
> > > While at it, align function arguments with open parenthesis to fix
> > > checkpatch checks.
> > > 
> > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Signed-off-by: Abdun Nihaal <abdun.nihaal@gmail.com>
> > 
> > Are you sure that checkpatch allowed this change?
> 
> Yes, I ran checkpatch on both the patches and found no errors, warnings
> or checks. Is there something that needs to be fixed?

You're not allowed to end a void function with a return statement.

Checkpatch will only detect these if you run it again with the -f
option.

regards,
dan carpenter