MIME-Version: 1.0
References: <20220106174803.1773876-1-gsomlo@gmail.com> <20220106174803.1773876-4-gsomlo@gmail.com>
 <CAHp75Ve_jWmo3+Es0G5SyMpcdC_=hWfxHoa866Difd+X3F0uxg@mail.gmail.com> <YddyMI7hJE7u0jQ/@errol.ini.cmu.edu>
In-Reply-To: <YddyMI7hJE7u0jQ/@errol.ini.cmu.edu>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 7 Jan 2022 10:36:12 +0100
Message-ID: <CAMuHMdX2ujViu9GivVHtgAqC6AdiL3CvdJM58pVteJe9KdvdqQ@mail.gmail.com>
Subject: Re: [PATCH v6 3/3] mmc: Add driver for LiteX's LiteSDCard interface
To:     "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        linux-mmc <linux-mmc@vger.kernel.org>,
        Karol Gugala <kgugala@antmicro.com>,
        Mateusz Holenko <mholenko@antmicro.com>,
        Kamil Rakoczy <krakoczy@antmicro.com>,
        mdudek@internships.antmicro.com,
        Paul Mackerras <paulus@ozlabs.org>,
        Joel Stanley <joel@jms.id.au>,
        Stafford Horne <shorne@gmail.com>,
        david.abdurachmanov@sifive.com,
        Florent Kermarrec <florent@enjoy-digital.fr>,
        Randy Dunlap <rdunlap@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Gabriel,

On Thu, Jan 6, 2022 at 11:50 PM Gabriel L. Somlo <gsomlo@gmail.com> wrote:
> On Thu, Jan 06, 2022 at 08:19:39PM +0200, Andy Shevchenko wrote:
> > On Thu, Jan 6, 2022 at 7:48 PM Gabriel Somlo <gsomlo@gmail.com> wrote:
> > >
> > > LiteX (https://github.com/enjoy-digital/litex) is a SoC framework
> > > that targets FPGAs. LiteSDCard is a small footprint, configurable
> > > SDCard core commonly used in LiteX designs.
> > >
> > > The driver was first written in May 2020 and has been maintained
> > > cooperatively by the LiteX community. Thanks to all contributors!
> >
> > > +config MMC_LITEX
> > > +       tristate "LiteX MMC Host Controller support"
> > > +       depends on OF
> > > +       depends on PPC_MICROWATT || LITEX || COMPILE_TEST
> > > +       help
> > > +         This selects support for the MMC Host Controller found in LiteX SoCs.
> > > +
> > > +         If unsure, say N.
> >
> > What would be the module name if built as a module?
>
> litex_mmc.ko -- why are you asking? I.e., should I mention that anywhere
> in the Kconfig blurb (I don't see other blurbs doing that, fwiw)?

Many (most?) blurbs do mention the module name.

> > > +       div = min(max(div, 2U), 256U);
> >
> > clamp_t() / clamp_val() ?
>
> OK, changed to `div = clamp_val(div, 2U, 256U);`

Please use clamp() instead of clamp_val(), as all three parameters
have the same type (clamp_val() uses casts to align all parameters;
casts are evil).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds