Message-ID: <ed37164f-74b1-de58-8308-4a11ea352faa@linux.ibm.com>
Date:   Fri, 7 Jan 2022 10:54:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [RFC PATCH net v2 1/2] net/smc: Resolve the race between link
 group access and termination
Content-Language: en-US
To:     Wen Gu <guwen@linux.alibaba.com>, davem@davemloft.net,
        kuba@kernel.org
Cc:     linux-s390@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, dust.li@linux.alibaba.com,
        tonylu@linux.alibaba.com
References: <1640704432-76825-1-git-send-email-guwen@linux.alibaba.com>
 <1640704432-76825-2-git-send-email-guwen@linux.alibaba.com>
 <4ec6e460-96d1-fedc-96ff-79a98fd38de8@linux.ibm.com>
 <0a972bf8-1d7b-a211-2c11-50e86c87700e@linux.alibaba.com>
 <4df6c3c1-7d52-6bfa-9b0d-365de5332c06@linux.ibm.com>
 <095c6e45-dd9e-1809-ae51-224679783241@linux.alibaba.com>
 <1cf77005-1825-0d34-6d34-e1b513c28113@linux.ibm.com>
 <747c3399-4e6f-0353-95bf-6b6f3a0f5f60@linux.alibaba.com>
From:   Karsten Graul <kgraul@linux.ibm.com>
Organization: IBM Deutschland Research & Development GmbH
In-Reply-To: <747c3399-4e6f-0353-95bf-6b6f3a0f5f60@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 06/01/2022 14:02, Wen Gu wrote:
> Thanks for your reply.
> 
> On 2022/1/5 8:03 pm, Karsten Graul wrote:
>> On 05/01/2022 09:27, Wen Gu wrote:
>>> On 2022/1/3 6:36 pm, Karsten Graul wrote:
>>>> On 31/12/2021 10:44, Wen Gu wrote:
>>>>> On 2021/12/29 8:56 pm, Karsten Graul wrote:
>>>>>> On 28/12/2021 16:13, Wen Gu wrote:
>>>>>>> We encountered some crashes caused by the race between the access
>>>>>>> and the termination of link groups.
> So I am trying this way:
> 
> 1) Introduce a new helper smc_conn_lgr_state() to check the three stages mentioned above.
> 
>   enum smc_conn_lgr_state {
>          SMC_CONN_LGR_ORPHAN,    /* conn was never registered in a link group */
>          SMC_CONN_LGR_VALID,     /* conn is registered in a link group now */
>          SMC_CONN_LGR_INVALID,   /* conn was registered in a link group, but now
>                                     is unregistered from it and conn->lgr should
>                                     not be used any more */
>   };
> 
> 2) replace the current conn->lgr check with the new helper.
> 
> These new changes are under testing now.
> 
> What do you think about it? :)

Sounds good, but is it really needed to separate 3 cases, i.e. who is really using them 3?
Doesn't it come down to a more simple smc_conn_lgr_valid() which is easier to implement in
the various places in the code? (i.e.: if (smc_conn_lgr_valid()) ....)
Valid would mean conn->lgr != NULL and conn->alert_token_local != 0. The more special cases
would check what they want by there own.