Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD409C433FE for ; Fri, 7 Jan 2022 11:29:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347116AbiAGL3s (ORCPT ); Fri, 7 Jan 2022 06:29:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236893AbiAGL3r (ORCPT ); Fri, 7 Jan 2022 06:29:47 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34540C061245; Fri, 7 Jan 2022 03:29:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E8A62B825A5; Fri, 7 Jan 2022 11:29:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11AEBC36AE9; Fri, 7 Jan 2022 11:29:42 +0000 (UTC) Date: Fri, 7 Jan 2022 12:29:40 +0100 From: Christian Brauner To: Geert Uytterhoeven Cc: Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] sysctl: Fix duplicate path separator in printed entries Message-ID: <20220107112940.rrn5gloahk5durwu@wittgenstein> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 07, 2022 at 11:38:44AM +0100, Geert Uytterhoeven wrote: > sysctl_print_dir() always terminates the printed path name with a slash, > so printing a slash before the file part causes a duplicate like in > > sysctl duplicate entry: /kernel//perf_user_access > > Fix this by dropping the extra slash. > > Signed-off-by: Geert Uytterhoeven > --- Seems good, Acked-by: Christian Brauner