Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1347CC43217 for ; Fri, 7 Jan 2022 11:54:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347278AbiAGLyd (ORCPT ); Fri, 7 Jan 2022 06:54:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238151AbiAGLyb (ORCPT ); Fri, 7 Jan 2022 06:54:31 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD7C5C061245; Fri, 7 Jan 2022 03:54:30 -0800 (PST) Received: from zn.tnic (dslb-088-067-202-008.088.067.pools.vodafone-ip.de [88.67.202.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id EAEDB1EC050F; Fri, 7 Jan 2022 12:54:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1641556464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=3MIYGxgH8IVPjiqqCa7t3Lo2u7g3b4PoNQjM+91zpCA=; b=FU1VPAiZExsp8CWcc+5uBx2KE8ofLRKwYAEacXKc/WoJmG5ix8y6YepFTfg6BrR2tFRIRc 8z842ggZG/47ZdrSHS02L3fV+tCk1vJb09JWLACRvLM0eEMcdDwYtkbv67Urt3x5VGyg9k 05DcM2HDWfspdY8zhbyqugm2KSUdDW4= Date: Fri, 7 Jan 2022 12:54:25 +0100 From: Borislav Petkov To: Dave Hansen Cc: Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v8 27/40] x86/boot: Add Confidential Computing type to setup_data Message-ID: References: <20211210154332.11526-1-brijesh.singh@amd.com> <20211210154332.11526-28-brijesh.singh@amd.com> <1fdaca61-884a-ac13-fb33-a47db198f050@intel.com> <2a5cfbd0-865c-2a8b-b70b-f8f64aba5575@intel.com> <48625a39-9e31-d7f2-dccf-74e9c27126f5@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <48625a39-9e31-d7f2-dccf-74e9c27126f5@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 13, 2021 at 07:08:07AM -0800, Dave Hansen wrote: > Could you please make the structure's size invariant? That's great if > there's no problem in today's implementation, but it's best no to leave > little land mines like this around. Let's say someone copies your code > as an example of something that interacts with a firmware table a few > years or months down the road. Btw, about that cc blob thing: is TDX going to need something like that too and if so, can they use it too? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette