Date:   Fri, 7 Jan 2022 13:06:19 +0100
From:   Christian Brauner <christian.brauner@ubuntu.com>
To:     Andrei Vagin <avagin@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org,
        Dmitry Safonov <0x7f454c46@gmail.com>
Subject: Re: [PATCH] fs/pipe: local vars has to match types of proper
 pipe_inode_info fields
Message-ID: <20220107120619.zueev37fhuvq3k6i@wittgenstein>
References: <20220106171946.36128-1-avagin@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220106171946.36128-1-avagin@gmail.com>
Precedence: bulk

On Thu, Jan 06, 2022 at 09:19:46AM -0800, Andrei Vagin wrote:
> head, tail, ring_size are declared as unsigned int, so all local
> variables that operate with these fields have to be unsigned to avoid
> signed integer overflow.
> 
> Right now, it isn't an issue because the maximum pipe size is limited by
> 1U<<31.
> 
> Cc: Dmitry Safonov <0x7f454c46@gmail.com>
> Suggested-by: Dmitry Safonov <0x7f454c46@gmail.com>
> Signed-off-by: Andrei Vagin <avagin@gmail.com>
> ---

Looks good,
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>