IronPort-SDR: TqnrKY7m1v3mRAdtVd5jlcJgHmxf0nadps0LIComD8uis1LqlmrwoqNQOVJyqrZcC8oRU/KoJi
 fecDSlNqDMTI1ZCe2HIvQBXjmd8UjpENM/jOZi+o7k4HKl7ishSxF1XejPn6HD4wjppCmoxNdJ
 /7gJiF39L5mwj68wACZSi/FnY8bcYaeoEt+4U8nz63X1Qfb/QxsAibVPSI8a7dMAlyoiWuEYhB
 n9E2MrGczA9R9dfqkU5/h5TVD2DgVDXooxtVwfLPJhCKgAHOQG5TUni6wf6JHmQleCaQ90N4QE
 WBoZ43+41NRQ4wKjmZNIQGpU
IronPort-SDR: v16p06sQiHeo9jfDYCcY6ng8fTePy17O4cd/LTm9hxQXRUnV8dVz7ZEX+GwYJV0qVFd5UGjzET
 WuLg2PWSOG1AZrZjlM3D5E2apazYUNt98mbzn1CO9Mgq/l9YT86pINzuVrAGpQO4BdIC//DAve
 a6uUh9QhUiYgPo2Ll+t8RBgysXtFlf6Fxk+Ou540uhsT+NC5nfi+THoCZ6V2QGnCFnAWlMa0Hl
 gkMkbL3hGTzN3efOMZrgCSP2TfSNqpIz8mQ/BH5W0wwViW94LVx/Ztclft8UfizWAXgySTfUc3
 LBQ=
WDCIronportException: Internal
Message-ID: <604c4187-ba45-1395-1409-103865d82c53@opensource.wdc.com>
Date:   Fri, 7 Jan 2022 21:07:40 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap
Content-Language: en-US
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, David.Laight@ACULAB.COM,
        davem@davemloft.net
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220107115000.4057454-1-jiasheng@iscas.ac.cn>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220107115000.4057454-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/7/22 20:50, Jiasheng Jiang wrote:
> In linux-stable-5.15.13, this file has been removed and combined
> to `drivers/ata/pata_platform.c` without this bug.
> But in the older LTS kernels, like 5.10.90, this bug still exists.
> As the possible failure of the devres_alloc(), the devm_ioremap() and
> devm_ioport_map() may return NULL pointer.
> And then, the 'base' and 'alt_base' are used in plat_ide_setup_ports().
> Therefore, it should be better to add the check in order to avoid the
> dereference of the NULL pointer.
> Actually, it introduced the bug from commit 8cb1f567f4c0
> ("ide: Platform IDE driver") and we can know from the commit message
> that it tended to be similar to the `drivers/ata/pata_platform.c`.
> But actually, even the first time pata_platform was built,
> commit a20c9e820864 ("[PATCH] ata: Generic platform_device libata driver"),
> there was no the bug, as there was a check after the ioremap().
> So possibly the bug was caused by ide itself.
> 
> Fixes: 8cb1f567f4c0 ("ide: Platform IDE driver")
> Cc: stable@vger.kernel.org#5.10.90

This should be:

Cc: stable@vger.kernel.org #5.10

(no release number specified)

> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog
> 
> v2 -> v3
> 
> * Change 1. Correct the fixes tag and commit message.
> * Change 2. Correct the code.

What exactly was corrected should be the change log.
And please keep the history for all versions of the patch (keep v1 -> v2
changes listed here).

> ---
>  drivers/ide/ide_platform.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/ide/ide_platform.c b/drivers/ide/ide_platform.c
> index 91639fd6c276..5500c5afb3ca 100644
> --- a/drivers/ide/ide_platform.c
> +++ b/drivers/ide/ide_platform.c
> @@ -85,6 +85,10 @@ static int plat_ide_probe(struct platform_device *pdev)
>  		alt_base = devm_ioport_map(&pdev->dev,
>  			res_alt->start, resource_size(res_alt));
>  	}
> +	if (!base || !alt_base) {
> +		ret = -ENOMEM;
> +		goto out;
> +	}
>  
>  	memset(&hw, 0, sizeof(hw));
>  	plat_ide_setup_ports(&hw, base, alt_base, pdata, res_irq->start);


-- 
Damien Le Moal
Western Digital Research