Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A435C433F5 for ; Fri, 7 Jan 2022 12:12:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238502AbiAGMMs (ORCPT ); Fri, 7 Jan 2022 07:12:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238403AbiAGMMr (ORCPT ); Fri, 7 Jan 2022 07:12:47 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A4CDC061201 for ; Fri, 7 Jan 2022 04:12:47 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id l10-20020a17090a384a00b001b22190e075so11781726pjf.3 for ; Fri, 07 Jan 2022 04:12:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JH+rLYSlJ8WYeLk9ubntyaN9ZeQzzuznIoWrQdFG93c=; b=WBX+6ycom5E2aN595ka3qpbcOKnYJisf2VKHekYsdQbw2sFl6q5ibnAWlk3SpjK3VF lj0BIB5N+5TbAH3pDht2npVHCX/s+a5fdt6BOWBp/7RUVvcCP1CfCWh1s8ny/AEdLHlz jOfW+pPKheW5AiI6l24nnbbvx1IeuILoaZRiyFXCz/yi2Yk3eSN3zMxxCOgy0c0QcQBf wdAluiG//AYUZ/Fc/f4y+rTSlvjd10qQwRI4HxqcaJRrc2GXY5zpiynwHmArgP2i2zbn ttdEZeuRojAkaPqbbhUM/qDE0650QiDaituVDCpOQ30WeqpQ19Bza9qhKRdXOBHd9/jf YFTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JH+rLYSlJ8WYeLk9ubntyaN9ZeQzzuznIoWrQdFG93c=; b=Ccf1J25bZmoPLFaC1Gc7qf6V5oUaaKJ39fmxms5QXPZBGbq3myCheEppi2rJPStj71 Ei1yGJ9juW+sXHIEHarMqrJ0xwzDtdAOWzZO/QY3iN8fzT0b2NatZwwdvU1b3hCrQF0Q +UjKZrS9M+blGTH+1MBeR+aiwlKFEN/fflgCZr1oLBo8ONoC8puFqBX9xtqqAIUIV/l3 laui5Gu8zFVpdlpXfwx+8eSKM01OEAhqHEj3jqdUseBPzHjHwgQBoJ0KrTAugJUvT3PM wfy1zbe1t9aTADPhwHdHPrN/tBNOqPAavBQ2ou1AVbHGWCjluPwx6yWd/c6tsSLiwyU3 GM7A== X-Gm-Message-State: AOAM533GF1nLSE8TJYmWcILOra/FYz8tC2B3uonPjF4TQP1ZdlUEyIkL i3bwHFiRwf0I0Q+Dwd81Z3PLtBifs4x4DQ== X-Google-Smtp-Source: ABdhPJyg2aKvo2l2rQIhpKOfWbZEJxO/H54bF+b1MVjcMT/eOIVVPPMq8lt5iVBWd3LtmizXVLQSWw== X-Received: by 2002:a17:90b:1651:: with SMTP id il17mr15592489pjb.10.1641557567033; Fri, 07 Jan 2022 04:12:47 -0800 (PST) Received: from yinxin.bytedance.net ([139.177.225.251]) by smtp.gmail.com with ESMTPSA id h1sm5888137pfi.109.2022.01.07.04.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 04:12:46 -0800 (PST) From: Xin Yin To: harshadshirwadkar@gmail.com, tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Xin Yin Subject: [PATCH 0/2] ext4: fix issues when fast commit work with jbd Date: Fri, 7 Jan 2022 20:12:13 +0800 Message-Id: <20220107121215.1912-1-yinxin.x@bytedance.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When test fast commit with xfstests generic/455, some logic issues were found. When a full commit is ongonig, the logic of fast commit tracking seems not correct. The first patch fix the ineligible commit case , and the second patch fix the common fast commit case. After testing this patch set with xfstests log and quick group, no regressions were found, and the generic/455 can pass now. Xin Yin (2): ext4: fast commit may not fallback for ineligible commit ext4: fast commit may miss file actions fs/ext4/ext4.h | 3 ++- fs/ext4/extents.c | 4 ++-- fs/ext4/fast_commit.c | 28 +++++++++++++++++++--------- fs/ext4/inode.c | 4 ++-- fs/ext4/ioctl.c | 4 ++-- fs/ext4/namei.c | 4 ++-- fs/ext4/super.c | 1 + fs/ext4/xattr.c | 6 +++--- fs/jbd2/commit.c | 2 +- fs/jbd2/journal.c | 2 +- include/linux/jbd2.h | 2 +- 11 files changed, 36 insertions(+), 24 deletions(-) -- 2.20.1