Message-ID: <ce5c92ac-a439-661f-6005-c4dd31c547be@datenfreihafen.org>
Date:   Fri, 7 Jan 2022 14:43:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH -next] ieee802154: atusb: move to new USB API
Content-Language: en-US
To:     Pavel Skripkin <paskripkin@gmail.com>, alex.aring@gmail.com,
        davem@davemloft.net, kuba@kernel.org, linux-wpan@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220105144947.12540-1-paskripkin@gmail.com>
 <4186d48a-ea7e-39c1-d1fa-1db3f6627a3a@datenfreihafen.org>
 <8da136c2-a4f8-bc3b-7c61-de29217153fa@gmail.com>
From:   Stefan Schmidt <stefan@datenfreihafen.org>
In-Reply-To: <8da136c2-a4f8-bc3b-7c61-de29217153fa@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Hello.

On 05.01.22 21:58, Pavel Skripkin wrote:
> Hi Stefan,
> 
> On 1/5/22 23:27, Stefan Schmidt wrote:
>>> +    ret = usb_control_msg_recv(usb_dev, 0, ATUSB_REG_READ, 
>>> ATUSB_REQ_FROM_DEV,
>>> +                   0, RG_PART_NUM, &atusb, 1, 1000, GFP_KERNEL);
>>
>> This needs to be written to &part_num and not &atusb.
>>
> 
> Oh, stupid copy-paste error :( Thanks for catching this!
> 
>> Pretty nice for a first blind try without hardware. Thanks.
>>
>> Will let you know if I find anything else from testing.
> 
> Ok, will wait for test results. Thank you for your time ;)

Testing went fine and showed no additional problems. I spotted one more 
thing in review though which I would like to see changed. See my reply 
to the patch itself.

regards
Stefan Schmidt