Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161120AbXBAAaR (ORCPT ); Wed, 31 Jan 2007 19:30:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161116AbXBAAaR (ORCPT ); Wed, 31 Jan 2007 19:30:17 -0500 Received: from smtp.osdl.org ([65.172.181.24]:32847 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161121AbXBAAaP (ORCPT ); Wed, 31 Jan 2007 19:30:15 -0500 Date: Wed, 31 Jan 2007 16:26:31 -0800 From: Andrew Morton To: Linus Torvalds Cc: =?ISO-8859-1?Q?Pawe=C5?= Sikora , Linux Kernel Mailing List , Christoph Hellwig , Pekka Enberg , "Siddha, Suresh B" , Martin Peschke , Adrian Bunk , Nick Piggin Subject: Re: Linux 2.6.20-rc7 Message-Id: <20070131162631.4ae5800d.akpm@osdl.org> In-Reply-To: References: <45C05150.6000802@agmk.net> <200702010037.48472.pluto@agmk.net> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 20 On Wed, 31 Jan 2007 16:19:06 -0800 (PST) Linus Torvalds wrote: > I should either revert that commit or just check for "free_pages" being > negative. The latter, in many ways, is probably better, because generally > we simply should never work with negative numbers in the kernel, so when > something potentially goes negative, we're probably just better off always > testing it explicitly anyway. > > Nick, Andrew, any preferences? It would be cleaner to check for negativity, but note that we keep subtracting stuff from free_pages in the later loop, so we'd need to check there as well. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/