Date:   Fri, 7 Jan 2022 09:07:33 -0500
From:   "Gabriel L. Somlo" <gsomlo@gmail.com>
To:     Stafford Horne <shorne@gmail.com>
Cc:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        linux-mmc <linux-mmc@vger.kernel.org>,
        Karol Gugala <kgugala@antmicro.com>,
        Mateusz Holenko <mholenko@antmicro.com>,
        Kamil Rakoczy <krakoczy@antmicro.com>,
        mdudek@internships.antmicro.com,
        Paul Mackerras <paulus@ozlabs.org>,
        Joel Stanley <joel@jms.id.au>, david.abdurachmanov@sifive.com,
        Florent Kermarrec <florent@enjoy-digital.fr>,
        Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v6 3/3] mmc: Add driver for LiteX's LiteSDCard interface
Message-ID: <YdhJJd2DJUIKJuv1@errol.ini.cmu.edu>
References: <20220106174803.1773876-1-gsomlo@gmail.com>
 <20220106174803.1773876-4-gsomlo@gmail.com>
 <CAHp75Ve_jWmo3+Es0G5SyMpcdC_=hWfxHoa866Difd+X3F0uxg@mail.gmail.com>
 <YddyMI7hJE7u0jQ/@errol.ini.cmu.edu>
 <CAMuHMdX2ujViu9GivVHtgAqC6AdiL3CvdJM58pVteJe9KdvdqQ@mail.gmail.com>
 <YdgSG7t2eG9YzkaG@antec>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YdgSG7t2eG9YzkaG@antec>
Precedence: bulk

On Fri, Jan 07, 2022 at 07:12:43PM +0900, Stafford Horne wrote:
> On Fri, Jan 07, 2022 at 10:36:12AM +0100, Geert Uytterhoeven wrote:
> > Hi Gabriel,
> > 
> > On Thu, Jan 6, 2022 at 11:50 PM Gabriel L. Somlo <gsomlo@gmail.com> wrote:
> > > On Thu, Jan 06, 2022 at 08:19:39PM +0200, Andy Shevchenko wrote:
> > > > On Thu, Jan 6, 2022 at 7:48 PM Gabriel Somlo <gsomlo@gmail.com> wrote:
> > > > >
> > > > > LiteX (https://github.com/enjoy-digital/litex) is a SoC framework
> > > > > that targets FPGAs. LiteSDCard is a small footprint, configurable
> > > > > SDCard core commonly used in LiteX designs.
> > > > >
> > > > > The driver was first written in May 2020 and has been maintained
> > > > > cooperatively by the LiteX community. Thanks to all contributors!
> > > >
> > > > > +config MMC_LITEX
> > > > > +       tristate "LiteX MMC Host Controller support"
> > > > > +       depends on OF
> > > > > +       depends on PPC_MICROWATT || LITEX || COMPILE_TEST
> > > > > +       help
> > > > > +         This selects support for the MMC Host Controller found in LiteX SoCs.
> > > > > +
> > > > > +         If unsure, say N.
> > > >
> > > > What would be the module name if built as a module?
> > >
> > > litex_mmc.ko -- why are you asking? I.e., should I mention that anywhere
> > > in the Kconfig blurb (I don't see other blurbs doing that, fwiw)?
> > 
> > Many (most?) blurbs do mention the module name.
> 
> I was doubting this as well, but I searched and its true.  The text 'module will
> be called' shows up many times, there is also different text.
> 
>  $ grep -r 'module will be called' drivers/ | wc
>    1347    9023   9086
> 
>  $ grep -r 'tristate \"' drivers/ | wc
>    7169   47486  521795

OK, so initially I quickly looked at a few entries before LiteX in the
drivers/mmc/host/Kconfig file, and saw nothing useful, and asked a
follow-up question... :)

Knowing the magic "module will be called" incantation to grep for helped,
and now I created a similar one for LiteSDCard's Kconfig entry, and lined
it up for v7.

Thanks to everyone who chimed in!

Best,
--Gabriel