To:     Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc:     "Martin K. Petersen" <martin.petersen@oracle.com>,
        "Maciej W. Rozycki" <macro@orcam.me.uk>,
        Douglas Gilbert <dgilbert@interlog.com>,
        Khalid Aziz <khalid@gonehiking.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Christoph Hellwig <hch@lst.de>, Nix <nix@esperi.org.uk>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] scsi: Set allocation length to 255 for ATA
 Information VPD page
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1mtk7wsmb.fsf@ca-mkp.ca.oracle.com>
References: <alpine.DEB.2.21.2201020010540.56863@angie.orcam.me.uk>
        <alpine.DEB.2.21.2201020030130.56863@angie.orcam.me.uk>
        <d9eaa1f8-7abb-645b-d624-5069205c6983@interlog.com>
        <alpine.DEB.2.21.2201032017290.56863@angie.orcam.me.uk>
        <yq1tuek347m.fsf@ca-mkp.ca.oracle.com>
        <alpine.DEB.2.21.2201032324230.56863@angie.orcam.me.uk>
        <yq1tuej1j22.fsf@ca-mkp.ca.oracle.com>
        <yq1lezty169.fsf@ca-mkp.ca.oracle.com>
        <3cb24d6e-d52c-827f-7905-8e17411b23e1@opensource.wdc.com>
Date:   Fri, 07 Jan 2022 09:07:59 -0500
In-Reply-To: <3cb24d6e-d52c-827f-7905-8e17411b23e1@opensource.wdc.com> (Damien
        Le Moal's message of "Thu, 6 Jan 2022 14:21:24 +0900")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JL16YncUNL/iORzzRtgaQ6Uh2ClGJDABCsaWp6pdCimamyEW1P4xenwOvmJV?=
 =?us-ascii?Q?EiEZqdThdui7+K2Gp+njbD7MJeGBf0xEHlwekOPOoKyNOPg6vgimjPrXwpPj?=
 =?us-ascii?Q?oVSjlrjElNmP8kw1SUx69p8aaHV4HOwfOxdOUFuzg+ikvz1yCfdJtnaKWiYO?=
 =?us-ascii?Q?1jb04NHbvW7NMijU0G1zGjk1nYYW6rjKYUa3k9KiSnI123DZfOo6yranRIu9?=
 =?us-ascii?Q?jlTO9MVAwo9Zg/I2x0xN1kSAZI5jyWtSEeziibxQK/bXEWSfQVATS7rd53YA?=
 =?us-ascii?Q?pVOeVKnDEOlW3iHMTgEve88YPB+4Ki/o/m59E04YzOtYlMqb7vKYGYKKqopu?=
 =?us-ascii?Q?BvK8L8bwM0XjUeAfnkkEQACVytbz2BMF9qjnh0Hx4cLFwYnt8byY4SekS5Q/?=
 =?us-ascii?Q?HV77VZnHZdiEtnqqPMj+2so1WEFxmvsWDGJ4TELSeqWLHFmf9r8yPFJbRw44?=
 =?us-ascii?Q?ZU6sX1VV7/uLhmV3/hnP1zNsd0EAULs/+n75rtObdpRUC0YvyjS1fqPcK4IX?=
 =?us-ascii?Q?OCWXy6oLXEG8RsoVkKAcgw8pFOKguf2YqB/T/9N/L8EUsRyiX0QJW/aFAR6u?=
 =?us-ascii?Q?jONJYJ4ZH2cGnRWzmMxZBfU2sii896bngM3MKb8jXFmp7ZUX3IenceJw0DQC?=
 =?us-ascii?Q?AhgbkMDk+k/rnGlYOGRmztpIvKcaE15ahQ9G1viOUzkmgKL8DQNUtQZaDt/v?=
 =?us-ascii?Q?ZxxqBTKZmka0qt8Yyv6o1WEiAgaSiGbKcmoWXx3AphOhg31iafYKpKiIsuxy?=
 =?us-ascii?Q?qSR+xj/DfTbLiFy8nZCIbbAPycneq4B2B93pqqE97PDoVXVIa5P9aBwSWpaa?=
 =?us-ascii?Q?eLzAuHGTF1+iRxz88EMt4L0lWT1Yi6s8HT+6/VmInSfCnC2SkwsoPJeNTcUz?=
 =?us-ascii?Q?7/cHjXdgmqyy+UOzGIHYZjTS/3rGekdJnQrHZL/2wu79j8cUzpEYAQy+U034?=
 =?us-ascii?Q?2FqfrnUPNA9GV8njdsalrHl1GXV69rFAJKB7V/vB7i+bRqiFFhGWZxo0RSbo?=
 =?us-ascii?Q?obsZWXK8Pply5BRmFvVA8cMewV0C6NwlFd8U/cEJLlrN2DJKTi1I2TAfleSg?=
 =?us-ascii?Q?p978SCcGqVUyGmaB6ewYLplO0tofnocJhiIl6TS6XgrjRARcPuFhFfZ5yKsj?=
 =?us-ascii?Q?RpkrnOtMb0dZw5ZbwO+ZVG8ARnORURfTce9yasYw4pKhYSy7i24m5RizSblg?=
 =?us-ascii?Q?OoutBB8D8gN2ghvfMMb+PQfui3NhxOWNfiJY/85LSGZnA0ZBApNf5SnvZI0L?=
 =?us-ascii?Q?zGXlkVes4MYupmLlRTFEZlBsDlmBKMwRotvYhYpq6cVoEdPV7wL+yzdOlfL+?=
 =?us-ascii?Q?RH08MeCMk0BacBoG6F4QMGB4JgyWUc61dkhZmkqITGKsTm0oqS510Gw/4xmw?=
 =?us-ascii?Q?qs3cz2edzAwpcgxeY64M68x1YVuLib1Bu5qo+rxbln2nWjks95XiaF9u4mTa?=
 =?us-ascii?Q?1PCBKvUpxC2vgJI5S/NWHwDZhssZAX+MPagL+FnIrvrrF5iMdKU4Xfusn9QC?=
 =?us-ascii?Q?ASWUh1Kgj2BhJgUcr/MUKCFOta9Vmvi/q+J4wY1/3/1kYNBMBrovf0+HsyVF?=
 =?us-ascii?Q?Y8bD54ph1O5FazMOwvQ4wmnnBd47x+0wA9Ib1uqFFF1Dh+tu4uA47R9vRPkc?=
 =?us-ascii?Q?4KFx89gUINN8dC4OeME5n8u9esqnkIIv/NLog8H6boRGJ/m8+4WBlsuaJMpR?=
 =?us-ascii?Q?tGBwMw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af22abe6-152c-4209-16f6-08d9d1e71d73
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2022 14:08:01.2305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9iMV1cQCdkm6PPn6a8eTxU9VOLVRml6p5KaFmiJRp67b+AhyCLUEjMoep9jSsRvwACbbaoXQaIdycerxqFxPPz68qXil8GDJynYtWOE66fg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5531
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10219 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 mlxlogscore=933 adultscore=0 suspectscore=0 mlxscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201070097
X-Proofpoint-GUID: kLkoGmJpZbYb1WtuyB9FM1pOkcX9EB4e
X-Proofpoint-ORIG-GUID: kLkoGmJpZbYb1WtuyB9FM1pOkcX9EB4e
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Damien,

> That said, it is weird that scsi_get_vpd_page() does not call
> scsi_device_supports_vpd(). 

The first patch in the series already makes that change.

I noticed because the allocation for sd_read_cpr() is fairly big so it
stuck out in my test runs while reworking scsi_get_vpd_page().

I didn't remove the conditional in sd_revalidate_disk(). While it is
superfluous, I do like that the "fancy" protocol features are
grouped. Guess we could switch it to a comment instead. I'll think about
it...

-- 
Martin K. Petersen	Oracle Linux Engineering