MIME-Version: 1.0
References: <20220106175019.3116389-1-festevam@gmail.com> <Ydc2EHf5f12w4YcW@sirena.org.uk>
 <CAOMZO5Czbr=vuvZdqc6+odAQv0M-LJEQVz6uke8OXnoG6wLqwA@mail.gmail.com>
 <YddLe8cCvj5fVBTQ@sirena.org.uk> <CAOMZO5B63zHEiZc-Z1AR8za6eWXX8y0wbYLmrVkXC85ewFSqbg@mail.gmail.com>
 <CAOMZO5DQEEHYJHv08nC=uYXbFtL9VTAatNAB8V5D_JHiQ0q=3A@mail.gmail.com> <Ydg/tOqbeT1Cg6sh@sirena.org.uk>
In-Reply-To: <Ydg/tOqbeT1Cg6sh@sirena.org.uk>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Fri, 7 Jan 2022 11:48:59 -0300
Message-ID: <CAOMZO5AJy7arJM9v9A6n84k7yzWEoBxX5zTakK50dL6obSR6WA@mail.gmail.com>
Subject: Re: [PATCH v2] regmap: debugfs: Free debugfs_name buffer after usage
To:     Mark Brown <broonie@kernel.org>
Cc:     Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 7, 2022 at 10:27 AM Mark Brown <broonie@kernel.org> wrote:

> I would have expected this to be prior to the call to _init() rather
> than actually in the call to _init() but OTOH this should work fine so
> meh.

Yes, I can call it prior to _init()  as you suggested:

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 21a0c2562ec0..f7811641ed5a 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -647,6 +647,7 @@ int regmap_attach_dev(struct device *dev, struct
regmap *map,
  if (ret)
  return ret;

+ regmap_debugfs_exit(map);
  regmap_debugfs_init(map);

  /* Add a devres resource for dev_get_regmap() */

Will send a patch shortly.

Thanks