Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161121AbXBAAnf (ORCPT ); Wed, 31 Jan 2007 19:43:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030511AbXBAAnf (ORCPT ); Wed, 31 Jan 2007 19:43:35 -0500 Received: from smtp.osdl.org ([65.172.181.24]:33662 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030509AbXBAAne (ORCPT ); Wed, 31 Jan 2007 19:43:34 -0500 Date: Wed, 31 Jan 2007 16:39:52 -0800 (PST) From: Linus Torvalds To: Andrew Morton cc: =?ISO-8859-1?Q?Pawe=C5_Sikora?= , Linux Kernel Mailing List , Christoph Hellwig , Pekka Enberg , "Siddha, Suresh B" , Martin Peschke , Adrian Bunk , Nick Piggin Subject: Re: Linux 2.6.20-rc7 In-Reply-To: <20070131162631.4ae5800d.akpm@osdl.org> Message-ID: References: <45C05150.6000802@agmk.net> <200702010037.48472.pluto@agmk.net> <20070131162631.4ae5800d.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 668 Lines: 24 On Wed, 31 Jan 2007, Andrew Morton wrote: > > It would be cleaner to check for negativity, but note that we keep > subtracting stuff from free_pages in the later loop, so we'd need to check > there as well. Yeah, not worth it. I'll just revert it. If we really want to do the micro-optimization that Nick was after, we can just do // 'min' is always positive min = (unsigned long) min >> 1; or something. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/