MIME-Version: 1.0
References: <20211110220050.2854-1-jirivanek1@gmail.com> <20220106190027.1498-1-jirivanek1@gmail.com>
 <CAGWqDJ6T6EGNjoc2qfNHLMdcuwcnJArF7a7sToRXJ90Zs57E_A@mail.gmail.com>
In-Reply-To: <CAGWqDJ6T6EGNjoc2qfNHLMdcuwcnJArF7a7sToRXJ90Zs57E_A@mail.gmail.com>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Fri, 7 Jan 2022 17:39:33 +0100
Message-ID: <CAG3jFyuWtQ4Zr1RhHjjzjOavzt7T2_z9bHVZJ2vDXCjSEuWztA@mail.gmail.com>
Subject: Re: [PATCH v2] drm/bridge/tc358775: Fix for dual-link LVDS
To:     Vinay Simha B N <simhavcs@gmail.com>
Cc:     Jiri Vanek <jirivanek1@gmail.com>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 6 Jan 2022 at 20:22, Vinay Simha B N <simhavcs@gmail.com> wrote:
>
> Reviewed-by: Vinay Simha BN <simhavcs@gmail.com>
>
> Jiri Vanek,
> Could you please share the part number or datasheet of the dual-link LVDS display/panel used.
>
>
> On Fri, Jan 7, 2022 at 12:30 AM Jiri Vanek <jirivanek1@gmail.com> wrote:
>>
>> Fixed wrong register shift for single/dual link LVDS output.
>>
>> Tested-by: Jiri Vanek <jirivanek1@gmail.com>
>> Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
>>
>> ---
>> v1:
>> * Initial version
>>
>> v2:
>> * Tested-by tag added
>>
>> ---
>>  drivers/gpu/drm/bridge/tc358775.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
>> index 2272adcc5b4a..1d6ec1baeff2 100644
>> --- a/drivers/gpu/drm/bridge/tc358775.c
>> +++ b/drivers/gpu/drm/bridge/tc358775.c
>> @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
>>  }
>>
>>  #define TC358775_LVCFG_LVDLINK__MASK                         0x00000002
>> -#define TC358775_LVCFG_LVDLINK__SHIFT                        0
>> +#define TC358775_LVCFG_LVDLINK__SHIFT                        1
>>  static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
>>  {
>>         return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
>> --

Applied to drm-misc-next