MIME-Version: 1.0
References: <20220107030457.2383750-1-robh@kernel.org> <642312db-4af8-7087-45bf-e86923396038@ti.com>
 <762335b1-d6a2-64d2-75a1-f865cd557098@ti.com>
In-Reply-To: <762335b1-d6a2-64d2-75a1-f865cd557098@ti.com>
From:   Rob Herring <robh@kernel.org>
Date:   Fri, 7 Jan 2022 11:21:34 -0600
Message-ID: <CAL_JsqL85KE-WjBO1hkxw_VQdLTwZd8Bu0LzUaNXoABVoqK0TQ@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes
To:     Suman Anna <s-anna@ti.com>
Cc:     Ohad Ben-Cohen <ohad@wizery.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" 
        <linux-remoteproc@vger.kernel.org>, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Nagalla, Hari" <hnagalla@ti.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 7, 2022 at 8:17 AM Suman Anna <s-anna@ti.com> wrote:
>
> On 1/7/22 8:13 AM, Suman Anna wrote:
> > Hi Rob,
> >
> > On 1/6/22 9:04 PM, Rob Herring wrote:
> >> Based on the example, the TI K3 DSP and R5 have 2 mailboxes, but the schema
> >> says 1. Fix the schema.
> >
> > No, 1 is correct. The OMAP Mailbox binding uses #mbox-cells as 1 and not 0, and
> > uses a phandle as the cell-value.

That's unfortunate. Really, ti,mbox-tx/rx should have been the mbox
cells with 2 entries (rx and tx)...

>
> The following is what you get with your current patch,
>
> Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml:
> dsp@4d80800000: mboxes: [[4294967295, 4294967295]] is too short
> Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml:
> dsp@64800000: mboxes: [[4294967295, 4294967295]] is too short

Ugg, yes. What I'm working on is getting validation on dtb files to
work. That means the dts <> are lost and we have to either parse the
properties properly (look up #foo-cells) or use __fixups__ to find
unresolved phandles (the case for most examples). The latter works
most of the time except a few cases like above. So the fix here is to
add a mbox provider node to the example.

Rob