MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date:   Fri, 07 Jan 2022 20:03:59 +0200
From:   Nick Kossifidis <mick@ics.forth.gr>
To:     Nick Kossifidis <mick@ics.forth.gr>
Cc:     palmer@dabbelt.com, paul.walmsley@sifive.com,
        aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org, Alexandre Ghiti <alex@ghiti.fr>,
        stable@vger.kernel.org
Subject: Re: [PATCH 1/3] riscv: Don't use va_pa_offset on kdump
Organization: FORTH
In-Reply-To: <20211126180411.187597-1-mick@ics.forth.gr>
References: <20211126180411.187597-1-mick@ics.forth.gr>
Message-ID: <70fe8aa8bfe3923308e6248377577f58@mailhost.ics.forth.gr>
User-Agent: Roundcube Webmail/1.3.16
Precedence: bulk

Hello Palmer,

Any updates on those 3 patches ?

Regards,
Nick

Στις 2021-11-26 20:04, Nick Kossifidis έγραψε:
> On kdump instead of using an intermediate step to relocate the kernel,
> that lives in a "control buffer" outside the current kernel's mapping,
> we jump to the crash kernel directly by calling 
> riscv_kexec_norelocate().
> The current implementation uses va_pa_offset while switching to 
> physical
> addressing, however since we moved the kernel outside the linear 
> mapping
> this won't work anymore since riscv_kexec_norelocate() is part of the
> kernel mapping and we should use kernel_map.va_kernel_pa_offset, and 
> also
> take XIP kernel into account.
> 
> We don't really need to use va_pa_offset on riscv_kexec_norelocate, we
> can just set STVEC to the physical address of the new kernel instead 
> and
> let the hart jump to the new kernel on the next instruction after 
> setting
> SATP to zero. This fixes kdump and is also simpler/cleaner.
> 
> I tested this on the latest qemu and HiFive Unmatched and works as
> expected.
> 
> v2: I removed the direct jump after setting satp as suggested.
> 
> Fixes: 2bfc6cd81bd1 ("riscv: Move kernel mapping outside of linear 
> mapping")
> 
> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
> Reviewed-by: Alexandre Ghiti <alex@ghiti.fr>
> Cc: <stable@vger.kernel.org> # 5.13
> Cc: <stable@vger.kernel.org> # 5.14