Date:   Fri, 7 Jan 2022 20:43:35 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        guang.zeng@intel.com, jing2.liu@intel.com, kevin.tian@intel.com,
        seanjc@google.com, tglx@linutronix.de, wei.w.wang@intel.com,
        yang.zhong@intel.com
Subject: Re: [PATCH v6 05/21] x86/fpu: Make XFD initialization in
 __fpstate_reset() a function argument
Message-ID: <YdiX5y4KxQ7GY7xn@zn.tnic>
References: <20220107185512.25321-1-pbonzini@redhat.com>
 <20220107185512.25321-6-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220107185512.25321-6-pbonzini@redhat.com>
Precedence: bulk

On Fri, Jan 07, 2022 at 01:54:56PM -0500, Paolo Bonzini wrote:
> From: Jing Liu <jing2.liu@intel.com>
> 
> vCPU threads are different from native tasks regarding to the initial XFD
> value. While all native tasks follow a fixed value (init_fpstate::xfd)
> established by the FPU core at boot, vCPU threads need to obey the reset
> value (i.e. ZERO) defined by the specification, to meet the expectation of
> the guest.
> 
> Let the caller supply an argument and adjust the host and guest related
> invocations accordingly.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

If Jing is author, then tglx's SOB should come after Jing's to mean,
tglx handled it further.

As it is now, it looks wrong.

Ditto for patches 10, 11, 12, 13.

Also, I wonder if all those Signed-off-by's do mean "handled" or
Co-developed-by but I haven't tracked that particular pile so...

> Signed-off-by: Jing Liu <jing2.liu@intel.com>
> Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> Message-Id: <20220105123532.12586-6-yang.zhong@intel.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette