Subject: Re: [PATCH 0/2]
To:     Zhenneng Li <lizhenneng@kylinos.cn>,
        Alex Deucher <alexander.deucher@amd.com>,
        "Zhuo, Qingqing" <qingqing.zhuo@amd.com>, jasdeep.dhillon@amd.com
Cc:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Xinhui.Pan@amd.com, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Harry Wentland <harry.wentland@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Isabella Basso <isabbasso@riseup.net>
References: <20220107095732.982194-1-lizhenneng@kylinos.cn>
From:   Rodrigo Siqueira Jordao <rjordrigo@amd.com>
Message-ID: <95bcf269-3b41-f02d-c953-4c35ddf32307@amd.com>
Date:   Fri, 7 Jan 2022 17:51:47 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20220107095732.982194-1-lizhenneng@kylinos.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmVnZnp1eFYwZ3NrVWcwOUI2U20zVTdYTmhUOVJFR0VsMElLdXh5VEZyejI2?=
 =?utf-8?B?b1JiZE9UWVFLR05vc0JLM2p6K3JYSkwyRmx1ak9hTXlzVkRtOGdHd1B3b3cy?=
 =?utf-8?B?MisyZXk4eVhEQXEzRVdLT2hIdU0yTVJrSnEwVkp5ZjY2VStlVUFjR0xsM0M1?=
 =?utf-8?B?cEgxWVl0SjFUZXhQWm1DUXc5RkRLb2RMZy9kNjRQZHpzTjFNTEEwSGN3K0JW?=
 =?utf-8?B?M1lYRGJ6NDgrMUdVck9wOEd4eXk2c1VpQlNhVVNzRGQ2NDBpYjJwamh2NzhD?=
 =?utf-8?B?NzNabm5BN0pTaGZ4MGxJeGRIdmFZZkV4WjZseksxK09WQkNiS1BQdithOVNP?=
 =?utf-8?B?MVZoRDR6VnVPL0dCU0t2RnpLZFFzeXJZWmhBUlhlUEluSTlaNnJoUGRGQk81?=
 =?utf-8?B?OTJEajdtU1M3VUhCWDZaMkM1TkxSNlBTT0s0VHdOM1lrOUd1d3pSQ25HVGY1?=
 =?utf-8?B?dzUzZ3FsYjc3NGcvU1Y4NUovUXlBYlJTeHZtQmc3dGFpb2kvQXFzSkdFcVdE?=
 =?utf-8?B?N3Btb0V3ZkhFazloVzdCd2hmdkl1OVFFYkRDVHAxMFZtVjQ4Qi9zREhCdjBw?=
 =?utf-8?B?WmpKYmV6cDJJY2xISVB2UWhjWW12QytNYU8xeTdySThzZFpBWFREd2t6dno1?=
 =?utf-8?B?blQzR3FHUUpaZ3JpcTRKWUh0YmpvRXJWczFtWkovbVFVT2ZJd1I1Zmd1c09h?=
 =?utf-8?B?bHNybUZHVWhrVVNVSlMyOTVOR0pQem1DU0tzNWM0SVlySEZ4TjRsZTFZd1Mx?=
 =?utf-8?B?eWFWcmZNV2MwY2tCYis0blJaMS83WnFUbW5WUlZjbnYwUEVOOVBZY2FuY3Q5?=
 =?utf-8?B?VXhyVm5aRlBLN0F6S1RkcXFmL2o1d2RVMkptZHp0UGNtN1B3czdjdkhnTVBv?=
 =?utf-8?B?czdGRkJiOGNZbVlkREhJS3BuZ1BGZUxvR01yYlRqODU5YWJnZURzcUc1Qyti?=
 =?utf-8?B?UmFOeU5wenUzYi85VkpXaVRiMXRWMm9nWWVDd3poTUVHVGJuYjdhM3l3bWZu?=
 =?utf-8?B?SHkrNkV0NURwYnhUYzhRMVNnMVR4WVhCRVhCUStDQUtSQnZLOTA0RWIvK2dH?=
 =?utf-8?B?MElTQVdDMEVUKzFoYWI0cGZ4WEhEaVFoLzVpSm1IcWloQkREUTNiVExQdkNw?=
 =?utf-8?B?N1dLckxHb2FPWkViSFczZmNiSCtDTUxBUDhtUnNFUDFJYWVSTWc2blpNd0pt?=
 =?utf-8?B?TWtFbzVacU5iY2NobnNISkhsZUQ3VEFlQWtQVTJOdGJmZ2NjMUZiRDdUUVQ3?=
 =?utf-8?B?YmN3YzZGVDl5cW51RWloZWhTNWlWalFuTzg3dXhPaEkwRTcxY2wvbUw2czZM?=
 =?utf-8?B?bnNvbjEya2puTGMzU1VodFZpY3NpVTMzN1p1akp1cm9SaUtuYSs1Tjdqbmd3?=
 =?utf-8?B?SVJBYnY5bkVKSWtmaWNjTGZJTGxjRG1WUXhiNjJua3h5aUZ0dFoxVGZ2S3FS?=
 =?utf-8?B?NE5RWGwvUTJKb2VHaFg5T1JnUkJCTjBTYjNORW9UeFFLMm9rRDk1cUxZMFhl?=
 =?utf-8?B?Yk9rSHdpUnhZL242cWpSbTVCSUN5RHhsMmd3b2Evcm54U3FXanFSd1JwUXFm?=
 =?utf-8?B?cWtpOEVqWHNhaFZicHJlaDlYa05lZXUzcnY2aTlPZWJPZHZlelROZnlybVRp?=
 =?utf-8?B?bFpaSE13TFNDN3o4ZVFwSnN4TVBMYXJ4MG5GNjY3NGhlanVwdE8xeVJ5VVVq?=
 =?utf-8?B?ZTNFRlRwMkRvb0ltOWNzUFNyeHQzTnp0Mm91VEl1OWVVWFI3Vm51YUJOUG15?=
 =?utf-8?B?UjFIVTIrSk42QkZUNDdtcEUyTE93ME44RGE2ZmlFSStNMURFY3RiTm5qNkNE?=
 =?utf-8?B?N0haVElhdThPSm1UNWRIOHZQM1FRUFI4aGEybDJkTlJhcVQ3MTBmY0JHYUF0?=
 =?utf-8?B?OEpFMHJvOUJ6Kzc4a2dqLzZCV2tGRFVLSUFqQ2FSbXR2UEwxZDFkWk5vYmhG?=
 =?utf-8?B?Y3JmRTM5UEV6RnNIU1ZrWEFieTJRQ3JzUzhucWd2YXVBM3RlQ2hlOWw4NGVt?=
 =?utf-8?B?NEVwZTFwdmMyZWhWRzNBcGZaZFJqcGdGTTcvOGdCUWlXNk5jeklDN0Q4OHZM?=
 =?utf-8?B?bHFONFcrNVFlQ3l0WFgzemNBRDFKUHBVV1YzRFZLY0xURUJodUNUR1k0ZURT?=
 =?utf-8?B?RlpkRDNpY21LcXYwckFWYWhsRDRIRGdwdHhJTUlCcjJ6MnZqS21Ob1dVOWNC?=
 =?utf-8?B?aUFrR0R4UHhJWTdYcGRKYm5TQklicnB3ZzRRQ0NxdGpWQXY5N0tGbXNqd28v?=
 =?utf-8?Q?1u22th5fIykWmNI8hKjpn9yIUtXUYgziydW6oQNnoA=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d7699bf-0847-4439-55b0-08d9d2304b21
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2896.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2022 22:51:51.1844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 916qZseo5zb5eS/rnfdZnlTqEknJ37E1pjcPUZ2K31VVjrWcVm2+x4LaqjtsS2m3Xl+nISgAzlh4k1Su5n6UCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3184
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Zhenneng,

+ some display folks

First of all, thanks a lot for your patch.

We had a similar patch in the past, but we had to revert it because we 
cannot simply enable DCN for ARM-based systems. You can refer to this 
commit message to get a better context:

https://gitlab.freedesktop.org/agd5f/linux/-/commit/c241ed2f0ea549c18cff62a3708b43846b84dae3

Before enabling ARM, we first need to isolate all FPU code in the DML 
folder fully. You can read more about our strategy at the below link:

https://patchwork.freedesktop.org/series/93042/

And you can see some examples of this effort in the below links:

- https://patchwork.freedesktop.org/series/95504/
- https://patchwork.freedesktop.org/patch/455465/?series=94441&rev=3
- https://patchwork.freedesktop.org/series/98247/

Soon we will submit another series that isolate DCN302, but we still 
need to isolate code from DCN20, DCN10, DCN303, and DCN301.

If you want to help us speed up this process, feel free to look at 
DCN301 or DCN10.

Best Regards
Siqueira

On 2022-01-07 4:57 a.m., Zhenneng Li wrote:
> For adapting radeon rx6600 xt on arm64 platform,
> there report some compile errors.
> 
> Zhenneng Li (2):
>    drm/amdgpu: fix compile error for dcn on arm64
>    drm/amdgpu: enable dcn support on arm64
> 
>   drivers/gpu/drm/amd/display/Kconfig           |  2 +-
>   drivers/gpu/drm/amd/display/dc/calcs/Makefile |  6 +++++
>   .../gpu/drm/amd/display/dc/clk_mgr/Makefile   |  7 ++++++
>   drivers/gpu/drm/amd/display/dc/dcn10/Makefile |  4 +++
>   drivers/gpu/drm/amd/display/dc/dcn20/Makefile |  4 +++
>   .../gpu/drm/amd/display/dc/dcn201/Makefile    |  6 +++++
>   drivers/gpu/drm/amd/display/dc/dcn21/Makefile |  4 +++
>   drivers/gpu/drm/amd/display/dc/dcn30/Makefile |  6 +++++
>   .../gpu/drm/amd/display/dc/dcn302/Makefile    |  6 +++++
>   .../gpu/drm/amd/display/dc/dcn303/Makefile    |  6 +++++
>   drivers/gpu/drm/amd/display/dc/dcn31/Makefile |  6 +++++
>   drivers/gpu/drm/amd/display/dc/dml/Makefile   | 25 +++++++++++++++++++
>   drivers/gpu/drm/amd/display/dc/dsc/Makefile   |  7 ++++++
>   13 files changed, 88 insertions(+), 1 deletion(-)
>