Message-ID: <d4ae974f38d96bc02db6c137e622315388a99ba0.camel@nxp.com>
Subject: Re: [PATCH] drm/atomic: Check new_crtc_state->active to determine
 if CRTC needs disable in self refresh mode
From:   Liu Ying <victor.liu@nxp.com>
To:     Alex Deucher <alexdeucher@gmail.com>
Cc:     Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Rob Clark <robdclark@chromium.org>,
        David Airlie <airlied@linux.ie>,
        Sean Paul <seanpaul@chromium.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Thomas Zimmermann <tzimmermann@suse.de>
Date:   Sat, 08 Jan 2022 10:07:10 +0800
In-Reply-To: <CADnq5_PsxrYeZ+p5NbXRks3EaJrYNMN+vbUJkiKHZ4cf=x=dsg@mail.gmail.com>
References: <20211230040626.646807-1-victor.liu@nxp.com>
         <CADnq5_PsxrYeZ+p5NbXRks3EaJrYNMN+vbUJkiKHZ4cf=x=dsg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXFIUzNQQ0VnOTlXcjJKT2o5cnVtYUR1a1VvbmRoTHBBb090WkFrWjgzYS92?=
 =?utf-8?B?d3dTdWVoRUpiTTdpaEcvMlBTSTJ6SEN5SFZMS0gzempld0FpVEN1RjVNM2Fn?=
 =?utf-8?B?TVJxK2pvblZ4S0lyVjJMbXh1Q2xCTy9zTktPbnQ4UWFqd2lnUlFwWEJJZ1Z2?=
 =?utf-8?B?UnpkZVd1RWNId2tuNWNEMzRrT1BvK3hBWXpob2NLQXhpMWNvTFRrc1RsSnE4?=
 =?utf-8?B?a1BicGEvc3F1YUJGbkEvZE9GM3pwV2F3THFGcTZaMmVrak1xOXNSQ3ZsWThV?=
 =?utf-8?B?MGJZUS9xQ2tYU3ErR3IxK2JpMWtMUjV6L1l1Z1NHU3dxVGtxQkM1Z09LeTky?=
 =?utf-8?B?eGs1L0E1ZWl4ZjFiUVZ2dDUzbFoyOTlRV0hxVDN2UjVVNjNWdGxscEx0M29I?=
 =?utf-8?B?NVY1NCtsVU14Y2xKSUZKcnk4YllmMUtSL0I5dEpTRmVTNHJpT2FjUTc2aldw?=
 =?utf-8?B?UmREc1VXYTAvVHpzK3IvVlRpWkczK0dmeXdHM3NnRm05RStiQjZ1akFHRW1T?=
 =?utf-8?B?V25SZ2ltYlA2amN2UW1oOWNvOHRIWkpvUDBCc1RiK2E2ZnNzT3Z2VnV6Q1dq?=
 =?utf-8?B?cFJNTldYSzYyRmx4cExSeldoSzM2TXkvNXNEVDFWTm1YUnBRdnRUTlQ3WnMr?=
 =?utf-8?B?ZHJhQ3A2MnNnZGRGZTlPL1FnaFV5SlgybWNFTVZOUDR5cVI0VnpiUGYzcWNW?=
 =?utf-8?B?T1pTWHBrbW5TSFkvTGJ5VWpTQ3ltdmkzQXF3QVRrZkUyV1U4aXFyMDNJWnln?=
 =?utf-8?B?d2NyRWtJZUZObCtVTmRMRUtyMSswMFdjelJkdWVqNFMwT0FuRFRHVG96eVhp?=
 =?utf-8?B?MXAzRlorSnNtTVpuN0tmdk9mYW1jYkFnMXl6TmUyRHZxaGRsY2E2Zm5XcWlK?=
 =?utf-8?B?K2I4VUdJUjNSaEJpU29VSXJmTERtd0VaS3g2cnpMRDgxcEtPYUlDb3E4VVky?=
 =?utf-8?B?RkwvRUFJdnRVelFvNkNnTExnM0V0WjMrdHVycWk5RldsWDNGZ0gzWVRVL3A3?=
 =?utf-8?B?Mml0Rks5eVJsM29HUStNSEhNeVZTVzJ4c2VxNEdkZXZrK3RiU2VDay9FY2d0?=
 =?utf-8?B?cUFBdHZiaHd0UW1DY2orSW5weGVETkRhbVh0UnI1S3A5dTBpM2d4dUZ6Tk80?=
 =?utf-8?B?ZEtET1lnVkVXVUxESHhsL0JZNlhjYk8vc2Q5dmJiT3llYUNOamVuTHhOVnlw?=
 =?utf-8?B?cjRoUTVwR2JvbUltOWVzSWtVbUVpczB0eFdidkRhSk5tVHVMdjJFL2tQdk1Q?=
 =?utf-8?B?QTJreTh0MjhHbkdjZ2dPSnBjbzdSSFNvb2tJUnVUa0k5TVhuYjY2SmdGbDho?=
 =?utf-8?B?cFV2QlRDVDhWcjkyY2Nkc1BlaFJRRk1pdXdBenZGZTJMZlNrbnJwYk8wdzli?=
 =?utf-8?B?ZWh0WkdsanJBV2l6RlZXeDdTWVhaSjNRcE9RQ1U1S2JnRTFqTjZKSnZQeVVu?=
 =?utf-8?B?K3kwWXFNRUU5eXB6ZVZiTDdFQkIwYzFCSGdQS0ZLbzkyaExGcThZdUR0MXZT?=
 =?utf-8?B?L2FMOThuQ1NIR2M1eGFLNWJINy9PWmpvMS9tSzBWeE9TNGx6WFRQSVQ0L2sy?=
 =?utf-8?B?VmpBZFpvVW1YeGlIREhGUmlrT0xocFJoL1hla3BrNlJPRGpWMGh2aDY4S2lw?=
 =?utf-8?B?L3h2UXZKM2xLa0xPaUVoWUREc1A0MytYbTBFalNDMTRVY2RHZDZMZ3I2eUtH?=
 =?utf-8?B?aEZPVUQ5dzN2Tjc5dlZsWlZxNFFUR3cyZG1iajlOUFVxVTk2dXJoR1M4N25R?=
 =?utf-8?B?OGxtV1drdDcrV2x2OWtRTHVnUVYwZGlOK2gwT2xFZ0RNTjlQRC96RjdOTHFB?=
 =?utf-8?B?SGYxKzVyVWJUK1lZWUl2TkF0SjM0YWgwSDk3REpNbVR0ZWRYREtsWmxBZjFp?=
 =?utf-8?B?ejRkU3ZoTm9maERhTEpjeDlZcFFkS3FpZEFNL2xweTV2SzJJMFh4RjBXWGow?=
 =?utf-8?B?enQwNHFFOEtjVjFJdTA3VnBPNHo1b0JpT3R3d1lQNlc1T0ZXck9LWmR4ZHlO?=
 =?utf-8?B?TVl0dy96VkRWVEFiSVY4dENybjdEVWp4cXlTZXZqZXMxOHNoSWV2K2NPNHly?=
 =?utf-8?B?blNnTkdFT2hSQWxndEk4QTM5ZW9LSVBoUE9KUDFaSUpIMnY0RDFiMWhjejdv?=
 =?utf-8?B?NkF6bWRjbmxENzBMektqQWVWZzhMOVVmbGo4VlJOT2ZTOTBIVGJVWDMyeDNq?=
 =?utf-8?Q?Or3qLC4DHnj03Pz/Nhgyixk=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 330d50a9-f640-48f8-8bf3-08d9d24ba540
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2022 02:07:38.8205
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Rorh/o5098AzeKVsoUeCZp5cJCRKBO7CL+3OjFuPPJ2SRwT1LDIlrXRWeDDLTr9F6OfU5+I2VQ7cnrm5ajXmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6871
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2022-01-07 at 14:53 -0500, Alex Deucher wrote:
> On Wed, Dec 29, 2021 at 11:07 PM Liu Ying <victor.liu@nxp.com> wrote:
> > 
> > Actual hardware state of CRTC is controlled by the member 'active'
> > in
> > struct drm_crtc_state instead of the member 'enable', according to
> > the
> > kernel doc of the member 'enable'.  In fact, the drm client modeset
> > and atomic helpers are using the member 'active' to do the control.
> > 
> > Referencing the member 'enable' of new_crtc_state, the function
> > crtc_needs_disable() may fail to reflect if CRTC needs disable in
> > self refresh mode, e.g., when the framebuffer emulation will be
> > blanked
> > through the client modeset helper with the next commit, the member
> > 'enable' of new_crtc_state is still true while the member 'active'
> > is
> > false, hence the relevant potential encoder and bridges won't be
> > disabled.
> > 
> > So, let's check new_crtc_state->active to determine if CRTC needs
> > disable
> > in self refresh mode instead of new_crtc_state->enable.
> > 
> > Fixes: 1452c25b0e60 ("drm: Add helpers to kick off self refresh
> > mode in drivers")
> > Cc: Sean Paul <seanpaul@chromium.org>
> > Cc: Rob Clark <robdclark@chromium.org>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> 
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> 
> Do you need someone to push this for you?

Yes, please.  Thanks.

Liu Ying

> 
> Alex
> 
> > ---
> >  drivers/gpu/drm/drm_atomic_helper.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_atomic_helper.c
> > b/drivers/gpu/drm/drm_atomic_helper.c
> > index a7a05e1e26bb..9603193d2fa1 100644
> > --- a/drivers/gpu/drm/drm_atomic_helper.c
> > +++ b/drivers/gpu/drm/drm_atomic_helper.c
> > @@ -1016,7 +1016,7 @@ crtc_needs_disable(struct drm_crtc_state
> > *old_state,
> >          * it's in self refresh mode and needs to be fully
> > disabled.
> >          */
> >         return old_state->active ||
> > -              (old_state->self_refresh_active && !new_state-
> > >enable) ||
> > +              (old_state->self_refresh_active && !new_state-
> > >active) ||
> >                new_state->self_refresh_active;
> >  }
> > 
> > --
> > 2.25.1
> >