IronPort-SDR: stbXmIIZMtznk5lAw/OPO2AB7oG6s7PuPQCYm4dKmynmg4sadozNkBN5/6STVDRTSslW7PZ0UM
 RBtgHvUJSxkRFnvSsPSjJQjEBMA86B/9gbK5upryOUVaIyRT6D6dbcAFSQJ7M1twHsGpxxSHF1
 5Bo7+Vtoe/Jn6zHwWM6wh01E8yFCr+bELeOO01s5fH3MRKlkG2FYmD7LGbLG10sHDUJk3vDHK8
 4bxLA1Ci6Y8sCN/McsDNSGggFus6y5u3YGQ1kcKRcTAu+Fnq30PrYOUrG4q9e0h9Bifq5ofpCh
 +vYiFewrxvlL0poC/1jRyNms
IronPort-SDR: EV69dzOK+BCNsdBb3wJ/jNAf9G4PPWRY3YGMbmtfnRj4FA1qJAuufyxX54k/6lXKQTcDnnVFs2
 V5R8CYPJRGaagBBAqYwJhqIV1xiJA1Q1eycKMHAV741Zr9Qjw0vPTyZnWfc65IKfHdfg7iKjv/
 NzWqUWmvRdOxXg9A7l7leHr14W5gFdrFITX8gZ9ZSFVGC+6QYSP0VYpn1+Zfg17+6We+3VCMF7
 KU7qaQLIEihzWwoS+1tAX5F5GWwniIUpUXFHyvtdi+36BnZ4Gjf57BIwtnXTDvR+ls+71aWq4u
 Ytw=
WDCIronportException: Internal
Message-ID: <177f3741-ca31-b5ac-69ff-1adf346f1199@opensource.wdc.com>
Date:   Sat, 8 Jan 2022 11:53:42 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap
Content-Language: en-US
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, David.Laight@ACULAB.COM,
        davem@davemloft.net,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220107125308.4057544-1-jiasheng@iscas.ac.cn>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital
In-Reply-To: <20220107125308.4057544-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/01/07 21:53, Jiasheng Jiang wrote:
> In linux-stable-5.15.13, this file has been removed and combined
> to `drivers/ata/pata_platform.c` without this bug.
> But in the older LTS kernels, like 5.10.90, this bug still exists.
> As the possible failure of the devres_alloc(), the devm_ioremap() and
> devm_ioport_map() may return NULL pointer.
> And then, the 'base' and 'alt_base' are used in plat_ide_setup_ports().
> Therefore, it should be better to add the check in order to avoid the
> dereference of the NULL pointer.
> Actually, it introduced the bug from commit 8cb1f567f4c0
> ("ide: Platform IDE driver") and we can know from the commit message
> that it tended to be similar to the `drivers/ata/pata_platform.c`.
> But actually, even the first time pata_platform was built,
> commit a20c9e820864 ("[PATCH] ata: Generic platform_device libata driver"),
> there was no the bug, as there was a check after the ioremap().
> So possibly the bug was caused by ide itself.
> 
> Fixes: 8cb1f567f4c0 ("ide: Platform IDE driver")
> Cc: stable@vger.kernel.org#5.10

Please keep the space before the #

Cc: stable@vger.kernel.org #5.10

> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog
> 
> v1 -> v2
> 
> * Change 1. Correct the fixes tag and commit message.
> 
> v2 -> v3
> 
> * Change 1. Correct the code.

As commented before, what exactly was corrected ? That is what needs to be
mentioned here. In any case, I fail to see what code change you added between v2
and v3. The code changes are identical in the 2 versions.

> ---
>  drivers/ide/ide_platform.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/ide/ide_platform.c b/drivers/ide/ide_platform.c
> index 91639fd6c276..5500c5afb3ca 100644
> --- a/drivers/ide/ide_platform.c
> +++ b/drivers/ide/ide_platform.c
> @@ -85,6 +85,10 @@ static int plat_ide_probe(struct platform_device *pdev)
>  		alt_base = devm_ioport_map(&pdev->dev,
>  			res_alt->start, resource_size(res_alt));
>  	}
> +	if (!base || !alt_base) {
> +		ret = -ENOMEM;
> +		goto out;
> +	}
>  
>  	memset(&hw, 0, sizeof(hw));
>  	plat_ide_setup_ports(&hw, base, alt_base, pdata, res_irq->start);

Greg,

The above patch is OK but cannot be applied in the current kernel:
* The Legacy IDE drivers were removed in 5.14, replaced by the already existing
* The current equivalent libata driver (drivers/ata/pata_platform.c) already has
the above error check.

So I think this patch needs to go directly to stable # 5.10 and earlier LTS
kernels. Can you take it ?

Feel free to add:

Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

Note that I was not the maintainer of the IDE drivers. If more appropriate
please feel free to replace that with a Reviewed-by tag.

Thanks !

-- 
Damien Le Moal
Western Digital Research