Message-ID: <c2923957-9719-ef23-802a-24765ead7630@igalia.com>
Date:   Sat, 8 Jan 2022 12:36:32 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] notifier/panic: Introduce panic_notifier_filter
Content-Language: en-US
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dyoung@redhat.com" <dyoung@redhat.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "bhe@redhat.com" <bhe@redhat.com>,
        "vgoyal@redhat.com" <vgoyal@redhat.com>,
        "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "halves@canonical.com" <halves@canonical.com>,
        "kernel@gpiccoli.net" <kernel@gpiccoli.net>
References: <20220107191233.172644-1-gpiccoli@igalia.com>
 <CAHp75Vf8SisR16tK=hwiF9ET0PoQRcu1h5LCZHZAGX8M3KysRA@mail.gmail.com>
From:   "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <CAHp75Vf8SisR16tK=hwiF9ET0PoQRcu1h5LCZHZAGX8M3KysRA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 07/01/2022 20:07, Andy Shevchenko wrote:
> [...] 
>     +       if (!buf)
>     +               return -EINVAL;
> 
> 
> I also implied that you don’t need this condition.
> 
>     +       while ((func = strsep(&buf, ","))) {
>     +               addr = kallsyms_lookup_name(func);
> 
>  
> 
>     +
> 
> 
> Btw, this is redundant blank line.
>  
> 
>     +               if (!addr) {

Thanks Andy, just submitted a V4 that incorporates your suggestions.
Cheers,


Guilherme