Date:   Sun, 9 Jan 2022 12:37:16 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc:     linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH] can: flexcan: add ethtool support to get rx/tx ring
 parameters
Message-ID: <20220109113716.r4l432ixsjbbcwtu@pengutronix.de>
References: <20220108181633.420433-1-dario.binacchi@amarulasolutions.com>
 <20220108201650.7gp3zlduzphgcgkq@pengutronix.de>
 <CABGWkvoGs_VBGD-7dt18LY9NV=63w50OceKjmaKYeqDe_WJk9g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="rzgzvcem3jngzhan"
Content-Disposition: inline
In-Reply-To: <CABGWkvoGs_VBGD-7dt18LY9NV=63w50OceKjmaKYeqDe_WJk9g@mail.gmail.com>
Precedence: bulk


--rzgzvcem3jngzhan
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 09.01.2022 12:22:54, Dario Binacchi wrote:
> > >  static const struct ethtool_ops flexcan_ethtool_ops =3D {
> > > +     .get_ringparam =3D flexcan_get_ringparam,
> > >       .get_sset_count =3D flexcan_get_sset_count,
> > >       .get_strings =3D flexcan_get_strings,
> > >       .get_priv_flags =3D flexcan_get_priv_flags,
> >
> > BTW: If you're looking for more TX performance, this can be done by
> > using more than one TX buffer.
>=20
> I didn't expect only one message buffer to be used for transmission

It was easier to implement, but now we've sorted it out how to implement
multiple TX buffers race free and lock-less. Have a look at the
mcp251xfd driver.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--rzgzvcem3jngzhan
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmHayOgACgkQqclaivrt
76nPQgf/an5RfIK7HvAVii+TyXj7m/vfw+8gGayLUQxfMEeCZsdHBk25wsM76unP
Mu4faJe15cxzs3whPcdpbDfMFC2t8zXSOjf2vlCcbjmqS0IOfxFIijYodI7KCFpO
KPa13t6DDuJRLVzKi4TEEw/GgVNKQMbjN6TDpFLxgEf6Iz7V+DWf2brvyqRDRy5M
+2qF/6403FycAUzgyo230UXGhLxdWn8Ac1XUx84xnqzXKs7v94iN2WR0HxynEL70
bZz2FBDCpVwSnoL3iL7Kw5gKoXmVHJHXrV/MrAbEaEovT/axW+SMNr/lX5n7tYVj
wt03+WrvEkPkMoA3fIRWvXv3WCXUTg==
=M/Pi
-----END PGP SIGNATURE-----

--rzgzvcem3jngzhan--