Date:   Sun, 9 Jan 2022 16:48:17 -0100
From:   Melissa Wen <mwen@igalia.com>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     dave.stevenson@raspberrypi.com, emma@anholt.net, airlied@linux.ie,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        eric@anholt.net
Subject: Re: [PATCH v2] drm/v3d: Fix PM disable depth imbalance in
 v3d_platform_drm_probe
Message-ID: <20220109174817.drma7zfckeywvndc@mail.igalia.com>
References: <CAPY8ntAdknutH=OmV1dWPbez1ZqLgaOj-BoQQkZAu0WbhbE6nQ@mail.gmail.com>
 <20220106124657.32737-1-linmq006@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ee43ywlavjqsjxzn"
Content-Disposition: inline
In-Reply-To: <20220106124657.32737-1-linmq006@gmail.com>
Precedence: bulk


--ee43ywlavjqsjxzn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 01/06, Miaoqian Lin wrote:
> The pm_runtime_enable will increase power disable depth.
> If the probe fails, we should use pm_runtime_disable() to balance
> pm_runtime_enable().
>=20
> Fixes: 57692c9 ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.=
x+")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> Changes in v2
> - put pm_runtime_disable before dma_free_wc
> - rename dma_free to pm_disable
> ---
>  drivers/gpu/drm/v3d/v3d_drv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
> index bd46396a1ae0..7d500dd5314e 100644
> --- a/drivers/gpu/drm/v3d/v3d_drv.c
> +++ b/drivers/gpu/drm/v3d/v3d_drv.c
> @@ -282,7 +282,7 @@ static int v3d_platform_drm_probe(struct platform_dev=
ice *pdev)
> =20
>  	ret =3D v3d_gem_init(drm);
>  	if (ret)
> -		goto dma_free;
> +		goto pm_disable;
> =20
>  	ret =3D v3d_irq_init(v3d);
>  	if (ret)
> @@ -298,7 +298,8 @@ static int v3d_platform_drm_probe(struct platform_dev=
ice *pdev)
>  	v3d_irq_disable(v3d);
>  gem_destroy:
>  	v3d_gem_destroy(drm);
> -dma_free:
> +pm_disable:
> +	pm_runtime_disable(dev);

Hi,

I see this pm_runtime_disable balancing is also missing for
v3d_platform_drm_remove(), right?

BR,

Melissa
>  	dma_free_wc(dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr);
>  	return ret;
>  }
> --=20
> 2.17.1
>=20

--ee43ywlavjqsjxzn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEd8WOo/JViG+Tu+XIwqF3j0dLehwFAmHbH9wACgkQwqF3j0dL
ehwfGw//UjlDJVwtU17AnsPL+/W4lUJyxKJ8A34ElKhICjWegLZpByNFW3uxTjdS
hDNKBP5EnBthGwy4zk/gdqbl4s38d7p2PuFDX2DTofhbTkYOuV1TpgkdeVtAlKQR
7ktsKfZ7KHnSxQptfhywPpV4DXu3021rMY2FDqBU+ncJStrhMn4Q84ZNTatObjG3
pbVDL9r6RU03heGR/KrKJFdSAQx1D10JoChnnLBHdwIpgj786EN5cft4eKDRnyr7
kqN3Zov4BE2X02XFoLs2WpLam+f9se/cSPZLTT6E7KwYv9GnFeW/UuWsd3FLjM1D
aJUgVSXvE5PPpSNbMob1rkm31aToQlSEVztEW+wi4DxmQtIwHOWs4yFalpyjGoDS
/i4N9KCLIv2M2lThwXWzkp8PE0qFVGhxH0Hlx2j6WHw+8vMAiIxhL5O3R8pRDSRv
hRA87ag+GISXnRK14M4Q+86TrUKnzasrB/mGgN/UI7CQJNOA5gmQHKIsjSsnQeG2
1sgbznJ8VQTruLQ0qAjx07LMu+2ISiFgis6o7H/xdeZ0z6GuLTyntvm3VZ4IaiHu
37s2QQPyAD7GO7L/4kUjKjNGSHiu0x3kX/wuZ53lE0anE2X9JVUlfEXR0+GJmYbc
WYTCPgk9g9ZnQgvNJNP1tb7KLbnuvKxsV4gGTLGBQY46HfqTVlM=
=84uP
-----END PGP SIGNATURE-----

--ee43ywlavjqsjxzn--